From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964885AbeE3Gex (ORCPT ); Wed, 30 May 2018 02:34:53 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33737 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbeE3Ger (ORCPT ); Wed, 30 May 2018 02:34:47 -0400 X-Google-Smtp-Source: ADUXVKLtkRDmI9QMBG7xH1uOO1kr1QSXVKMGOs3qcSGTtUnhhimes9y4mY+FykjLVL//1rfG40iPjw== Subject: Re: [PATCH 3/8] xen/grant-table: Allow allocating buffers suitable for DMA To: Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, jgross@suse.com, konrad.wilk@oracle.com Cc: daniel.vetter@intel.com, dongwon.kim@intel.com, matthew.d.roper@intel.com, Oleksandr Andrushchenko References: <20180525153331.31188-1-andr2000@gmail.com> <20180525153331.31188-4-andr2000@gmail.com> <94de6bd7-405c-c43f-0468-be71efff7552@oracle.com> From: Oleksandr Andrushchenko Message-ID: Date: Wed, 30 May 2018 09:34:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <94de6bd7-405c-c43f-0468-be71efff7552@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/29/2018 10:10 PM, Boris Ostrovsky wrote: > On 05/25/2018 11:33 AM, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> Extend grant table module API to allow allocating buffers that can >> be used for DMA operations and mapping foreign grant references >> on top of those. >> The resulting buffer is similar to the one allocated by the balloon >> driver in terms that proper memory reservation is made >> ({increase|decrease}_reservation and VA mappings updated if needed). >> This is useful for sharing foreign buffers with HW drivers which >> cannot work with scattered buffers provided by the balloon driver, >> but require DMAable memory instead. >> >> Signed-off-by: Oleksandr Andrushchenko >> --- >> drivers/xen/Kconfig | 13 ++++ >> drivers/xen/grant-table.c | 124 ++++++++++++++++++++++++++++++++++++++ >> include/xen/grant_table.h | 25 ++++++++ >> 3 files changed, 162 insertions(+) >> >> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig >> index e5d0c28372ea..3431fe210624 100644 >> --- a/drivers/xen/Kconfig >> +++ b/drivers/xen/Kconfig >> @@ -161,6 +161,19 @@ config XEN_GRANT_DEV_ALLOC >> to other domains. This can be used to implement frontend drivers >> or as part of an inter-domain shared memory channel. >> >> +config XEN_GRANT_DMA_ALLOC >> + bool "Allow allocating DMA capable buffers with grant reference module" >> + depends on XEN > > Should it depend on anything from DMA? CONFIG_HAS_DMA for example? Yes, it must be "depends on XEN && HAS_DMA", thank you > >> + help >> + Extends grant table module API to allow allocating DMA capable >> + buffers and mapping foreign grant references on top of it. >> + The resulting buffer is similar to one allocated by the balloon >> + driver in terms that proper memory reservation is made >> + ({increase|decrease}_reservation and VA mappings updated if needed). >> + This is useful for sharing foreign buffers with HW drivers which >> + cannot work with scattered buffers provided by the balloon driver, >> + but require DMAable memory instead. >> + >> config SWIOTLB_XEN >> def_bool y >> select SWIOTLB >> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c >> index d7488226e1f2..06fe6e7f639c 100644 >> --- a/drivers/xen/grant-table.c >> +++ b/drivers/xen/grant-table.c >> @@ -45,6 +45,9 @@ >> #include >> #include >> #include >> +#ifdef CONFIG_XEN_GRANT_DMA_ALLOC >> +#include >> +#endif >> >> #include >> #include >> @@ -57,6 +60,7 @@ >> #ifdef CONFIG_X86 >> #include >> #endif >> +#include >> #include >> #include >> >> @@ -811,6 +815,82 @@ int gnttab_alloc_pages(int nr_pages, struct page **pages) >> } >> EXPORT_SYMBOL(gnttab_alloc_pages); >> >> +#ifdef CONFIG_XEN_GRANT_DMA_ALLOC >> +/** >> + * gnttab_dma_alloc_pages - alloc DMAable pages suitable for grant mapping into >> + * @args: arguments to the function >> + */ >> +int gnttab_dma_alloc_pages(struct gnttab_dma_alloc_args *args) >> +{ >> + unsigned long pfn, start_pfn; >> + xen_pfn_t *frames; >> + size_t size; >> + int i, ret; >> + >> + frames = kcalloc(args->nr_pages, sizeof(*frames), GFP_KERNEL); >> + if (!frames) >> + return -ENOMEM; >> + >> + size = args->nr_pages << PAGE_SHIFT; >> + if (args->coherent) >> + args->vaddr = dma_alloc_coherent(args->dev, size, >> + &args->dev_bus_addr, >> + GFP_KERNEL | __GFP_NOWARN); >> + else >> + args->vaddr = dma_alloc_wc(args->dev, size, >> + &args->dev_bus_addr, >> + GFP_KERNEL | __GFP_NOWARN); >> + if (!args->vaddr) { >> + pr_err("Failed to allocate DMA buffer of size %zu\n", size); >> + ret = -ENOMEM; >> + goto fail_free_frames; >> + } >> + >> + start_pfn = __phys_to_pfn(args->dev_bus_addr); >> + for (pfn = start_pfn, i = 0; pfn < start_pfn + args->nr_pages; >> + pfn++, i++) { >> + struct page *page = pfn_to_page(pfn); >> + >> + args->pages[i] = page; >> + frames[i] = xen_page_to_gfn(page); >> + xenmem_reservation_scrub_page(page); >> + } >> + >> + xenmem_reservation_va_mapping_reset(args->nr_pages, args->pages); >> + >> + ret = xenmem_reservation_decrease(args->nr_pages, frames); >> + if (ret != args->nr_pages) { >> + pr_err("Failed to decrease reservation for DMA buffer\n"); >> + xenmem_reservation_increase(ret, frames); >> + ret = -EFAULT; >> + goto fail_free_dma; >> + } >> + >> + ret = gnttab_pages_set_private(args->nr_pages, args->pages); >> + if (ret < 0) >> + goto fail_clear_private; >> + >> + kfree(frames); >> + return 0; >> + >> +fail_clear_private: >> + gnttab_pages_clear_private(args->nr_pages, args->pages); >> +fail_free_dma: > > Do you need to xenmem_reservation_increase()? Yes, missed that on fail_clear_private error path, will fix > >> + xenmem_reservation_va_mapping_update(args->nr_pages, args->pages, >> + frames); >> + if (args->coherent) >> + dma_free_coherent(args->dev, size, >> + args->vaddr, args->dev_bus_addr); >> + else >> + dma_free_wc(args->dev, size, >> + args->vaddr, args->dev_bus_addr); >> +fail_free_frames: >> + kfree(frames); >> + return ret; >> +} >> +EXPORT_SYMBOL(gnttab_dma_alloc_pages); >> +#endif >> + >> void gnttab_pages_clear_private(int nr_pages, struct page **pages) >> { >> int i; >> @@ -838,6 +918,50 @@ void gnttab_free_pages(int nr_pages, struct page **pages) >> } >> EXPORT_SYMBOL(gnttab_free_pages); >> >> +#ifdef CONFIG_XEN_GRANT_DMA_ALLOC >> +/** >> + * gnttab_dma_free_pages - free DMAable pages >> + * @args: arguments to the function >> + */ >> +int gnttab_dma_free_pages(struct gnttab_dma_alloc_args *args) >> +{ >> + xen_pfn_t *frames; >> + size_t size; >> + int i, ret; >> + >> + gnttab_pages_clear_private(args->nr_pages, args->pages); >> + >> + frames = kcalloc(args->nr_pages, sizeof(*frames), GFP_KERNEL); > > Any way you can do it without allocating memory? One possibility is to > keep allocated frames from gnttab_dma_alloc_pages(). (Not sure I like > that either but it's the only thing I can think of). Yes, I was also thinking about storing the allocated frames array from gnttab_dma_alloc_pages(), but that seemed not to be clear enough as the caller of the gnttab_dma_alloc_pages will need to store those frames in some context, so we can pass them on free. But the caller doesn't really need the frames which might confuse, so I decided to make those allocations on the fly. But I can still rework that to store the frames if you insist: please let me know. > > >> + if (!frames) >> + return -ENOMEM; >> + >> + for (i = 0; i < args->nr_pages; i++) >> + frames[i] = page_to_xen_pfn(args->pages[i]); > > Not xen_page_to_gfn()? Well, according to [1] it should be :     /* XENMEM_populate_physmap requires a PFN based on Xen      * granularity.      */     frame_list[i] = page_to_xen_pfn(page); > >> + >> + ret = xenmem_reservation_increase(args->nr_pages, frames); >> + if (ret != args->nr_pages) { >> + pr_err("Failed to decrease reservation for DMA buffer\n"); >> + ret = -EFAULT; >> + } else { >> + ret = 0; >> + } >> + >> + xenmem_reservation_va_mapping_update(args->nr_pages, args->pages, >> + frames); >> + >> + size = args->nr_pages << PAGE_SHIFT; >> + if (args->coherent) >> + dma_free_coherent(args->dev, size, >> + args->vaddr, args->dev_bus_addr); >> + else >> + dma_free_wc(args->dev, size, >> + args->vaddr, args->dev_bus_addr); >> + kfree(frames); >> + return ret; >> +} >> +EXPORT_SYMBOL(gnttab_dma_free_pages); >> +#endif >> + >> /* Handling of paged out grant targets (GNTST_eagain) */ >> #define MAX_DELAY 256 >> static inline void >> diff --git a/include/xen/grant_table.h b/include/xen/grant_table.h >> index de03f2542bb7..982e34242b9c 100644 >> --- a/include/xen/grant_table.h >> +++ b/include/xen/grant_table.h >> @@ -198,6 +198,31 @@ void gnttab_free_auto_xlat_frames(void); >> int gnttab_alloc_pages(int nr_pages, struct page **pages); >> void gnttab_free_pages(int nr_pages, struct page **pages); >> >> +#ifdef CONFIG_XEN_GRANT_DMA_ALLOC >> +struct gnttab_dma_alloc_args { >> + /* Device for which DMA memory will be/was allocated. */ >> + struct device *dev; >> + /* >> + * If set then DMA buffer is coherent and write-combine otherwise. >> + */ > Single-line comment will fix > >> + bool coherent; >> + /* >> + * Number of entries in the @pages array, defines the size >> + * of the DMA buffer. >> + */ > This can be made into single line comment as well. However, I am not > sure this comment as well as those below are necessary. Fields names are > self-describing IMO. will remove > > -boris Thank you, Oleksandr >> + int nr_pages; >> + /* Array of pages @pages filled with pages of the DMA buffer. */ >> + struct page **pages; >> + /* Virtual/CPU address of the DMA buffer. */ >> + void *vaddr; >> + /* Bus address of the DMA buffer. */ >> + dma_addr_t dev_bus_addr; >> +}; >> + >> +int gnttab_dma_alloc_pages(struct gnttab_dma_alloc_args *args); >> +int gnttab_dma_free_pages(struct gnttab_dma_alloc_args *args); >> +#endif >> + >> int gnttab_pages_set_private(int nr_pages, struct page **pages); >> void gnttab_pages_clear_private(int nr_pages, struct page **pages); >> [1] https://elixir.bootlin.com/linux/v4.17-rc7/source/drivers/xen/balloon.c#L485 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksandr Andrushchenko Subject: Re: [PATCH 3/8] xen/grant-table: Allow allocating buffers suitable for DMA Date: Wed, 30 May 2018 09:34:44 +0300 Message-ID: References: <20180525153331.31188-1-andr2000@gmail.com> <20180525153331.31188-4-andr2000@gmail.com> <94de6bd7-405c-c43f-0468-be71efff7552@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf0-x241.google.com (mail-lf0-x241.google.com [IPv6:2a00:1450:4010:c07::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id E22BB72C4E for ; Wed, 30 May 2018 06:34:47 +0000 (UTC) Received: by mail-lf0-x241.google.com with SMTP id z142-v6so2469803lff.5 for ; Tue, 29 May 2018 23:34:47 -0700 (PDT) In-Reply-To: <94de6bd7-405c-c43f-0468-be71efff7552@oracle.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Ostrovsky , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, jgross@suse.com, konrad.wilk@oracle.com Cc: daniel.vetter@intel.com, dongwon.kim@intel.com, Oleksandr Andrushchenko List-Id: dri-devel@lists.freedesktop.org T24gMDUvMjkvMjAxOCAxMDoxMCBQTSwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOgo+IE9uIDA1LzI1 LzIwMTggMTE6MzMgQU0sIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOgo+PiBGcm9tOiBP bGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+ Cj4+Cj4+IEV4dGVuZCBncmFudCB0YWJsZSBtb2R1bGUgQVBJIHRvIGFsbG93IGFsbG9jYXRpbmcg YnVmZmVycyB0aGF0IGNhbgo+PiBiZSB1c2VkIGZvciBETUEgb3BlcmF0aW9ucyBhbmQgbWFwcGlu ZyBmb3JlaWduIGdyYW50IHJlZmVyZW5jZXMKPj4gb24gdG9wIG9mIHRob3NlLgo+PiBUaGUgcmVz dWx0aW5nIGJ1ZmZlciBpcyBzaW1pbGFyIHRvIHRoZSBvbmUgYWxsb2NhdGVkIGJ5IHRoZSBiYWxs b29uCj4+IGRyaXZlciBpbiB0ZXJtcyB0aGF0IHByb3BlciBtZW1vcnkgcmVzZXJ2YXRpb24gaXMg bWFkZQo+PiAoe2luY3JlYXNlfGRlY3JlYXNlfV9yZXNlcnZhdGlvbiBhbmQgVkEgbWFwcGluZ3Mg dXBkYXRlZCBpZiBuZWVkZWQpLgo+PiBUaGlzIGlzIHVzZWZ1bCBmb3Igc2hhcmluZyBmb3JlaWdu IGJ1ZmZlcnMgd2l0aCBIVyBkcml2ZXJzIHdoaWNoCj4+IGNhbm5vdCB3b3JrIHdpdGggc2NhdHRl cmVkIGJ1ZmZlcnMgcHJvdmlkZWQgYnkgdGhlIGJhbGxvb24gZHJpdmVyLAo+PiBidXQgcmVxdWly ZSBETUFhYmxlIG1lbW9yeSBpbnN0ZWFkLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIg QW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+Cj4+IC0tLQo+ PiAgIGRyaXZlcnMveGVuL0tjb25maWcgICAgICAgfCAgMTMgKysrKwo+PiAgIGRyaXZlcnMveGVu L2dyYW50LXRhYmxlLmMgfCAxMjQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKPj4gICBpbmNsdWRlL3hlbi9ncmFudF90YWJsZS5oIHwgIDI1ICsrKysrKysrCj4+ICAgMyBm aWxlcyBjaGFuZ2VkLCAxNjIgaW5zZXJ0aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy94ZW4vS2NvbmZpZyBiL2RyaXZlcnMveGVuL0tjb25maWcKPj4gaW5kZXggZTVkMGMyODM3MmVh Li4zNDMxZmUyMTA2MjQgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMveGVuL0tjb25maWcKPj4gKysr IGIvZHJpdmVycy94ZW4vS2NvbmZpZwo+PiBAQCAtMTYxLDYgKzE2MSwxOSBAQCBjb25maWcgWEVO X0dSQU5UX0RFVl9BTExPQwo+PiAgIAkgIHRvIG90aGVyIGRvbWFpbnMuIFRoaXMgY2FuIGJlIHVz ZWQgdG8gaW1wbGVtZW50IGZyb250ZW5kIGRyaXZlcnMKPj4gICAJICBvciBhcyBwYXJ0IG9mIGFu IGludGVyLWRvbWFpbiBzaGFyZWQgbWVtb3J5IGNoYW5uZWwuCj4+ICAgCj4+ICtjb25maWcgWEVO X0dSQU5UX0RNQV9BTExPQwo+PiArCWJvb2wgIkFsbG93IGFsbG9jYXRpbmcgRE1BIGNhcGFibGUg YnVmZmVycyB3aXRoIGdyYW50IHJlZmVyZW5jZSBtb2R1bGUiCj4+ICsJZGVwZW5kcyBvbiBYRU4K Pgo+IFNob3VsZCBpdCBkZXBlbmQgb24gYW55dGhpbmcgZnJvbSBETUE/IENPTkZJR19IQVNfRE1B IGZvciBleGFtcGxlPwpZZXMsIGl0IG11c3QgYmUgImRlcGVuZHMgb24gWEVOICYmIEhBU19ETUEi LAp0aGFuayB5b3UKPgo+PiArCWhlbHAKPj4gKwkgIEV4dGVuZHMgZ3JhbnQgdGFibGUgbW9kdWxl IEFQSSB0byBhbGxvdyBhbGxvY2F0aW5nIERNQSBjYXBhYmxlCj4+ICsJICBidWZmZXJzIGFuZCBt YXBwaW5nIGZvcmVpZ24gZ3JhbnQgcmVmZXJlbmNlcyBvbiB0b3Agb2YgaXQuCj4+ICsJICBUaGUg cmVzdWx0aW5nIGJ1ZmZlciBpcyBzaW1pbGFyIHRvIG9uZSBhbGxvY2F0ZWQgYnkgdGhlIGJhbGxv b24KPj4gKwkgIGRyaXZlciBpbiB0ZXJtcyB0aGF0IHByb3BlciBtZW1vcnkgcmVzZXJ2YXRpb24g aXMgbWFkZQo+PiArCSAgKHtpbmNyZWFzZXxkZWNyZWFzZX1fcmVzZXJ2YXRpb24gYW5kIFZBIG1h cHBpbmdzIHVwZGF0ZWQgaWYgbmVlZGVkKS4KPj4gKwkgIFRoaXMgaXMgdXNlZnVsIGZvciBzaGFy aW5nIGZvcmVpZ24gYnVmZmVycyB3aXRoIEhXIGRyaXZlcnMgd2hpY2gKPj4gKwkgIGNhbm5vdCB3 b3JrIHdpdGggc2NhdHRlcmVkIGJ1ZmZlcnMgcHJvdmlkZWQgYnkgdGhlIGJhbGxvb24gZHJpdmVy LAo+PiArCSAgYnV0IHJlcXVpcmUgRE1BYWJsZSBtZW1vcnkgaW5zdGVhZC4KPj4gKwo+PiAgIGNv bmZpZyBTV0lPVExCX1hFTgo+PiAgIAlkZWZfYm9vbCB5Cj4+ICAgCXNlbGVjdCBTV0lPVExCCj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ncmFudC10YWJsZS5jIGIvZHJpdmVycy94ZW4vZ3Jh bnQtdGFibGUuYwo+PiBpbmRleCBkNzQ4ODIyNmUxZjIuLjA2ZmU2ZTdmNjM5YyAxMDA2NDQKPj4g LS0tIGEvZHJpdmVycy94ZW4vZ3JhbnQtdGFibGUuYwo+PiArKysgYi9kcml2ZXJzL3hlbi9ncmFu dC10YWJsZS5jCj4+IEBAIC00NSw2ICs0NSw5IEBACj4+ICAgI2luY2x1ZGUgPGxpbnV4L3dvcmtx dWV1ZS5oPgo+PiAgICNpbmNsdWRlIDxsaW51eC9yYXRlbGltaXQuaD4KPj4gICAjaW5jbHVkZSA8 bGludXgvbW9kdWxlcGFyYW0uaD4KPj4gKyNpZmRlZiBDT05GSUdfWEVOX0dSQU5UX0RNQV9BTExP Qwo+PiArI2luY2x1ZGUgPGxpbnV4L2RtYS1tYXBwaW5nLmg+Cj4+ICsjZW5kaWYKPj4gICAKPj4g ICAjaW5jbHVkZSA8eGVuL3hlbi5oPgo+PiAgICNpbmNsdWRlIDx4ZW4vaW50ZXJmYWNlL3hlbi5o Pgo+PiBAQCAtNTcsNiArNjAsNyBAQAo+PiAgICNpZmRlZiBDT05GSUdfWDg2Cj4+ICAgI2luY2x1 ZGUgPGFzbS94ZW4vY3B1aWQuaD4KPj4gICAjZW5kaWYKPj4gKyNpbmNsdWRlIDx4ZW4vbWVtX3Jl c2VydmF0aW9uLmg+Cj4+ICAgI2luY2x1ZGUgPGFzbS94ZW4vaHlwZXJjYWxsLmg+Cj4+ICAgI2lu Y2x1ZGUgPGFzbS94ZW4vaW50ZXJmYWNlLmg+Cj4+ICAgCj4+IEBAIC04MTEsNiArODE1LDgyIEBA IGludCBnbnR0YWJfYWxsb2NfcGFnZXMoaW50IG5yX3BhZ2VzLCBzdHJ1Y3QgcGFnZSAqKnBhZ2Vz KQo+PiAgIH0KPj4gICBFWFBPUlRfU1lNQk9MKGdudHRhYl9hbGxvY19wYWdlcyk7Cj4+ICAgCj4+ ICsjaWZkZWYgQ09ORklHX1hFTl9HUkFOVF9ETUFfQUxMT0MKPj4gKy8qKgo+PiArICogZ250dGFi X2RtYV9hbGxvY19wYWdlcyAtIGFsbG9jIERNQWFibGUgcGFnZXMgc3VpdGFibGUgZm9yIGdyYW50 IG1hcHBpbmcgaW50bwo+PiArICogQGFyZ3M6IGFyZ3VtZW50cyB0byB0aGUgZnVuY3Rpb24KPj4g KyAqLwo+PiAraW50IGdudHRhYl9kbWFfYWxsb2NfcGFnZXMoc3RydWN0IGdudHRhYl9kbWFfYWxs b2NfYXJncyAqYXJncykKPj4gK3sKPj4gKwl1bnNpZ25lZCBsb25nIHBmbiwgc3RhcnRfcGZuOwo+ PiArCXhlbl9wZm5fdCAqZnJhbWVzOwo+PiArCXNpemVfdCBzaXplOwo+PiArCWludCBpLCByZXQ7 Cj4+ICsKPj4gKwlmcmFtZXMgPSBrY2FsbG9jKGFyZ3MtPm5yX3BhZ2VzLCBzaXplb2YoKmZyYW1l cyksIEdGUF9LRVJORUwpOwo+PiArCWlmICghZnJhbWVzKQo+PiArCQlyZXR1cm4gLUVOT01FTTsK Pj4gKwo+PiArCXNpemUgPSBhcmdzLT5ucl9wYWdlcyA8PCBQQUdFX1NISUZUOwo+PiArCWlmIChh cmdzLT5jb2hlcmVudCkKPj4gKwkJYXJncy0+dmFkZHIgPSBkbWFfYWxsb2NfY29oZXJlbnQoYXJn cy0+ZGV2LCBzaXplLAo+PiArCQkJCQkJICZhcmdzLT5kZXZfYnVzX2FkZHIsCj4+ICsJCQkJCQkg R0ZQX0tFUk5FTCB8IF9fR0ZQX05PV0FSTik7Cj4+ICsJZWxzZQo+PiArCQlhcmdzLT52YWRkciA9 IGRtYV9hbGxvY193YyhhcmdzLT5kZXYsIHNpemUsCj4+ICsJCQkJCSAgICZhcmdzLT5kZXZfYnVz X2FkZHIsCj4+ICsJCQkJCSAgIEdGUF9LRVJORUwgfCBfX0dGUF9OT1dBUk4pOwo+PiArCWlmICgh YXJncy0+dmFkZHIpIHsKPj4gKwkJcHJfZXJyKCJGYWlsZWQgdG8gYWxsb2NhdGUgRE1BIGJ1ZmZl ciBvZiBzaXplICV6dVxuIiwgc2l6ZSk7Cj4+ICsJCXJldCA9IC1FTk9NRU07Cj4+ICsJCWdvdG8g ZmFpbF9mcmVlX2ZyYW1lczsKPj4gKwl9Cj4+ICsKPj4gKwlzdGFydF9wZm4gPSBfX3BoeXNfdG9f cGZuKGFyZ3MtPmRldl9idXNfYWRkcik7Cj4+ICsJZm9yIChwZm4gPSBzdGFydF9wZm4sIGkgPSAw OyBwZm4gPCBzdGFydF9wZm4gKyBhcmdzLT5ucl9wYWdlczsKPj4gKwkJCXBmbisrLCBpKyspIHsK Pj4gKwkJc3RydWN0IHBhZ2UgKnBhZ2UgPSBwZm5fdG9fcGFnZShwZm4pOwo+PiArCj4+ICsJCWFy Z3MtPnBhZ2VzW2ldID0gcGFnZTsKPj4gKwkJZnJhbWVzW2ldID0geGVuX3BhZ2VfdG9fZ2ZuKHBh Z2UpOwo+PiArCQl4ZW5tZW1fcmVzZXJ2YXRpb25fc2NydWJfcGFnZShwYWdlKTsKPj4gKwl9Cj4+ ICsKPj4gKwl4ZW5tZW1fcmVzZXJ2YXRpb25fdmFfbWFwcGluZ19yZXNldChhcmdzLT5ucl9wYWdl cywgYXJncy0+cGFnZXMpOwo+PiArCj4+ICsJcmV0ID0geGVubWVtX3Jlc2VydmF0aW9uX2RlY3Jl YXNlKGFyZ3MtPm5yX3BhZ2VzLCBmcmFtZXMpOwo+PiArCWlmIChyZXQgIT0gYXJncy0+bnJfcGFn ZXMpIHsKPj4gKwkJcHJfZXJyKCJGYWlsZWQgdG8gZGVjcmVhc2UgcmVzZXJ2YXRpb24gZm9yIERN QSBidWZmZXJcbiIpOwo+PiArCQl4ZW5tZW1fcmVzZXJ2YXRpb25faW5jcmVhc2UocmV0LCBmcmFt ZXMpOwo+PiArCQlyZXQgPSAtRUZBVUxUOwo+PiArCQlnb3RvIGZhaWxfZnJlZV9kbWE7Cj4+ICsJ fQo+PiArCj4+ICsJcmV0ID0gZ250dGFiX3BhZ2VzX3NldF9wcml2YXRlKGFyZ3MtPm5yX3BhZ2Vz LCBhcmdzLT5wYWdlcyk7Cj4+ICsJaWYgKHJldCA8IDApCj4+ICsJCWdvdG8gZmFpbF9jbGVhcl9w cml2YXRlOwo+PiArCj4+ICsJa2ZyZWUoZnJhbWVzKTsKPj4gKwlyZXR1cm4gMDsKPj4gKwo+PiAr ZmFpbF9jbGVhcl9wcml2YXRlOgo+PiArCWdudHRhYl9wYWdlc19jbGVhcl9wcml2YXRlKGFyZ3Mt Pm5yX3BhZ2VzLCBhcmdzLT5wYWdlcyk7Cj4+ICtmYWlsX2ZyZWVfZG1hOgo+Cj4gRG8geW91IG5l ZWQgdG8geGVubWVtX3Jlc2VydmF0aW9uX2luY3JlYXNlKCk/ClllcywgbWlzc2VkIHRoYXQgb24g ZmFpbF9jbGVhcl9wcml2YXRlIGVycm9yIHBhdGgsIHdpbGwgZml4Cj4KPj4gKwl4ZW5tZW1fcmVz ZXJ2YXRpb25fdmFfbWFwcGluZ191cGRhdGUoYXJncy0+bnJfcGFnZXMsIGFyZ3MtPnBhZ2VzLAo+ PiArCQkJCQkgICAgIGZyYW1lcyk7Cj4+ICsJaWYgKGFyZ3MtPmNvaGVyZW50KQo+PiArCQlkbWFf ZnJlZV9jb2hlcmVudChhcmdzLT5kZXYsIHNpemUsCj4+ICsJCQkJICBhcmdzLT52YWRkciwgYXJn cy0+ZGV2X2J1c19hZGRyKTsKPj4gKwllbHNlCj4+ICsJCWRtYV9mcmVlX3djKGFyZ3MtPmRldiwg c2l6ZSwKPj4gKwkJCSAgICBhcmdzLT52YWRkciwgYXJncy0+ZGV2X2J1c19hZGRyKTsKPj4gK2Zh aWxfZnJlZV9mcmFtZXM6Cj4+ICsJa2ZyZWUoZnJhbWVzKTsKPj4gKwlyZXR1cm4gcmV0Owo+PiAr fQo+PiArRVhQT1JUX1NZTUJPTChnbnR0YWJfZG1hX2FsbG9jX3BhZ2VzKTsKPj4gKyNlbmRpZgo+ PiArCj4+ICAgdm9pZCBnbnR0YWJfcGFnZXNfY2xlYXJfcHJpdmF0ZShpbnQgbnJfcGFnZXMsIHN0 cnVjdCBwYWdlICoqcGFnZXMpCj4+ICAgewo+PiAgIAlpbnQgaTsKPj4gQEAgLTgzOCw2ICs5MTgs NTAgQEAgdm9pZCBnbnR0YWJfZnJlZV9wYWdlcyhpbnQgbnJfcGFnZXMsIHN0cnVjdCBwYWdlICoq cGFnZXMpCj4+ICAgfQo+PiAgIEVYUE9SVF9TWU1CT0woZ250dGFiX2ZyZWVfcGFnZXMpOwo+PiAg IAo+PiArI2lmZGVmIENPTkZJR19YRU5fR1JBTlRfRE1BX0FMTE9DCj4+ICsvKioKPj4gKyAqIGdu dHRhYl9kbWFfZnJlZV9wYWdlcyAtIGZyZWUgRE1BYWJsZSBwYWdlcwo+PiArICogQGFyZ3M6IGFy Z3VtZW50cyB0byB0aGUgZnVuY3Rpb24KPj4gKyAqLwo+PiAraW50IGdudHRhYl9kbWFfZnJlZV9w YWdlcyhzdHJ1Y3QgZ250dGFiX2RtYV9hbGxvY19hcmdzICphcmdzKQo+PiArewo+PiArCXhlbl9w Zm5fdCAqZnJhbWVzOwo+PiArCXNpemVfdCBzaXplOwo+PiArCWludCBpLCByZXQ7Cj4+ICsKPj4g KwlnbnR0YWJfcGFnZXNfY2xlYXJfcHJpdmF0ZShhcmdzLT5ucl9wYWdlcywgYXJncy0+cGFnZXMp Owo+PiArCj4+ICsJZnJhbWVzID0ga2NhbGxvYyhhcmdzLT5ucl9wYWdlcywgc2l6ZW9mKCpmcmFt ZXMpLCBHRlBfS0VSTkVMKTsKPgo+IEFueSB3YXkgeW91IGNhbiBkbyBpdCB3aXRob3V0IGFsbG9j YXRpbmcgbWVtb3J5PyBPbmUgcG9zc2liaWxpdHkgaXMgdG8KPiBrZWVwIGFsbG9jYXRlZCBmcmFt ZXMgZnJvbSBnbnR0YWJfZG1hX2FsbG9jX3BhZ2VzKCkuIChOb3Qgc3VyZSBJIGxpa2UKPiB0aGF0 IGVpdGhlciBidXQgaXQncyB0aGUgb25seSB0aGluZyBJIGNhbiB0aGluayBvZikuClllcywgSSB3 YXMgYWxzbyB0aGlua2luZyBhYm91dCBzdG9yaW5nIHRoZSBhbGxvY2F0ZWQgZnJhbWVzIGFycmF5 IGZyb20KZ250dGFiX2RtYV9hbGxvY19wYWdlcygpLCBidXQgdGhhdCBzZWVtZWQgbm90IHRvIGJl IGNsZWFyIGVub3VnaCBhcwp0aGUgY2FsbGVyIG9mIHRoZSBnbnR0YWJfZG1hX2FsbG9jX3BhZ2Vz IHdpbGwgbmVlZCB0byBzdG9yZSB0aG9zZSBmcmFtZXMKaW4gc29tZSBjb250ZXh0LCBzbyB3ZSBj YW4gcGFzcyB0aGVtIG9uIGZyZWUuIEJ1dCB0aGUgY2FsbGVyIGRvZXNuJ3QgcmVhbGx5Cm5lZWQg dGhlIGZyYW1lcyB3aGljaCBtaWdodCBjb25mdXNlLCBzbyBJIGRlY2lkZWQgdG8gbWFrZSB0aG9z ZSBhbGxvY2F0aW9ucwpvbiB0aGUgZmx5LgpCdXQgSSBjYW4gc3RpbGwgcmV3b3JrIHRoYXQgdG8g c3RvcmUgdGhlIGZyYW1lcyBpZiB5b3UgaW5zaXN0OiBwbGVhc2UgCmxldCBtZSBrbm93Lgo+Cj4K Pj4gKwlpZiAoIWZyYW1lcykKPj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4+ICsKPj4gKwlmb3IgKGkg PSAwOyBpIDwgYXJncy0+bnJfcGFnZXM7IGkrKykKPj4gKwkJZnJhbWVzW2ldID0gcGFnZV90b194 ZW5fcGZuKGFyZ3MtPnBhZ2VzW2ldKTsKPgo+IE5vdCB4ZW5fcGFnZV90b19nZm4oKT8KV2VsbCwg YWNjb3JkaW5nIHRvIFsxXSBpdCBzaG91bGQgYmUgOgogwqDCoMKgIC8qIFhFTk1FTV9wb3B1bGF0 ZV9waHlzbWFwIHJlcXVpcmVzIGEgUEZOIGJhc2VkIG9uIFhlbgogwqDCoMKgwqAgKiBncmFudWxh cml0eS4KIMKgwqDCoMKgICovCiDCoMKgwqAgZnJhbWVfbGlzdFtpXSA9IHBhZ2VfdG9feGVuX3Bm bihwYWdlKTsKCj4KPj4gKwo+PiArCXJldCA9IHhlbm1lbV9yZXNlcnZhdGlvbl9pbmNyZWFzZShh cmdzLT5ucl9wYWdlcywgZnJhbWVzKTsKPj4gKwlpZiAocmV0ICE9IGFyZ3MtPm5yX3BhZ2VzKSB7 Cj4+ICsJCXByX2VycigiRmFpbGVkIHRvIGRlY3JlYXNlIHJlc2VydmF0aW9uIGZvciBETUEgYnVm ZmVyXG4iKTsKPj4gKwkJcmV0ID0gLUVGQVVMVDsKPj4gKwl9IGVsc2Ugewo+PiArCQlyZXQgPSAw Owo+PiArCX0KPj4gKwo+PiArCXhlbm1lbV9yZXNlcnZhdGlvbl92YV9tYXBwaW5nX3VwZGF0ZShh cmdzLT5ucl9wYWdlcywgYXJncy0+cGFnZXMsCj4+ICsJCQkJCSAgICAgZnJhbWVzKTsKPj4gKwo+ PiArCXNpemUgPSBhcmdzLT5ucl9wYWdlcyA8PCBQQUdFX1NISUZUOwo+PiArCWlmIChhcmdzLT5j b2hlcmVudCkKPj4gKwkJZG1hX2ZyZWVfY29oZXJlbnQoYXJncy0+ZGV2LCBzaXplLAo+PiArCQkJ CSAgYXJncy0+dmFkZHIsIGFyZ3MtPmRldl9idXNfYWRkcik7Cj4+ICsJZWxzZQo+PiArCQlkbWFf ZnJlZV93YyhhcmdzLT5kZXYsIHNpemUsCj4+ICsJCQkgICAgYXJncy0+dmFkZHIsIGFyZ3MtPmRl dl9idXNfYWRkcik7Cj4+ICsJa2ZyZWUoZnJhbWVzKTsKPj4gKwlyZXR1cm4gcmV0Owo+PiArfQo+ PiArRVhQT1JUX1NZTUJPTChnbnR0YWJfZG1hX2ZyZWVfcGFnZXMpOwo+PiArI2VuZGlmCj4+ICsK Pj4gICAvKiBIYW5kbGluZyBvZiBwYWdlZCBvdXQgZ3JhbnQgdGFyZ2V0cyAoR05UU1RfZWFnYWlu KSAqLwo+PiAgICNkZWZpbmUgTUFYX0RFTEFZIDI1Ngo+PiAgIHN0YXRpYyBpbmxpbmUgdm9pZAo+ PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS94ZW4vZ3JhbnRfdGFibGUuaCBiL2luY2x1ZGUveGVuL2dy YW50X3RhYmxlLmgKPj4gaW5kZXggZGUwM2YyNTQyYmI3Li45ODJlMzQyNDJiOWMgMTAwNjQ0Cj4+ IC0tLSBhL2luY2x1ZGUveGVuL2dyYW50X3RhYmxlLmgKPj4gKysrIGIvaW5jbHVkZS94ZW4vZ3Jh bnRfdGFibGUuaAo+PiBAQCAtMTk4LDYgKzE5OCwzMSBAQCB2b2lkIGdudHRhYl9mcmVlX2F1dG9f eGxhdF9mcmFtZXModm9pZCk7Cj4+ICAgaW50IGdudHRhYl9hbGxvY19wYWdlcyhpbnQgbnJfcGFn ZXMsIHN0cnVjdCBwYWdlICoqcGFnZXMpOwo+PiAgIHZvaWQgZ250dGFiX2ZyZWVfcGFnZXMoaW50 IG5yX3BhZ2VzLCBzdHJ1Y3QgcGFnZSAqKnBhZ2VzKTsKPj4gICAKPj4gKyNpZmRlZiBDT05GSUdf WEVOX0dSQU5UX0RNQV9BTExPQwo+PiArc3RydWN0IGdudHRhYl9kbWFfYWxsb2NfYXJncyB7Cj4+ ICsJLyogRGV2aWNlIGZvciB3aGljaCBETUEgbWVtb3J5IHdpbGwgYmUvd2FzIGFsbG9jYXRlZC4g Ki8KPj4gKwlzdHJ1Y3QgZGV2aWNlICpkZXY7Cj4+ICsJLyoKPj4gKwkgKiBJZiBzZXQgdGhlbiBE TUEgYnVmZmVyIGlzIGNvaGVyZW50IGFuZCB3cml0ZS1jb21iaW5lIG90aGVyd2lzZS4KPj4gKwkg Ki8KPiBTaW5nbGUtbGluZSBjb21tZW50CndpbGwgZml4Cj4KPj4gKwlib29sIGNvaGVyZW50Owo+ PiArCS8qCj4+ICsJICogTnVtYmVyIG9mIGVudHJpZXMgaW4gdGhlIEBwYWdlcyBhcnJheSwgZGVm aW5lcyB0aGUgc2l6ZQo+PiArCSAqIG9mIHRoZSBETUEgYnVmZmVyLgo+PiArCSAqLwo+IFRoaXMg Y2FuIGJlIG1hZGUgaW50byBzaW5nbGUgbGluZSBjb21tZW50IGFzIHdlbGwuIEhvd2V2ZXIsIEkg YW0gbm90Cj4gc3VyZSB0aGlzIGNvbW1lbnQgYXMgd2VsbCBhcyB0aG9zZSBiZWxvdyBhcmUgbmVj ZXNzYXJ5LiBGaWVsZHMgbmFtZXMgYXJlCj4gc2VsZi1kZXNjcmliaW5nIElNTy4Kd2lsbCByZW1v dmUKPgo+IC1ib3JpcwpUaGFuayB5b3UsCk9sZWtzYW5kcgo+PiArCWludCBucl9wYWdlczsKPj4g KwkvKiBBcnJheSBvZiBwYWdlcyBAcGFnZXMgZmlsbGVkIHdpdGggcGFnZXMgb2YgdGhlIERNQSBi dWZmZXIuICovCj4+ICsJc3RydWN0IHBhZ2UgKipwYWdlczsKPj4gKwkvKiBWaXJ0dWFsL0NQVSBh ZGRyZXNzIG9mIHRoZSBETUEgYnVmZmVyLiAqLwo+PiArCXZvaWQgKnZhZGRyOwo+PiArCS8qIEJ1 cyBhZGRyZXNzIG9mIHRoZSBETUEgYnVmZmVyLiAqLwo+PiArCWRtYV9hZGRyX3QgZGV2X2J1c19h ZGRyOwo+PiArfTsKPj4gKwo+PiAraW50IGdudHRhYl9kbWFfYWxsb2NfcGFnZXMoc3RydWN0IGdu dHRhYl9kbWFfYWxsb2NfYXJncyAqYXJncyk7Cj4+ICtpbnQgZ250dGFiX2RtYV9mcmVlX3BhZ2Vz KHN0cnVjdCBnbnR0YWJfZG1hX2FsbG9jX2FyZ3MgKmFyZ3MpOwo+PiArI2VuZGlmCj4+ICsKPj4g ICBpbnQgZ250dGFiX3BhZ2VzX3NldF9wcml2YXRlKGludCBucl9wYWdlcywgc3RydWN0IHBhZ2Ug KipwYWdlcyk7Cj4+ICAgdm9pZCBnbnR0YWJfcGFnZXNfY2xlYXJfcHJpdmF0ZShpbnQgbnJfcGFn ZXMsIHN0cnVjdCBwYWdlICoqcGFnZXMpOwo+PiAgIApbMV0gCmh0dHBzOi8vZWxpeGlyLmJvb3Rs aW4uY29tL2xpbnV4L3Y0LjE3LXJjNy9zb3VyY2UvZHJpdmVycy94ZW4vYmFsbG9vbi5jI0w0ODUK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==