From mboxrd@z Thu Jan 1 00:00:00 1970 From: Clint Taylor Subject: Re: [PATCH] drm/i915/cnl: Enable wrpll computation for CNL Date: Thu, 8 Jun 2017 16:24:43 -0700 Message-ID: References: <1491506163-14587-35-git-send-email-rodrigo.vivi@intel.com> <1496962980-23876-1-git-send-email-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDE366E339 for ; Thu, 8 Jun 2017 23:24:44 +0000 (UTC) In-Reply-To: <1496962980-23876-1-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org TWF0Y2hlcyBwc2V1ZG8gY29kZSBpbiBCU3BlYy4KClJldmlld2VkLWJ5OiBDbGludCBUYXlsb3Ig PENsaW50b24uQS5UYXlsb3JAaW50ZWwuY29tPgoKCk9uIDA2LzA4LzIwMTcgMDQ6MDMgUE0sIFJv ZHJpZ28gVml2aSB3cm90ZToKPiBGcm9tOiAiS2Fob2xhLCBNaWthIiA8bWlrYS5rYWhvbGFAaW50 ZWwuY29tPgo+Cj4gRW5hYmxlIHdycGxsIGNvbXB1dGF0aW9uIGZvciBDYW5ub25sYWtlIHBsYXRm b3JtIHRvIHN1cHBvcnQKPiBwbGwncyByZXF1aXJlZCBmb3IgSERNSSBvdXRwdXQuIFRoZSBwYXRj aCBjb250YWlucyB0aGUgZm9sbG93aW5nIGZlYXR1cmVzCj4KPiAtIGNvbXB1dGUgQ2Fubm9ubGFr ZSBwb3J0IGNsb2NrIHByb2dyYW1taW5nCj4gICAgZGl2aWRlcnMgUCwgUSwgYW5kIEsuCj4gLSBj b21wdXRlIFBMTCBwYXJhbWV0ZXJzIGZvciBDYW5ub25sYWtlLiBUaGVzZSBwYXJhbWV0ZXJzCj4g ICAgc2V0IHRoZSB2YWx1ZXMgb24gRFBMTCByZWdpc3RlcnMuCj4gLSBmaW5kIHRoZSByZWdpc3Rl ciB2YWx1ZXMgdG8gcHJvZ3JhbSB3cnBsbCBmb3IgQ2Fubm9ubGFrZS4KPiAgICBUaGUgcmVmZXJl bmNlIGNsb2NrIGNhbiBiZSBlaXRoZXIgMTkuMk1IeiBvciAyNE1Iei4KPgo+IHYyOiByZWJhc2UK PiB2Mzogc3F1YXNoIHdycGxsIHBhdGNoZXMgaW50byBvbmUgKFJvZHJpZ28pCj4gdjQ6IHN3aXRj aCBvcmRlciBvZiBnZXR0aW5nIGV2ZW4gZGl2aWRlcnMgKFBhdWxvKQo+ICAgICAgdXBkYXRlIGRp dmlkZXIgcmVnaXN0ZXIgdmFsdWVzIGZvciBQRGl2IGFuZCBLRGl2IChQYXVsbykKPiAgICAgIHVw ZGF0ZSB3cnBsbCBjb21wdXRhdGlvbiBhbGdvcml0aG0gKFBhdWxvKQo+IHY1OiBSZW1vdmUgcmVm IGNsb2NrIGRpdmlzaW9uIGJ5IDEwMDAuIChSb2RyaWdvKQo+IHY2OiBSb2RyaWdvIHJlYmFzaW5n IG9uIHRvcCBvZiBsYXRlc3QgY29kZS4KPgo+IFNpZ25lZC1vZmYtYnk6IEthaG9sYSwgTWlrYSA8 bWlrYS5rYWhvbGFAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9k cmlnby52aXZpQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RwbGxfbWdyLmMgfCAxNDAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ICAg MSBmaWxlIGNoYW5nZWQsIDEzOCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Cj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gaW5kZXggOTAzYzM4ZC4uOGU2NjliNiAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+IEBAIC0yMTI2LDE3ICsy MTI2LDE1MyBAQCBzdGF0aWMgYm9vbCBjbmxfZGRpX3BsbF9nZXRfaHdfc3RhdGUoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4gICAKPiAr c3RhdGljIHZvaWQgY25sX3dycGxsX2dldF9tdWx0aXBsaWVycyh1bnNpZ25lZCBpbnQgYmVzdGRp diwKPiArCQkJCSAgICAgIHVuc2lnbmVkIGludCAqcGRpdiwKPiArCQkJCSAgICAgIHVuc2lnbmVk IGludCAqcWRpdiwKPiArCQkJCSAgICAgIHVuc2lnbmVkIGludCAqa2RpdikKPiArewo+ICsJLyog ZXZlbiBkaXZpZGVycyAqLwo+ICsJaWYgKGJlc3RkaXYgJSAyID09IDApIHsKPiArCQlpZiAoYmVz dGRpdiA9PSAyKSB7Cj4gKwkJCSpwZGl2ID0gMjsKPiArCQkJKnFkaXYgPSAxOwo+ICsJCQkqa2Rp diA9IDE7Cj4gKwkJfSBlbHNlIGlmIChiZXN0ZGl2ICUgNCA9PSAwKSB7Cj4gKwkJCSpwZGl2ID0g MjsKPiArCQkJKnFkaXYgPSBiZXN0ZGl2IC8gNDsKPiArCQkJKmtkaXYgPSAyOwo+ICsJCX0gZWxz ZSBpZiAoYmVzdGRpdiAlIDYgPT0gMCkgewo+ICsJCQkqcGRpdiA9IDM7Cj4gKwkJCSpxZGl2ID0g YmVzdGRpdiAvIDY7Cj4gKwkJCSprZGl2ID0gMjsKPiArCQl9IGVsc2UgaWYgKGJlc3RkaXYgJSA1 ID09IDApIHsKPiArCQkJKnBkaXYgPSA1Owo+ICsJCQkqcWRpdiA9IGJlc3RkaXYgLyAxMDsKPiAr CQkJKmtkaXYgPSAyOwo+ICsJCX0gZWxzZSBpZiAoYmVzdGRpdiAlIDE0ID09IDApIHsKPiArCQkJ KnBkaXYgPSA3Owo+ICsJCQkqcWRpdiA9IGJlc3RkaXYgLyAxNDsKPiArCQkJKmtkaXYgPSAyOwo+ ICsJCX0KPiArCX0gZWxzZSB7Cj4gKwkJaWYgKGJlc3RkaXYgPT0gMyB8fCBiZXN0ZGl2ID09IDUg fHwgYmVzdGRpdiA9PSA3KSB7Cj4gKwkJCSpwZGl2ID0gYmVzdGRpdjsKPiArCQkJKnFkaXYgPSAx Owo+ICsJCQkqa2RpdiA9IDE7Cj4gKwkJfSBlbHNlIHsgLyogOSwgMTUsIDIxICovCj4gKwkJCSpw ZGl2ID0gYmVzdGRpdiAvIDM7Cj4gKwkJCSpxZGl2ID0gMTsKPiArCQkJKmtkaXYgPSAzOwo+ICsJ CX0KPiArCX0KPiArfQo+ICsKPiArc3RhdGljIHZvaWQgY25sX3dycGxsX3BhcmFtc19wb3B1bGF0 ZShzdHJ1Y3Qgc2tsX3dycGxsX3BhcmFtcyAqcGFyYW1zLCB1aW50MzJfdCBkY29fZnJlcSwKPiAr CQkJCSAgICAgIHVpbnQzMl90IHJlZl9mcmVxLCB1aW50MzJfdCBwZGl2LCB1aW50MzJfdCBxZGl2 LAo+ICsJCQkJICAgICAgdWludDMyX3Qga2RpdikKPiArewo+ICsJc3dpdGNoIChrZGl2KSB7Cj4g KwljYXNlIDE6Cj4gKwkJcGFyYW1zLT5rZGl2ID0gMTsKPiArCQlicmVhazsKPiArCWNhc2UgMjoK PiArCQlwYXJhbXMtPmtkaXYgPSAyOwo+ICsJCWJyZWFrOwo+ICsJY2FzZSAzOgo+ICsJCXBhcmFt cy0+a2RpdiA9IDQ7Cj4gKwkJYnJlYWs7Cj4gKwlkZWZhdWx0Ogo+ICsJCVdBUk4oMSwgIkluY29y cmVjdCBLRGl2XG4iKTsKPiArCX0KPiArCj4gKwlzd2l0Y2ggKHBkaXYpIHsKPiArCWNhc2UgMjoK PiArCQlwYXJhbXMtPnBkaXYgPSAxOwo+ICsJCWJyZWFrOwo+ICsJY2FzZSAzOgo+ICsJCXBhcmFt cy0+cGRpdiA9IDI7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIDU6Cj4gKwkJcGFyYW1zLT5wZGl2ID0g NDsKPiArCQlicmVhazsKPiArCWNhc2UgNzoKPiArCQlwYXJhbXMtPnBkaXYgPSA4Owo+ICsJCWJy ZWFrOwo+ICsJZGVmYXVsdDoKPiArCQlXQVJOKDEsICJJbmNvcnJlY3QgUERpdlxuIik7Cj4gKwl9 Cj4gKwo+ICsJaWYgKGtkaXYgIT0gMikKPiArCQlxZGl2ID0gMTsKPiArCj4gKwlwYXJhbXMtPnFk aXZfcmF0aW8gPSBxZGl2Owo+ICsJcGFyYW1zLT5xZGl2X21vZGUgPSAocWRpdiA9PSAxKSA/IDAg OiAxOwo+ICsKPiArCXBhcmFtcy0+ZGNvX2ludGVnZXIgPSBkaXZfdTY0KGRjb19mcmVxLCByZWZf ZnJlcSk7Cj4gKwlwYXJhbXMtPmRjb19mcmFjdGlvbiA9IGRpdl91NjQoKGRpdl91NjQoKHVpbnQ2 NF90KWRjb19mcmVxPDwxNSwgKHVpbnQ2NF90KXJlZl9mcmVxKSAtCj4gKwkJCQkJKCh1aW50NjRf dClwYXJhbXMtPmRjb19pbnRlZ2VyPDwxNSkpICogMHg4MDAwLCAweDgwMDApOwo+ICt9Cj4gKwo+ ICtzdGF0aWMgYm9vbAo+ICtjbmxfZGRpX2NhbGN1bGF0ZV93cnBsbChpbnQgY2xvY2sgLyogaW4g SHogKi8sCj4gKwkJCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiArCQkJc3Ry dWN0IHNrbF93cnBsbF9wYXJhbXMgKndycGxsX3BhcmFtcykKPiArewo+ICsJdWludDY0X3QgYWZl X2Nsb2NrID0gY2xvY2sgKiA1IC8gS0h6KDEpOyAvKiBjbG9ja3MgaW4ga0h6ICovCj4gKwl1bnNp Z25lZCBpbnQgZGNvX21pbiA9IDc5OTggKiBLSHooMSk7Cj4gKwl1bnNpZ25lZCBpbnQgZGNvX21h eCA9IDEwMDAwICogS0h6KDEpOwo+ICsJdW5zaWduZWQgaW50IGRjb19taWQgPSAoZGNvX21pbiAr IGRjb19tYXgpIC8gMjsKPiArCj4gKwlzdGF0aWMgY29uc3QgaW50IGRpdmlkZXJzW10gPSB7ICAy LCAgNCwgIDYsICA4LCAxMCwgMTIsICAxNCwgIDE2LAo+ICsJCQkJCSAxOCwgMjAsIDI0LCAyOCwg MzAsIDMyLCAgMzYsICA0MCwKPiArCQkJCQkgNDIsIDQ0LCA0OCwgNTAsIDUyLCA1NCwgIDU2LCAg NjAsCj4gKwkJCQkJIDY0LCA2NiwgNjgsIDcwLCA3MiwgNzYsICA3OCwgIDgwLAo+ICsJCQkJCSA4 NCwgODgsIDkwLCA5MiwgOTYsIDk4LCAxMDAsIDEwMiwKPiArCQkJCQkgIDMsICA1LCAgNywgIDks IDE1LCAyMSB9Owo+ICsJdW5zaWduZWQgaW50IGQsIGRjbzsKPiArCXVuc2lnbmVkIGludCBkY29f Y2VudHJhbGl0eSA9IDA7Cj4gKwl1bnNpZ25lZCBpbnQgYmVzdF9kY29fY2VudHJhbGl0eSA9IDk5 OTk5OTsKPiArCXVuc2lnbmVkIGludCBiZXN0X2RpdiA9IDA7Cj4gKwl1bnNpZ25lZCBpbnQgYmVz dF9kY28gPSAwOwo+ICsJdW5zaWduZWQgaW50IHBkaXYgPSAwLCBxZGl2ID0gMCwga2RpdiA9IDA7 Cj4gKwo+ICsJZm9yIChkID0gMDsgZCA8IEFSUkFZX1NJWkUoZGl2aWRlcnMpOyBkKyspIHsKPiAr CQlkY28gPSBhZmVfY2xvY2sgKiBkaXZpZGVyc1tkXTsKPiArCj4gKwkJaWYgKChkY28gPD0gZGNv X21heCkgJiYgKGRjbyA+PSBkY29fbWluKSkgewo+ICsJCQlkY29fY2VudHJhbGl0eSA9IGFicyhk Y28gLSBkY29fbWlkKTsKPiArCj4gKwkJCWlmIChkY29fY2VudHJhbGl0eSA8IGJlc3RfZGNvX2Nl bnRyYWxpdHkpIHsKPiArCQkJCWJlc3RfZGNvX2NlbnRyYWxpdHkgPSBkY29fY2VudHJhbGl0eTsK PiArCQkJCWJlc3RfZGl2ID0gZGl2aWRlcnNbZF07Cj4gKwkJCQliZXN0X2RjbyA9IGRjbzsKPiAr CQkJfQo+ICsJCX0KPiArCX0KPiArCj4gKwlpZiAoYmVzdF9kaXYgPT0gMCkKPiArCQlyZXR1cm4g ZmFsc2U7Cj4gKwo+ICsJY25sX3dycGxsX2dldF9tdWx0aXBsaWVycyhiZXN0X2RpdiwgJnBkaXYs ICZxZGl2LCAma2Rpdik7Cj4gKwo+ICsJY25sX3dycGxsX3BhcmFtc19wb3B1bGF0ZSh3cnBsbF9w YXJhbXMsIGJlc3RfZGNvLAo+ICsJCQkJICBkZXZfcHJpdi0+Y2RjbGsuaHcucmVmLCBwZGl2LCBx ZGl2LCBrZGl2KTsKPiArCj4gKwlyZXR1cm4gdHJ1ZTsKPiArfQo+ICsKPiAgIHN0YXRpYyBib29s IGNubF9kZGlfaGRtaV9wbGxfZGl2aWRlcnMoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gICAJ CQkJICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gICAJCQkJICAg ICAgaW50IGNsb2NrKQo+ICAgewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4gICAJdWludDMyX3QgY2ZnY3IwLCBjZmdjcjE7 Cj4gICAJc3RydWN0IHNrbF93cnBsbF9wYXJhbXMgd3JwbGxfcGFyYW1zID0geyAwLCB9Owo+ICAg Cj4gICAJY2ZnY3IwID0gRFBMTF9DRkdDUjBfSERNSV9NT0RFOwo+ICAgCj4gLQkvKiBGSVhNRTog UHJvcGVyIHdycGxsIGNhbGN1bGF0aW9uIGRvbmUgaW4gYSBmb2xsb3dpbmcgcGF0Y2ggKi8KPiAt CXJldHVybiBmYWxzZTsKPiArCWlmICghY25sX2RkaV9jYWxjdWxhdGVfd3JwbGwoY2xvY2sgKiAx MDAwLCBkZXZfcHJpdiwgJndycGxsX3BhcmFtcykpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICAgCj4g ICAJY2ZnY3IwIHw9IERQTExfQ0ZHQ1IwX0RDT19GUkFDVElPTih3cnBsbF9wYXJhbXMuZGNvX2Zy YWN0aW9uKSB8Cj4gICAJCXdycGxsX3BhcmFtcy5kY29faW50ZWdlcjsKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=