From: Jens Axboe <axboe@kernel.dk>
To: Peter Zijlstra <peterz@infradead.org>
Cc: asml.silence@gmail.com, io-uring@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io-wq: Fix io_wq_worker_affinity()
Date: Thu, 8 Apr 2021 13:43:17 -0600 [thread overview]
Message-ID: <c30520c7-6c20-6a32-e9ce-3673285ebc4d@kernel.dk> (raw)
In-Reply-To: <YG7QkiUzlEbW85TU@hirez.programming.kicks-ass.net>
On 4/8/21 3:44 AM, Peter Zijlstra wrote:
>
> Do not include private headers and do not frob in internals.
>
> On top of that, while the previous code restores the affinity, it
> doesn't ensure the task actually moves there if it was running,
> leading to the fun situation that it can be observed running outside
> of its allowed mask for potentially significant time.
>
> Use the proper API instead.
Applied, thanks Peter.
--
Jens Axboe
prev parent reply other threads:[~2021-04-08 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 9:44 [PATCH] io-wq: Fix io_wq_worker_affinity() Peter Zijlstra
2021-04-08 19:43 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c30520c7-6c20-6a32-e9ce-3673285ebc4d@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.