All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
To: aq <aquynh@gmail.com>
Cc: xen-devel <xen-devel@lists.xensource.com>,
	xense-devel@lists.xensource.com
Subject: Re: [PATCH] choose security model for ACM at built-time
Date: Fri, 24 Jun 2005 17:13:04 +0100	[thread overview]
Message-ID: <c3065b97da35bc7f20ae5f58f6dd4d75@cl.cam.ac.uk> (raw)
In-Reply-To: <9cde8bff050624083345768b68@mail.gmail.com>


On 24 Jun 2005, at 16:33, aq wrote:

> At the moment, there is a problem with ACM: it is impossible to set
> ACM security model at built-time, so even with ACM is chosen to build,
> the default policy is NULL, which is useless.
>
> This patch propose a solution to this problem: build process will
> generate a header file (include/public/acm_policy.h) based on the
> value set in xen/Makefile or at command-line, and gets acm.h included
> it.

Looks fine, but:

Firstly, is the configured policy something that needs to be propagated 
to user tools (i.e., should the generated header reside within 
include/public or should it be in include/xen)?

Secondly, you missed conditional inclusion of acm/acm.o into the 
ALL_OBJS list in xen/Rules.mk. Also, the definition of 
ACM_USE_SECURITY_POLICY probably belongs more correctly in Rules.mk 
rather than the Makefile.

  -- Keir

  reply	other threads:[~2005-06-24 16:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-24 15:33 [PATCH] choose security model for ACM at built-time aq
2005-06-24 16:13 ` Keir Fraser [this message]
2005-06-24 23:25   ` aq

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3065b97da35bc7f20ae5f58f6dd4d75@cl.cam.ac.uk \
    --to=keir.fraser@cl.cam.ac.uk \
    --cc=aquynh@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xense-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.