From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54C86C433F5 for ; Wed, 23 Mar 2022 21:16:12 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BD17E83FB7; Wed, 23 Mar 2022 22:16:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1648070171; bh=bQipcJuDhE6XzeHeYxLgYmnBGXmQusJMrw3k869xWS0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LfCbEiaJn7ljyHkosBaX8jAGJ+WkXRtFav3BHwsN+Nk36p3cHftc/D2JcD8sKFwxP E5DVklyLATDKjKdnf7c7d9+Un9xj9qr7uPYzKc/VE9PWiXMmvBa92uOj8TK9e5xHro jeF8/zCtX+FLY3Ux73uY4rRWK71D4T40kaDduQSiA9pHuVcjRfRJZ7uVmrTsiA42ID a+c0r3y5Si2RISa9l8x2ssg1XSSU2M+4fQur+1hWREsJXLTWGPdAPJXcJjajR6T7wa jhiqKPReZzLFQlnWRusjWuHAi8n0yRWuN8L7VnN9/Hq2j/9e16JXKaxbmn/SgEuhqa rRSwRXtedcwsg== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D855383BA1; Wed, 23 Mar 2022 22:16:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1648070168; bh=bQipcJuDhE6XzeHeYxLgYmnBGXmQusJMrw3k869xWS0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=syJ2cVsjMSibjwy7RdI97ame5qpmFf+zulUr9n0qDJP6n1ohwxg3QWIFBoT1fqjl9 vssD9dyBx5WvkgnZRgMjfGMiVfoPdNViOccjH1O28go1M0buP2dOcuMGdaiPl1dzFc 9wSeKRG8sinQ3YCuUalaiFEDpxVwlO/3PQTzj8X1mb0Ytw37J54uku5XKSBhk4/h5n Gu63+BjInbr2MblHgs+hafuN8A99oGCQopMEDpaP9zA59IFzbnqxhrz7PAwWwfTcZM Ooak/WJHE1BVRUM1v5rrqIIu/MU5b/OCCzGIkIZj/Dp8tOwQJLQiYo8I2z8YcYxJy3 /CMSWDzSmguxw== Message-ID: Date: Wed, 23 Mar 2022 22:16:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [EXT] [PATCH] ARM: imx: romapi: Repair FlexSPI NOR boot offset Content-Language: en-US To: Ye Li , "u-boot@lists.denx.de" Cc: Peng Fan , "festevam@denx.de" , "sbabic@denx.de" References: <20220309160945.214591-1-marex@denx.de> <1647832589.20403.9.camel@nxp.com> <1eb56ad6-0158-5600-0ef9-6970316e96e7@denx.de> <1648002489.7912.21.camel@nxp.com> From: Marek Vasut In-Reply-To: <1648002489.7912.21.camel@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/23/22 03:42, Ye Li wrote: > Hi Marek, Hi, >>>> diff --git a/arch/arm/mach-imx/spl_imx_romapi.c b/arch/arm/mach- >>>> imx/spl_imx_romapi.c >>>> index d827de375a6..c47f5a6bdb4 100644 >>>> --- a/arch/arm/mach-imx/spl_imx_romapi.c >>>> +++ b/arch/arm/mach-imx/spl_imx_romapi.c >>>> @@ -38,14 +38,8 @@ ulong spl_romapi_raw_seekable_read(u32 offset, >>>> u32 >>>> size, void *buf) >>>> >>>>   ulong __weak spl_romapi_get_uboot_base(u32 image_offset, u32 >>>> rom_bt_dev) >>>>   { >>>> -       u32 offset; >>>> - >>>> -       if (((rom_bt_dev >> 16) & 0xff) >>>> ==  BT_DEV_TYPE_FLEXSPINOR) >>>> -               offset = CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR >>>> * >>>> 512; >>>> -       else >>>> -               offset = image_offset + >>>> CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR * 512 - 0x8000; >>>> - >>>> -       return offset; >>>> +       return image_offset + >>>> +               (CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR * 512 - >>>> 0x8000); >>>>   } >>> The change is problematic to flexspi. >> Yes, I need this change to get boot from flexspi working on i.MX8MP, >> without this change writing flash.bin to flexspi results in >> unbootable >> system. >> > > To support boot from flexspi, please try another two changes. > 1. Modify board/freescale/imx8mp_evk/imximage-8mp-lpddr4.cfg, set >    "BOOT_FROM" to "fspi". (This change is unnecessary on 8MP after > switch to binman) I already use binman and I need to be able to boot from both SD and FlexSPI, with this patch I can do just that. > 2. Update the u-boot.itb offset in imx8mp-u-boot.dtsi, set the offset > to 0x5f000.  The previous offset 0x58000 is for SD, calculated by > 0x60000 - 0x8000 (32KB image offset). > >     uboot: blob-ext@2 { > filename = "u-boot.itb"; > offset = <0x5f000>; > }; But that breaks booting from SD card for me ?