From: Eric Blake <eblake@redhat.com>
To: Pradeep Jagadeesh <pradeepkiruvale@gmail.com>,
greg kurz <groug@kaod.org>
Cc: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,
alberto garcia <berto@igalia.com>,
jani kokkonen <jani.kokkonen@huawei.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 3/4] qmp: refactor duplicate code
Date: Tue, 2 May 2017 17:15:02 -0500 [thread overview]
Message-ID: <c3224a61-cc45-c419-6aff-a3cc43ffed80@redhat.com> (raw)
In-Reply-To: <1493735386-39622-4-git-send-email-pradeep.jagadeesh@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]
On 05/02/2017 09:29 AM, Pradeep Jagadeesh wrote:
> This patchset factor out the duplicate qmp throttle interface code
> that was present in both block and fsdev device files.
Instead of adding the duplicate code in patch 2 then cleaning it out
here, you should refactor this patch to be first (fix existing code in
blockdev.c to make use of the new interfaces), then add the new fsdev
code that uses this code right away.
>
> Signed-off-by: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>
> ---
> blockdev.c | 53 +++----------------------------------
> fsdev/qemu-fsdev-throttle.c | 51 +-----------------------------------
> fsdev/qemu-fsdev.c | 1 -
> hmp.c | 34 ++++++++++++------------
> include/qemu/throttle-options.h | 5 ++++
> util/Makefile.objs | 1 +
> util/throttle-options.c | 58 +++++++++++++++++++++++++++++++++++++++++
> 7 files changed, 85 insertions(+), 118 deletions(-)
> create mode 100644 util/throttle-options.c
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-05-02 22:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 14:29 [Qemu-devel] [PATCH v3 0/4] fsdev: qmp interface for io throttling Pradeep Jagadeesh
2017-05-02 14:29 ` [Qemu-devel] [PATCH v3 1/4] Throttle: Create IOThrottle structure Pradeep Jagadeesh
2017-05-02 21:56 ` Eric Blake
2017-05-03 6:22 ` Greg Kurz
2017-05-03 14:19 ` Pradeep Jagadeesh
2017-05-03 17:10 ` Greg Kurz
2017-05-02 14:29 ` [Qemu-devel] [PATCH v3 2/4] fsdev: QMP interface for throttling Pradeep Jagadeesh
2017-05-02 22:13 ` Eric Blake
2017-05-03 15:40 ` Pradeep Jagadeesh
2017-05-03 16:32 ` Eric Blake
2017-05-04 15:12 ` Pradeep Jagadeesh
2017-05-04 15:19 ` Eric Blake
2017-05-05 11:09 ` Pradeep Jagadeesh
2017-05-02 14:29 ` [Qemu-devel] [PATCH v3 3/4] qmp: refactor duplicate code Pradeep Jagadeesh
2017-05-02 22:15 ` Eric Blake [this message]
2017-05-03 17:21 ` Greg Kurz
2017-05-04 9:44 ` Pradeep Jagadeesh
2017-05-02 14:29 ` [Qemu-devel] [PATCH v3 4/4] throttle: factor out " Pradeep Jagadeesh
2017-05-02 15:03 ` [Qemu-devel] [PATCH v3 0/4] fsdev: qmp interface for io throttling no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3224a61-cc45-c419-6aff-a3cc43ffed80@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=groug@kaod.org \
--cc=jani.kokkonen@huawei.com \
--cc=pradeep.jagadeesh@huawei.com \
--cc=pradeepkiruvale@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.