From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Only report a wakeup if the waiter was truly asleep Date: Mon, 11 Dec 2017 16:10:49 +0000 Message-ID: References: <20171209124710.1606-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3643E6E1CD for ; Mon, 11 Dec 2017 16:10:56 +0000 (UTC) In-Reply-To: <20171209124710.1606-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA5LzEyLzIwMTcgMTI6NDcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJZiB3ZSBhdHRlbXB0 IHRvIHdha2UgdXAgYSB3YWl0ZXIsIHdobyBpcyBjdXJyZW50bHkgY2hlY2tpbmcgdGhlIHNlcW5v Cj4gaXQgd2lsbCBiZSBpbiB0aGUgVEFTS19JTlRFUlJVUFRJQkxFIHN0YXRlIGFuZCB0dHd1IHdp bGwgcmVwb3J0IHN1Y2Nlc3MuCj4gSG93ZXZlciwgaXQgaXMgYWN0dWFsbHkgYXdha2UgYW5kIGZ1 bmN0aW9uaW5nIC0tIHNvIGRlbGF5IHJlcG9ydGluZyB0aGUKPiBhY3R1YWwgd2FrZSB1cCB1bnRp bCBpdCBzbGVlcHMuIFRoaXMgZml4ZXMgc29tZSBzcHVyaW91cyBjbGFpbXMgb2YKPiBtaXNzZWRf YnJlYWRjcnVtYnMgd2hlbiBydW5uaW5nIHVuZGVyIGhlYXZ5IGxvYWQ7IGkuZS4gc3VmZmljaWVu dCBsb2FkIHRvCj4gcHJlZW1wdCBhd2F5IHRoZSBuZXdseSB3b2tlbiB3YWl0ZXIgYmVmb3JlIHRo ZXkgY29tcGxldGUgdGhlaXIgY2hlY2tzLgo+IEhvd2V2ZXIsIGl0IGRvZXMgc28gYXQgdGhlIGNv c3Qgb2YgYSByYXJlIGZhbHNlIG5lZ2F0aXZlOyB3aGVyZSB0aGUKPiB3YWl0ZXIgY2hhbmdlcyBi ZXR3ZWVuIHRoZSBjaGVjayBhbmQgdHR3dSAtLSB0aGUgb25seSB3YXkgdG8gZml4IHRoYXQKPiB3 b3VsZCBiZSB0byBleHRlbmQgdGhlIHJlcG9ydGluZyBmcm9tIHR0d3Ugd2hlcmUgdGhlIGNoZWNr IGNvdWxkIGJlIGRvbmUKPiBhdG9taWNhbGx5Lgo+IAo+IHYyOiBEZWZlbmQgYWdhaW5zdCAhQ09O RklHX1NNUAo+IHYzOiBEb24ndCBmaWx0ZXIgb3V0IGNhbGxzIHRvIHdha2VfdXBfcHJvY2Vzcwo+ IAo+IFRlc3RjYXNlOiBpZ3QvZHJ2X21pc3NlZF9pcnEgIyBzYW5pdHkgY2hlY2sgd2UgZG8gZGV0 ZWN0IG1pc3NlZF9icmVhZGNydW1iKCkKPiBUZXN0Y2FzZTogaWd0L2dlbV9jb25jdXJyZW50X2Js aXQgIyBmb3IgZ2VuZXJhdGluZyBmYWxzZSBwb3NpdGl2ZXMKPiBSZWZlcmVuY2VzOiBodHRwczov L2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDAwMDcKPiBTaWduZWQtb2Zm LWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtv IFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBDYzogSm9vbmFzIExhaHRpbmVu IDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYyB8IDM5ICsrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRj cnVtYnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMKPiBpbmRl eCAyNGM2ZmVmZGQwYjEuLjc2ZTZmOGU3Y2ZkNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfYnJlYWRjcnVtYnMuYwo+IEBAIC0yNyw2ICsyNywxMiBAQAo+ICAgCj4gICAjaW5jbHVk ZSAiaTkxNV9kcnYuaCIKPiAgIAo+ICsjaWZkZWYgQ09ORklHX1NNUAo+ICsjZGVmaW5lIHRhc2tf YXNsZWVwKHRzaykgKCh0c2spLT5zdGF0ZSAmIFRBU0tfTk9STUFMICYmICEodHNrKS0+b25fY3B1 KQo+ICsjZWxzZQo+ICsjZGVmaW5lIHRhc2tfYXNsZWVwKHRzaykgKCh0c2spLT5zdGF0ZSAmIFRB U0tfTk9STUFMKQo+ICsjZW5kaWYKPiArCgpJIGtpbmQgb2YgcmVtZW1iZXIgdGhlIG9uX2NwdSBm cm9tIGJlZm9yZSBhbmQgSSB3YXMgcHJvYmFibHkgY29tcGxhaW5pbmcgCmFib3V0IGl0LiBTaWdo LCBpZiBpdCBoZWxwcyBvay4uCgo+ICAgc3RhdGljIHVuc2lnbmVkIGludCBfX2ludGVsX2JyZWFk Y3J1bWJzX3dha2V1cChzdHJ1Y3QgaW50ZWxfYnJlYWRjcnVtYnMgKmIpCj4gICB7Cj4gICAJc3Ry dWN0IGludGVsX3dhaXQgKndhaXQ7Cj4gQEAgLTM2LDggKzQyLDIwIEBAIHN0YXRpYyB1bnNpZ25l ZCBpbnQgX19pbnRlbF9icmVhZGNydW1ic193YWtldXAoc3RydWN0IGludGVsX2JyZWFkY3J1bWJz ICpiKQo+ICAgCj4gICAJd2FpdCA9IGItPmlycV93YWl0Owo+ICAgCWlmICh3YWl0KSB7Cj4gKwkJ LyoKPiArCQkgKiBOLkIuIFNpbmNlIHRhc2tfYXNsZWVwKCkgYW5kIHR0d3UgYXJlIG5vdCBhdG9t aWMsIHRoZQo+ICsJCSAqIHdhaXRlciBtYXkgYWN0dWFsbHkgZ28gdG8gc2xlZXAgYWZ0ZXIgdGhl IGNoZWNrLCBjYXVzaW5nCj4gKwkJICogdXMgdG8gc3VwcHJlc3MgYSB2YWxpZCB3YWtldXAuIFdl IHByZWZlciB0byByZWR1Y2UgdGhlCj4gKwkJICogbnVtYmVyIG9mIGZhbHNlIHBvc2l0aXZlIG1p c3NlZF9icmVhZGNydW1iKCkgd2FybmluZ3MKPiArCQkgKiBhdCB0aGUgZXhwZW5zZSBvZiBhIGZl dyBmYWxzZSBuZWdhdGl2ZXMsIGFzIGl0IGl0IGVhc3kKPiArCQkgKiB0byB0cmlnZ2VyIGEgZmFs c2UgcG9zaXRpdmUgdW5kZXIgaGVhdnkgbG9hZC4gRW5vdWdoCj4gKwkJICogc2lnbmFsIHNob3Vs ZCByZW1haW4gZnJvbSBnZW51aW5lIG1pc3NlZF9icmVhZGNydW1iKCkKPiArCQkgKiBmb3IgdXMg dG8gZGV0ZWN0IGluIENJLgo+ICsJCSAqLwo+ICsJCWJvb2wgd2FzX2FzbGVlcCA9IHRhc2tfYXNs ZWVwKHdhaXQtPnRzayk7Cj4gKwo+ICAgCQlyZXN1bHQgPSBFTkdJTkVfV0FLRVVQX1dBSVRFUjsK PiAtCQlpZiAod2FrZV91cF9wcm9jZXNzKHdhaXQtPnRzaykpCj4gKwkJaWYgKHdha2VfdXBfcHJv Y2Vzcyh3YWl0LT50c2spICYmIHdhc19hc2xlZXApCj4gICAJCQlyZXN1bHQgfD0gRU5HSU5FX1dB S0VVUF9BU0xFRVA7Cj4gICAJfQo+ICAgCj4gQEAgLTQ3LDEyICs2NSwxNSBAQCBzdGF0aWMgdW5z aWduZWQgaW50IF9faW50ZWxfYnJlYWRjcnVtYnNfd2FrZXVwKHN0cnVjdCBpbnRlbF9icmVhZGNy dW1icyAqYikKPiAgIHVuc2lnbmVkIGludCBpbnRlbF9lbmdpbmVfd2FrZXVwKHN0cnVjdCBpbnRl bF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIHsKPiAgIAlzdHJ1Y3QgaW50ZWxfYnJlYWRjcnVtYnMg KmIgPSAmZW5naW5lLT5icmVhZGNydW1iczsKPiAtCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gLQl1 bnNpZ25lZCBpbnQgcmVzdWx0Owo+ICsJdW5zaWduZWQgaW50IHJlc3VsdCA9IDA7Cj4gICAKPiAt CXNwaW5fbG9ja19pcnFzYXZlKCZiLT5pcnFfbG9jaywgZmxhZ3MpOwo+IC0JcmVzdWx0ID0gX19p bnRlbF9icmVhZGNydW1ic193YWtldXAoYik7Cj4gLQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZi LT5pcnFfbG9jaywgZmxhZ3MpOwo+ICsJaWYgKFJFQURfT05DRShiLT5pcnFfd2FpdCkpIHsKPiAr CQl1bnNpZ25lZCBsb25nIGZsYWdzOwo+ICsKPiArCQlzcGluX2xvY2tfaXJxc2F2ZSgmYi0+aXJx X2xvY2ssIGZsYWdzKTsKPiArCQlyZXN1bHQgPSBfX2ludGVsX2JyZWFkY3J1bWJzX3dha2V1cChi KTsKPiArCQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZiLT5pcnFfbG9jaywgZmxhZ3MpOwo+ICsJ fQoKVGhpcyBodW5rIEknZCBsZWF2ZSBvdXQgZnJvbSB0aGUgZml4LgoKPiAgIAo+ICAgCXJldHVy biByZXN1bHQ7Cj4gICB9Cj4gQEAgLTc3LDggKzk4LDggQEAgc3RhdGljIG5vaW5saW5lIHZvaWQg bWlzc2VkX2JyZWFkY3J1bWIoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCj4g ICBzdGF0aWMgdm9pZCBpbnRlbF9icmVhZGNydW1ic19oYW5nY2hlY2soc3RydWN0IHRpbWVyX2xp c3QgKnQpCj4gICB7Cj4gLQlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUgPSBmcm9tX3Rp bWVyKGVuZ2luZSwgdCwKPiAtCQkJCQkJICAgIGJyZWFkY3J1bWJzLmhhbmdjaGVjayk7Cj4gKwlz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUgPQo+ICsJCWZyb21fdGltZXIoZW5naW5lLCB0 LCBicmVhZGNydW1icy5oYW5nY2hlY2spOwo+ICAgCXN0cnVjdCBpbnRlbF9icmVhZGNydW1icyAq YiA9ICZlbmdpbmUtPmJyZWFkY3J1bWJzOwo+ICAgCj4gICAJaWYgKCFiLT5pcnFfYXJtZWQpCj4g QEAgLTEwNCw3ICsxMjUsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9icmVhZGNydW1ic19oYW5nY2hl Y2soc3RydWN0IHRpbWVyX2xpc3QgKnQpCj4gICAJICovCj4gICAJaWYgKGludGVsX2VuZ2luZV93 YWtldXAoZW5naW5lKSAmIEVOR0lORV9XQUtFVVBfQVNMRUVQKSB7Cj4gICAJCW1pc3NlZF9icmVh ZGNydW1iKGVuZ2luZSk7Cj4gLQkJbW9kX3RpbWVyKCZlbmdpbmUtPmJyZWFkY3J1bWJzLmZha2Vf aXJxLCBqaWZmaWVzICsgMSk7Cj4gKwkJbW9kX3RpbWVyKCZiLT5mYWtlX2lycSwgamlmZmllcyAr IDEpOwo+ICAgCX0gZWxzZSB7Cj4gICAJCW1vZF90aW1lcigmYi0+aGFuZ2NoZWNrLCB3YWl0X3Rp bWVvdXQoKSk7Cj4gICAJfQo+IAoKSSdsbCB0dXJuIGEgYmxpbmQgZXllIHRvIHRoaXMgb25lLiA6 KQoKUmVnYXJkcywKClR2cnRrbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==