[MPTCP] Re: [MPTCP][PATCH v4 mptcp-next 00/13] ADD_ADDR: ports support

[Matthieu Baerts <matthieu.baerts at tessares.net>]

[-- Attachment #1: Type: text/plain, Size: 2096 bytes --]

Hi Geliang,

On 18/11/2020 13:24, Geliang Tang wrote:
> Hi Mat & Matt,
> 
> Mat Martineau <mathew.j.martineau(a)linux.intel.com> 于2020年11月12日周四 上午9:49写道：
> 
>> On Tue, 10 Nov 2020, Geliang Tang wrote:
>>
>>> v4:
>>> - hold msk->pm.lock in mptcp_pm_sport_in_anno_list.
>>> - Merge the patchset 'Squash to "ADD_ADDR: ports support v3"' into v4.
>>
>> Thanks for the fixes in v4. In last week's meeting there was a
>> conversation about this patch series and the best way to handle additional
>> ports. I think it will be good to talk about that some more this week and
>> how to coordinate that with merging the series to the export branch and
>> (later) net-next.
>>
> 
> Hi Mat & Matt,
> 
> I want to split this patchset into two parts.
> 
> Part 1, includes patch 1 to patch 8, is the basic for ADD_ADDR ports
> support. This part is ready for upstreaming. So please apply them into the
> export branch.

Sounds good to me!

Thanks for these patches and the reviews!

I just applied them and add Mat's Reviewed-by tag (I hope I understood 
that correctly!).

- 931436e108bf: mptcp: unify ADD_ADDR and echo suboptions writing
- 67250a067f8f: mptcp: unify ADD_ADDR and ADD_ADDR6 suboptions writing
- 11881df9755f: mptcp: add port support for ADD_ADDR suboption writing
- 883c4aba78f1: mptcp: use adding up size to get ADD_ADDR length
- 5e04f8ac0a3d: mptcp: add the outgoing ADD_ADDR port support
- e58558aaa818: mptcp: send out dedicated packet for ADD_ADDR using port
- 79a30ba7de53: mptcp: add port parameter for mptcp_pm_announce_addr
- 485ad0ee9ca9: mptcp: print out port and ahmac when receiving ADD_ADDR
- Results: 9d1f3055c580..3c06d194dc8b

Tests + export are in progress!

> Part 2, includes patch 9 to patch 13, is for the testcases of ADD_ADDR
> ports support. This part still needs to be improved, like adding the
> listening socket in the kernel space. I'll send out the new iteration of
> part 2 recently.

Thanks for that!

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net