All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] Do not attempt to use the systemwide libfdt
@ 2017-11-03  2:06 Jan Kundrát
  2017-11-06 23:28 ` [U-Boot] " Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Kundrát @ 2017-11-03  2:06 UTC (permalink / raw)
  To: u-boot

U-Boot bundles a patched copy of libfdt, so it's wrong to attempt to
include it <like/this>. This breaks the build for me when I have dtc
fully installed in my host -- as happened earlier tonight with
Buildroot, for example.

There are several other occurrences throughout the code where '<libfdt'
matches. I'm not modifying these because I have no clue why the
<systemwide> include style is being used -- IMHO wrongly.

Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
---
 include/fdt.h    | 2 +-
 include/libfdt.h | 2 +-
 tools/fdtgrep.c  | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/fdt.h b/include/fdt.h
index 7ead62e777..f40b56c755 100644
--- a/include/fdt.h
+++ b/include/fdt.h
@@ -1 +1 @@
-#include <../lib/libfdt/fdt.h>
+#include "../lib/libfdt/fdt.h"
diff --git a/include/libfdt.h b/include/libfdt.h
index 10296a21ad..7ba13e634b 100644
--- a/include/libfdt.h
+++ b/include/libfdt.h
@@ -1 +1 @@
-#include <../lib/libfdt/libfdt.h>
+#include "../lib/libfdt/libfdt.h"
diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c
index f51f5f15f5..5897b6d5f7 100644
--- a/tools/fdtgrep.c
+++ b/tools/fdtgrep.c
@@ -16,8 +16,8 @@
 #include <string.h>
 #include <unistd.h>
 
-#include <../include/libfdt.h>
-#include <libfdt_internal.h>
+#include "../include/libfdt.h"
+#include "libfdt_internal.h"
 
 /* Define DEBUG to get some debugging output on stderr */
 #ifdef DEBUG
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] Do not attempt to use the systemwide libfdt
  2017-11-03  2:06 [U-Boot] [PATCH] Do not attempt to use the systemwide libfdt Jan Kundrát
@ 2017-11-06 23:28 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2017-11-06 23:28 UTC (permalink / raw)
  To: u-boot

On Fri, Nov 03, 2017 at 03:06:35AM +0100, Jan Kundrát wrote:

> U-Boot bundles a patched copy of libfdt, so it's wrong to attempt to
> include it <like/this>. This breaks the build for me when I have dtc
> fully installed in my host -- as happened earlier tonight with
> Buildroot, for example.
> 
> There are several other occurrences throughout the code where '<libfdt'
> matches. I'm not modifying these because I have no clue why the
> <systemwide> include style is being used -- IMHO wrongly.
> 
> Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171106/49bc2f42/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-06 23:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03  2:06 [U-Boot] [PATCH] Do not attempt to use the systemwide libfdt Jan Kundrát
2017-11-06 23:28 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.