From: Ferruh Yigit <ferruh.yigit@intel.com>
To: ido goshen <ido@cgstowernetworks.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2 1/2] net/pcap: multiple queues fix
Date: Tue, 26 Jun 2018 12:06:24 +0100 [thread overview]
Message-ID: <c34cc443-b8c9-815e-c246-58d63c543051@intel.com> (raw)
In-Reply-To: <a4b4c2a9-26ea-d8ce-dcf0-05b3fb0ca5eb@intel.com>
On 6/20/2018 7:22 PM, Ferruh Yigit wrote:
> On 6/19/2018 3:37 PM, ido goshen wrote:
>> Fixes: 4c173302c307 ("pcap: add new driver")
>> Cc: stable@dpdk.org
>>
>> Change open_rx/tx_pcap/iface functions to open only a single pcap/dumper
>> and not loop num_of_queue times
>> The num_of_queue loop is already acheived by the caller rte_kvargs_process
>>
>> Fixes:
>> 1. Opens N requested pcaps/dumpers instead of N^2
>> 2. Leak of pcap/dumper's which are being overwritten by
>> the sequential calls to open_rx/tx_pcap/iface functions
>> 3. Use the filename/iface args per queue and not just the last one
>> that overwrites the previous names
>>
>> Signed-off-by: ido goshen <ido@cgstowernetworks.com>
>
> For series,
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Series applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-06-26 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 14:37 [PATCH v2 1/2] net/pcap: multiple queues fix ido goshen
2018-06-19 14:37 ` [PATCH v2 2/2] net/pcap: duplicate code consolidation ido goshen
2018-06-20 17:41 ` Ferruh Yigit
2018-06-20 18:06 ` Ido Goshen
2018-06-20 18:14 ` Ferruh Yigit
2018-06-20 18:22 ` [PATCH v2 1/2] net/pcap: multiple queues fix Ferruh Yigit
2018-06-26 11:06 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c34cc443-b8c9-815e-c246-58d63c543051@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=ido@cgstowernetworks.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.