From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2 net-next] vxlan: fix ttl inherit behavior Date: Thu, 19 Apr 2018 12:15:33 -0600 Message-ID: References: <1524027948-5395-1-git-send-email-liuhangbin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , Jiri Benc To: Hangbin Liu , netdev@vger.kernel.org Return-path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:46089 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753011AbeDSSPl (ORCPT ); Thu, 19 Apr 2018 14:15:41 -0400 Received: by mail-pg0-f68.google.com with SMTP id t12so2871203pgp.13 for ; Thu, 19 Apr 2018 11:15:40 -0700 (PDT) In-Reply-To: <1524027948-5395-1-git-send-email-liuhangbin@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 4/17/18 11:05 PM, Hangbin Liu wrote: > Like kernel net-next commit 72f6d71e491e6 ("vxlan: add ttl inherit support"), > vxlan ttl inherit should means inherit the inner protocol's ttl value. > > But currently when we add vxlan with "ttl inherit", we only set ttl 0, > which is actually use whatever default value instead of inherit the inner > protocol's ttl value. > > To make a difference with ttl inherit and ttl == 0, we add an attribute > IFLA_VXLAN_TTL_INHERIT when "ttl inherit" specified. And use "ttl auto" > to means "use whatever default value", the same behavior with ttl == 0. > > Reported-by: Jianlin Shi > Suggested-by: Jiri Benc > Signed-off-by: Hangbin Liu > --- > include/uapi/linux/if_link.h | 1 + > ip/iplink_vxlan.c | 8 ++++++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > applied to iproute2-next.