From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Peer Adelt" <peer.adelt@hni.uni-paderborn.de>,
"Richard Henderson" <rth@twiddle.net>
Cc: Aleksandar Markovic <amarkovic@wavecomp.com>,
Aurelien Jarno <aurelien@aurel32.net>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 11/11] target/mips: Port MIPS64 DCL[Z/O] to decodetree
Date: Mon, 12 Nov 2018 10:14:56 +0100 [thread overview]
Message-ID: <c34eda41-8c27-6c61-a53f-eae06da63fd9@linaro.org> (raw)
In-Reply-To: <20181111233622.8976-12-f4bug@amsat.org>
On 11/12/18 12:36 AM, Philippe Mathieu-Daudé wrote:
> +dclz 011100 ..... ..... ..... ..... 100100 @rs_rt_rd ?ctx->insn_flags&ISA_MIPS64
> +dclo 011100 ..... ..... ..... ..... 100101 @rs_rt_rd ?ctx->insn_flags&ISA_MIPS64
This syntax I do not like. I preferred your other form,
>isa(ISA_MIPS64)
which, with a change to return false as I suggested, would
have the same effect.
As an aside, you could do
#define check_isa(ctx, which) ((ctx)->insn_flags & ISA_##which)
to reduce the decode markup to
>isa(MIPS64)
r~
next prev parent reply other threads:[~2018-11-12 9:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 23:36 [Qemu-devel] [RFC PATCH 00/11] decodetree: Add tokens to ease checking ISA flags Philippe Mathieu-Daudé
2018-11-11 23:36 ` [Qemu-devel] [RFC PATCH 01/11] MAINTAINERS: Add scripts/decodetree.py to the TCG section Philippe Mathieu-Daudé
2018-11-11 23:36 ` [Qemu-devel] [RFC PATCH 02/11] decodetree: Add multiple include guard Philippe Mathieu-Daudé
2018-11-12 22:30 ` Eduardo Habkost
2018-11-12 23:30 ` Philippe Mathieu-Daudé
2018-11-11 23:36 ` [Qemu-devel] [RFC PATCH 03/11] target/mips: Move the !ISA_MIPS32R6 check out of decode_opc_special2_legacy Philippe Mathieu-Daudé
2018-11-12 8:16 ` Richard Henderson
2018-11-11 23:36 ` [Qemu-devel] [RFC PATCH 04/11] target/mips: Avoid access to CPUMIPSState from decode* functions Philippe Mathieu-Daudé
2018-11-12 8:17 ` Richard Henderson
2018-11-11 23:36 ` [Qemu-devel] [RFC PATCH 05/11] decodetree: Force Python to print unsigned values Philippe Mathieu-Daudé
2018-11-12 8:20 ` Richard Henderson
2018-11-12 8:57 ` Philippe Mathieu-Daudé
2018-11-12 17:03 ` Eduardo Habkost
2018-11-12 18:52 ` Philippe Mathieu-Daudé
2018-11-12 18:56 ` Philippe Mathieu-Daudé
2018-11-12 19:01 ` Richard Henderson
2018-11-12 21:41 ` Eduardo Habkost
2018-11-11 23:36 ` [Qemu-devel] [RFC PATCH 06/11] scripts/decodetree: Allow empty specifications Philippe Mathieu-Daudé
2018-11-12 8:21 ` Richard Henderson
2018-11-11 23:36 ` [Qemu-devel] [RFC PATCH 07/11] scripts/decodetree: Add add_func_check() Philippe Mathieu-Daudé
2018-11-12 8:31 ` Richard Henderson
2018-11-11 23:36 ` [Qemu-devel] [RFC PATCH 08/11] target/mips: Add a decodetree stub Philippe Mathieu-Daudé
2018-11-12 5:37 ` Aleksandar Markovic
2018-11-12 8:58 ` Richard Henderson
2018-11-12 10:04 ` Aleksandar Markovic
2018-11-12 10:55 ` Richard Henderson
2018-11-11 23:36 ` [Qemu-devel] [RFC PATCH 09/11] target/mips: Port SYNCI to decodetree Philippe Mathieu-Daudé
2018-11-11 23:36 ` [Qemu-devel] [RFC PATCH 10/11] scripts/decodetree: Add add_cond_check() Philippe Mathieu-Daudé
2018-11-11 23:36 ` [Qemu-devel] [RFC PATCH 11/11] target/mips: Port MIPS64 DCL[Z/O] to decodetree Philippe Mathieu-Daudé
2018-11-12 9:14 ` Richard Henderson [this message]
2018-11-12 9:17 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c34eda41-8c27-6c61-a53f-eae06da63fd9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=amarkovic@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=kbastian@mail.uni-paderborn.de \
--cc=peer.adelt@hni.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.