All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org, Rob Herring <robh+dt@kernel.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: display: bridge: lvds-codec: Document pixel data sampling edge select
Date: Mon, 18 Oct 2021 21:47:13 +0200	[thread overview]
Message-ID: <c34f8a7e-eec6-9373-0c52-f6546ad689a8@denx.de> (raw)
In-Reply-To: <YW24EbfbtJdMMDRV@pendragon.ideasonboard.com>

On 10/18/21 8:08 PM, Laurent Pinchart wrote:

[...]

>> diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
>> index 1faae3e323a4..708de84ac138 100644
>> --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
>> +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
>> @@ -79,6 +79,14 @@ properties:
>>         - port@0
>>         - port@1
>>   
>> +  pclk-sample:
>> +    description:
>> +      Data sampling on rising or falling edge.
>> +    enum:
>> +      - 0  # Falling edge
>> +      - 1  # Rising edge
>> +    default: 0
>> +
> 
> Shouldn't this be moved to the endpoint, the same way data-mapping is
> defined as an endpoint property ?

The strapping is a chip property, not port property, so no.

  reply	other threads:[~2021-10-18 19:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-17  0:12 [PATCH v5 1/2] dt-bindings: display: bridge: lvds-codec: Document pixel data sampling edge select Marek Vasut
2021-10-17  0:12 ` [PATCH v5 2/2] drm/bridge: lvds-codec: Add support for " Marek Vasut
2021-10-17 16:49   ` Sam Ravnborg
2021-10-17 17:29     ` Marek Vasut
2021-10-17 17:40       ` Sam Ravnborg
2021-10-17 20:05         ` Marek Vasut
2021-10-23 23:04         ` Marek Vasut
2021-11-24  3:02           ` Marek Vasut
2021-11-24  3:02             ` Marek Vasut
2021-12-07 17:30             ` Marek Vasut
2021-12-07 17:30               ` Marek Vasut
2021-10-18 17:54 ` [PATCH v5 1/2] dt-bindings: display: bridge: lvds-codec: Document " Rob Herring
2021-10-18 18:08 ` Laurent Pinchart
2021-10-18 19:47   ` Marek Vasut [this message]
2021-10-18 19:57     ` Laurent Pinchart
2021-10-18 22:18       ` Marek Vasut
2021-10-19  6:49         ` Laurent Pinchart
2021-10-19 14:39           ` Marek Vasut
2021-10-26 23:43             ` Laurent Pinchart
2021-10-27 12:29               ` Marek Vasut
  -- strict thread matches above, loose matches on Subject: below --
2021-06-02 20:36 [PATCH V5 " Marek Vasut
2021-06-02 20:36 ` Marek Vasut
2021-06-02 20:36 ` Marek Vasut
2021-06-10 16:09 ` Rob Herring
2021-06-10 16:09   ` Rob Herring
2021-06-10 16:09   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c34f8a7e-eec6-9373-0c52-f6546ad689a8@denx.de \
    --to=marex@denx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.