All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Fam Zheng <famz@redhat.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 17/17] dirty-bitmap: Convert internal hbitmap size/granularity
Date: Wed, 12 Jul 2017 16:25:14 -0500	[thread overview]
Message-ID: <c37a81d4-d679-4054-ccb4-fe3b35591533@redhat.com> (raw)
In-Reply-To: <bc598e9b-1606-ead3-30a4-d654b39994ed@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

On 07/12/2017 04:00 PM, John Snow wrote:
> 
> 
> On 07/03/2017 11:10 AM, Eric Blake wrote:
>> Now that all callers are using byte-based interfaces, there's no
>> reason for our internal hbitmap to remain with sector-based
>> granularity.  It also simplifies our internal scaling, since we
>> already know that hbitmap widens requests out to granularity
>> boundaries.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>

>> @@ -310,7 +305,6 @@ void bdrv_dirty_bitmap_truncate(BlockDriverState *bs)
>>      int64_t size = bdrv_getlength(bs);
>>
>>      assert(size >= 0);
>> -    size = DIV_ROUND_UP(size, BDRV_SECTOR_SIZE);
> 
> whoops uh, were we setting bitmap->size to the *sector* size prior to
> this, even though we had already changed bitmap->size to be the byte size?

Oops. Looks like I have a bug in my rebasing of 5/17.  Good catch; I'll
have to post v5.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

      reply	other threads:[~2017-07-12 21:25 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03 15:10 [Qemu-devel] [PATCH v4 00/17] make dirty-bitmap byte-based Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 01/17] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 02/17] hbitmap: Rename serialization_granularity to serialization_align Eric Blake
2017-07-06 23:03   ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 03/17] qcow2: Ensure bitmap serialization is aligned Eric Blake
2017-07-06 23:14   ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 04/17] dirty-bitmap: Drop unused functions Eric Blake
2017-07-06 23:43   ` John Snow
2017-07-07  8:44     ` Vladimir Sementsov-Ogievskiy
2017-07-07 13:05       ` Vladimir Sementsov-Ogievskiy
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 05/17] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes Eric Blake
2017-07-10 21:09   ` John Snow
2017-07-10 21:19     ` Eric Blake
2017-07-10 21:20       ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 06/17] dirty-bitmap: Change bdrv_dirty_bitmap_*serialize*() to take bytes Eric Blake
2017-07-10 21:46   ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 07/17] qcow2: Switch sectors_covered_by_bitmap_cluster() to byte-based Eric Blake
2017-07-10 22:54   ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 08/17] dirty-bitmap: Set iterator start by offset, not sector Eric Blake
2017-07-10 23:02   ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 09/17] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset Eric Blake
2017-07-10 23:20   ` John Snow
2017-07-11 16:50   ` Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 10/17] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 11/17] dirty-bitmap: Change bdrv_get_dirty_locked() to take bytes Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 12/17] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes Eric Blake
2017-07-12 19:25   ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 13/17] mirror: Switch mirror_dirty_init() to byte-based iteration Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 14/17] qcow2: Switch load_bitmap_data() " Eric Blake
2017-07-12 20:15   ` John Snow
2017-07-13  9:16   ` Vladimir Sementsov-Ogievskiy
2017-07-13 10:59     ` Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 15/17] qcow2: Switch store_bitmap_data() " Eric Blake
2017-07-12 20:28   ` John Snow
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 16/17] dirty-bitmap: Switch bdrv_set_dirty() to bytes Eric Blake
2017-07-03 15:10 ` [Qemu-devel] [PATCH v4 17/17] dirty-bitmap: Convert internal hbitmap size/granularity Eric Blake
2017-07-12 21:00   ` John Snow
2017-07-12 21:25     ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c37a81d4-d679-4054-ccb4-fe3b35591533@redhat.com \
    --to=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.