All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10 09/16] block/qcow2: Generalize preallocate()
Date: Mon, 20 Mar 2017 16:13:01 +0100	[thread overview]
Message-ID: <c3909a14-2a06-74d9-8238-f1855e070932@redhat.com> (raw)
In-Reply-To: <20170320110404.GJ17887@stefanha-x1.localdomain>

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On 20.03.2017 12:04, Stefan Hajnoczi wrote:
> On Mon, Mar 13, 2017 at 10:40:38PM +0100, Max Reitz wrote:
>> This patch adds two new parameters to the preallocate() function so we
>> will be able to use it not just for preallocating a new image but also
>> for preallocated image growth.
>>
>> The offset parameter allows the caller to specify a virtual offset from
>> which to start preallocating. For newly created images this is always 0,
>> but for preallocating growth this will be the old image length.
>>
>> The new_length parameter specifies the supposed new length of the image
>> (basically the "end offset" for preallocation). During image truncation,
>> bdrv_getlength() will return the old image length so we cannot rely on
>> its return value then.
> 
> You documented the arguments in the commit description.  Please move
> them into doc comments.

Yeah, right, new_length is not really a super self-explaining name...
I'll add a comment.

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

  reply	other threads:[~2017-03-20 15:13 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13 21:39 [Qemu-devel] [PATCH for-2.10 00/16] block: Preallocated truncate Max Reitz
2017-03-13 21:39 ` [Qemu-devel] [PATCH for-2.10 01/16] block: Add PreallocMode to BD.bdrv_truncate() Max Reitz
2017-03-20 10:10   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-20 10:18   ` Stefan Hajnoczi
2017-03-20 15:07     ` Max Reitz
2017-03-22 16:28       ` Stefan Hajnoczi
2017-03-22 16:50         ` Max Reitz
2017-03-23 15:32           ` Stefan Hajnoczi
2017-03-27 14:19             ` Max Reitz
2017-03-13 21:40 ` [Qemu-devel] [PATCH for-2.10 02/16] block: Add PreallocMode to bdrv_truncate() Max Reitz
2017-03-20 11:33   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-13 21:40 ` [Qemu-devel] [PATCH for-2.10 03/16] block: Add PreallocMode to blk_truncate() Max Reitz
2017-03-20 10:33   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-13 21:40 ` [Qemu-devel] [PATCH for-2.10 04/16] qemu-img: Expose PreallocMode for resizing Max Reitz
2017-03-20 10:47   ` Stefan Hajnoczi
2017-03-20 15:07     ` Max Reitz
2017-03-13 21:40 ` [Qemu-devel] [PATCH for-2.10 05/16] block/file-posix: Small fixes in raw_create() Max Reitz
2017-03-20 10:48   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-13 21:40 ` [Qemu-devel] [PATCH for-2.10 06/16] block/file-posix: Extract raw_regular_truncate() Max Reitz
2017-03-20 10:49   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-13 21:40 ` [Qemu-devel] [PATCH for-2.10 07/16] block/file-posix: Generalize raw_regular_truncate Max Reitz
2017-03-20 11:00   ` Stefan Hajnoczi
2017-03-20 15:11     ` Max Reitz
2017-03-22 16:44       ` Stefan Hajnoczi
2017-03-22 16:53         ` Max Reitz
2017-03-23 16:13           ` Stefan Hajnoczi
2017-03-13 21:40 ` [Qemu-devel] [PATCH for-2.10 08/16] block/file-posix: Preallocation for truncate Max Reitz
2017-03-20 11:01   ` Stefan Hajnoczi
2017-03-13 21:40 ` [Qemu-devel] [PATCH for-2.10 09/16] block/qcow2: Generalize preallocate() Max Reitz
2017-03-20 11:04   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-20 15:13     ` Max Reitz [this message]
2017-03-13 21:41 ` [Qemu-devel] [PATCH for-2.10 10/16] block/qcow2: Lock s->lock in preallocate() Max Reitz
2017-03-20 11:05   ` Stefan Hajnoczi
2017-03-13 21:41 ` [Qemu-devel] [PATCH for-2.10 11/16] block/qcow2: Metadata preallocation for truncate Max Reitz
2017-03-20 11:23   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-13 21:41 ` [Qemu-devel] [PATCH for-2.10 12/16] block/qcow2: Extract qcow2_calc_size_usage() Max Reitz
2017-03-20  9:43   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-13 21:41 ` [Qemu-devel] [PATCH for-2.10 13/16] block/qcow2: qcow2_calc_size_usage() for truncate Max Reitz
2017-03-20 11:26   ` Stefan Hajnoczi
2017-03-20 15:14     ` Max Reitz
2017-03-29 22:12       ` Max Reitz
2017-03-13 21:41 ` [Qemu-devel] [PATCH for-2.10 14/16] block/qcow2: falloc/full preallocating growth Max Reitz
2017-03-20 11:29   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-20 15:15     ` Max Reitz
2017-03-22 17:02       ` Stefan Hajnoczi
2017-03-13 21:41 ` [Qemu-devel] [PATCH for-2.10 15/16] iotests: Add preallocated resize test for raw Max Reitz
2017-03-20 11:30   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-13 21:41 ` [Qemu-devel] [PATCH for-2.10 16/16] iotests: Add preallocated growth test for qcow2 Max Reitz
2017-03-20 11:31   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3909a14-2a06-74d9-8238-f1855e070932@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.