From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A2E0C433B4 for ; Mon, 19 Apr 2021 08:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BFE961104 for ; Mon, 19 Apr 2021 08:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238113AbhDSITE (ORCPT ); Mon, 19 Apr 2021 04:19:04 -0400 Received: from foss.arm.com ([217.140.110.172]:37620 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237632AbhDSITC (ORCPT ); Mon, 19 Apr 2021 04:19:02 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 533D61FB; Mon, 19 Apr 2021 01:18:33 -0700 (PDT) Received: from [10.57.57.205] (unknown [10.57.57.205]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E5BEF3F85F; Mon, 19 Apr 2021 01:18:29 -0700 (PDT) Subject: Re: [PATCH v2 0/2] perf cs-etm: Set time on synthesised samples to preserve ordering To: Arnaldo Carvalho de Melo , Mathieu Poirier Cc: coresight@lists.linaro.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, Mike Leach , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210416105632.8771-1-james.clark@arm.com> <20210416150709.GA1046932@xps15> From: James Clark Message-ID: Date: Mon, 19 Apr 2021 11:18:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/04/2021 18:16, Arnaldo Carvalho de Melo wrote: > Em Fri, Apr 16, 2021 at 09:07:09AM -0600, Mathieu Poirier escreveu: >> Hi James, >> >> On Fri, Apr 16, 2021 at 01:56:30PM +0300, James Clark wrote: >>> Changes since v1: >>> * Improved variable name from etm_timestamp -> cs_timestamp >>> * Fixed ordering of Signed-off-by >>> >> >> You forgot to add the RB and AB you received. Since Arnaldo is responsible for >> the perf tools subsystem, please send another revision. > > > > Yep, please collect Reported-by and Acked-by as you go sending new > versions of a patchset, the last one I don't have a problem collecting > myself, but if you have to resend, please collect the feedback tags. > > - Arnaldo > Ok thanks, I will keep that in mind for the future. I wasn't sure if they still applied or not as it was a new version. Thanks James >> Thanks, >> Mathieu >> >>> James Clark (2): >>> perf cs-etm: Refactor timestamp variable names >>> perf cs-etm: Set time on synthesised samples to preserve ordering >>> >>> .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 18 +++---- >>> tools/perf/util/cs-etm.c | 52 ++++++++++--------- >>> tools/perf/util/cs-etm.h | 4 +- >>> 3 files changed, 39 insertions(+), 35 deletions(-) >>> >>> -- >>> 2.28.0 >>> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 427F9C433ED for ; Mon, 19 Apr 2021 08:20:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0429261107 for ; Mon, 19 Apr 2021 08:20:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0429261107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n1Vx7/xyv8m0u48QsdKkFCn0N6znPHVm2IjtsfnfV6A=; b=DjY2Uwt/MJhCGjGCfdwofu4ay SuK124HKm2XCOPMGsXoz/0MW1JNNK7NeMOEiEZ3J4aoRhC09ajuknP2DQC7l16wtlhEgRgZ7c8qF3 xvZlEyHyuGL4bRYg8yS4nv9cn96PCDDmcCzV2ruyp+8facxtlY/C5CrqwVcprwrd3B5oZlJUYWGV2 Yd7s6m8QE3k9JICAdA2nHzow0Pr7SmWcVAKxqiPXK8/wvNLpc/uas81zc/ybOlRW+KngRh0KrWpw/ pLoTKzM/3u+OXYawsgRkWJnAEX/qt3RGr+zNVfJxL2jeZgOxLC7PsxbSHU1yhM3IFk0lphc4qGHPb HbMHQ2Kwg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYP7I-009Pms-Sb; Mon, 19 Apr 2021 08:18:49 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYP7H-009PmW-1n for linux-arm-kernel@desiato.infradead.org; Mon, 19 Apr 2021 08:18:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=NxpPhV3UZcCuGdis6JgLvtP2O3i4zC4D2fZBrOfjip4=; b=I1/o8XWiweJ/MbKWJA/M7KOQkd ukr1WWF3AHe/Y5eJ0q7ePhgD7UZB948DdG/RxGjRpnTE/DF/TCi8/I78f1s9JDB0fScrQPvldctWx THGNSfhRtugU3OhQpILEDqYor0hYNpmrBKav9FWre1TTUuc6CfLeXXSid1fO+JXmqRx2aGpNJEdmn rf1f41xZeE4+cVrkXTpCgXLX4uvbyp6QWKbudqH9+BoK0PMDknCUAXS8uzA88F6YgoeWSEiuOmYKf aqoA5+egGC/WtgxYxZJ9wc30FsOxV0RT+UQytMmiApl1SpTcwaBsrl9Pv0jBqJ/WPGxqESJEFIpwn JEu/U/FQ==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYP7A-00BB81-2N for linux-arm-kernel@lists.infradead.org; Mon, 19 Apr 2021 08:18:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 533D61FB; Mon, 19 Apr 2021 01:18:33 -0700 (PDT) Received: from [10.57.57.205] (unknown [10.57.57.205]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E5BEF3F85F; Mon, 19 Apr 2021 01:18:29 -0700 (PDT) Subject: Re: [PATCH v2 0/2] perf cs-etm: Set time on synthesised samples to preserve ordering To: Arnaldo Carvalho de Melo , Mathieu Poirier Cc: coresight@lists.linaro.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, Mike Leach , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210416105632.8771-1-james.clark@arm.com> <20210416150709.GA1046932@xps15> From: James Clark Message-ID: Date: Mon, 19 Apr 2021 11:18:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210419_011840_187129_CC70B54C X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/04/2021 18:16, Arnaldo Carvalho de Melo wrote: > Em Fri, Apr 16, 2021 at 09:07:09AM -0600, Mathieu Poirier escreveu: >> Hi James, >> >> On Fri, Apr 16, 2021 at 01:56:30PM +0300, James Clark wrote: >>> Changes since v1: >>> * Improved variable name from etm_timestamp -> cs_timestamp >>> * Fixed ordering of Signed-off-by >>> >> >> You forgot to add the RB and AB you received. Since Arnaldo is responsible for >> the perf tools subsystem, please send another revision. > > > > Yep, please collect Reported-by and Acked-by as you go sending new > versions of a patchset, the last one I don't have a problem collecting > myself, but if you have to resend, please collect the feedback tags. > > - Arnaldo > Ok thanks, I will keep that in mind for the future. I wasn't sure if they still applied or not as it was a new version. Thanks James >> Thanks, >> Mathieu >> >>> James Clark (2): >>> perf cs-etm: Refactor timestamp variable names >>> perf cs-etm: Set time on synthesised samples to preserve ordering >>> >>> .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 18 +++---- >>> tools/perf/util/cs-etm.c | 52 ++++++++++--------- >>> tools/perf/util/cs-etm.h | 4 +- >>> 3 files changed, 39 insertions(+), 35 deletions(-) >>> >>> -- >>> 2.28.0 >>> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel