From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758956AbcJYPxW (ORCPT ); Tue, 25 Oct 2016 11:53:22 -0400 Received: from vern.gendns.com ([206.190.152.46]:45644 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755860AbcJYPxP (ORCPT ); Tue, 25 Oct 2016 11:53:15 -0400 Subject: Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration. To: Sekhar Nori , Axel Haslam References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-3-ahaslam@baylibre.com> <7f9efe9d-0912-e10a-3e45-24c5d2b455ab@ti.com> <758f206c-d0bd-6f70-da1e-42c88d6dd1f0@ti.com> Cc: Greg KH , Johan Hovold , robh+dt@kernel.org, Alan Stern , Kevin Hilman , Sergei Shtylyov , manjunath.goudar@linaro.org, Mark Brown , Alexandre Bailon , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: David Lechner Message-ID: Date: Tue, 25 Oct 2016 10:53:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <758f206c-d0bd-6f70-da1e-42c88d6dd1f0@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sekhar, On 10/25/2016 05:17 AM, Sekhar Nori wrote: > On Tuesday 25 October 2016 03:07 PM, Axel Haslam wrote: >> Hi Sekar, >> >> On Tue, Oct 25, 2016 at 10:10 AM, Sekhar Nori wrote: >>> On Monday 24 October 2016 10:16 PM, ahaslam@baylibre.com wrote: >>>> From: David Lechner >>>> >>>> The CFGCHIP registers are used by a number of devices, so using a syscon >>>> device to share them. The first consumer of this will by the phy-da8xx-usb >>>> driver. >>>> >>>> Signed-off-by: David Lechner >>>> [Axel: minor fix: change id to -1] >>> >>> Can you please clarify this change? There could be other syscon devices >>> on the chip for other common registers. Why use the singular device-id? >>> >> >> in the case of non DT boot, the phy driver is looking for "syscon" : >> >> d_phy->regmap = syscon_regmap_lookup_by_pdevname("syscon"); >> >> if we register the syscon driver with id = 0, the actual name of the syscon >> device will be "syscon.0" and the phy driver will fail to probe, because >> the strncmp match in the syscon driver (syscon_match_pdevname) >> will fail. >> >> should i change the phy driver instead? > > Yes, please. Forcing only one syscon region for the whole chip will be > too restrictive, I am pretty sure. > > Thanks, > Sekhar > In the previous review, you requested that this be changed to -1 [1]. If we change it back to 0, it will also require reverting a patch to the phy driver that has already been merged[2]. [1]: http://www.gossamer-threads.com/lists/linux/kernel/2435807?page=last [2]: http://www.gossamer-threads.com/lists/linux/kernel/2518804 From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Lechner Subject: Re: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration. Date: Tue, 25 Oct 2016 10:53:12 -0500 Message-ID: References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-3-ahaslam@baylibre.com> <7f9efe9d-0912-e10a-3e45-24c5d2b455ab@ti.com> <758f206c-d0bd-6f70-da1e-42c88d6dd1f0@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <758f206c-d0bd-6f70-da1e-42c88d6dd1f0-l0cyMroinI0@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sekhar Nori , Axel Haslam Cc: Greg KH , Johan Hovold , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Alan Stern , Kevin Hilman , Sergei Shtylyov , manjunath.goudar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Mark Brown , Alexandre Bailon , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Sekhar, On 10/25/2016 05:17 AM, Sekhar Nori wrote: > On Tuesday 25 October 2016 03:07 PM, Axel Haslam wrote: >> Hi Sekar, >> >> On Tue, Oct 25, 2016 at 10:10 AM, Sekhar Nori wrote: >>> On Monday 24 October 2016 10:16 PM, ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org wrote: >>>> From: David Lechner >>>> >>>> The CFGCHIP registers are used by a number of devices, so using a syscon >>>> device to share them. The first consumer of this will by the phy-da8xx-usb >>>> driver. >>>> >>>> Signed-off-by: David Lechner >>>> [Axel: minor fix: change id to -1] >>> >>> Can you please clarify this change? There could be other syscon devices >>> on the chip for other common registers. Why use the singular device-id? >>> >> >> in the case of non DT boot, the phy driver is looking for "syscon" : >> >> d_phy->regmap = syscon_regmap_lookup_by_pdevname("syscon"); >> >> if we register the syscon driver with id = 0, the actual name of the syscon >> device will be "syscon.0" and the phy driver will fail to probe, because >> the strncmp match in the syscon driver (syscon_match_pdevname) >> will fail. >> >> should i change the phy driver instead? > > Yes, please. Forcing only one syscon region for the whole chip will be > too restrictive, I am pretty sure. > > Thanks, > Sekhar > In the previous review, you requested that this be changed to -1 [1]. If we change it back to 0, it will also require reverting a patch to the phy driver that has already been merged[2]. [1]: http://www.gossamer-threads.com/lists/linux/kernel/2435807?page=last [2]: http://www.gossamer-threads.com/lists/linux/kernel/2518804 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: david@lechnology.com (David Lechner) Date: Tue, 25 Oct 2016 10:53:12 -0500 Subject: [PATCH/RFT v2 02/17] ARM: davinci: da8xx: Add CFGCHIP syscon platform declaration. In-Reply-To: <758f206c-d0bd-6f70-da1e-42c88d6dd1f0@ti.com> References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-3-ahaslam@baylibre.com> <7f9efe9d-0912-e10a-3e45-24c5d2b455ab@ti.com> <758f206c-d0bd-6f70-da1e-42c88d6dd1f0@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sekhar, On 10/25/2016 05:17 AM, Sekhar Nori wrote: > On Tuesday 25 October 2016 03:07 PM, Axel Haslam wrote: >> Hi Sekar, >> >> On Tue, Oct 25, 2016 at 10:10 AM, Sekhar Nori wrote: >>> On Monday 24 October 2016 10:16 PM, ahaslam at baylibre.com wrote: >>>> From: David Lechner >>>> >>>> The CFGCHIP registers are used by a number of devices, so using a syscon >>>> device to share them. The first consumer of this will by the phy-da8xx-usb >>>> driver. >>>> >>>> Signed-off-by: David Lechner >>>> [Axel: minor fix: change id to -1] >>> >>> Can you please clarify this change? There could be other syscon devices >>> on the chip for other common registers. Why use the singular device-id? >>> >> >> in the case of non DT boot, the phy driver is looking for "syscon" : >> >> d_phy->regmap = syscon_regmap_lookup_by_pdevname("syscon"); >> >> if we register the syscon driver with id = 0, the actual name of the syscon >> device will be "syscon.0" and the phy driver will fail to probe, because >> the strncmp match in the syscon driver (syscon_match_pdevname) >> will fail. >> >> should i change the phy driver instead? > > Yes, please. Forcing only one syscon region for the whole chip will be > too restrictive, I am pretty sure. > > Thanks, > Sekhar > In the previous review, you requested that this be changed to -1 [1]. If we change it back to 0, it will also require reverting a patch to the phy driver that has already been merged[2]. [1]: http://www.gossamer-threads.com/lists/linux/kernel/2435807?page=last [2]: http://www.gossamer-threads.com/lists/linux/kernel/2518804