From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF2A4C5B579 for ; Sat, 29 Jun 2019 16:45:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2EEB20665 for ; Sat, 29 Jun 2019 16:45:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbfF2Qpf (ORCPT ); Sat, 29 Jun 2019 12:45:35 -0400 Received: from smtprelay0042.hostedemail.com ([216.40.44.42]:48378 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726837AbfF2Qpe (ORCPT ); Sat, 29 Jun 2019 12:45:34 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 72872182CF666; Sat, 29 Jun 2019 16:45:32 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wood26_67b7f2b025644 X-Filterd-Recvd-Size: 3038 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf01.hostedemail.com (Postfix) with ESMTPA; Sat, 29 Jun 2019 16:45:12 +0000 (UTC) Message-ID: Subject: Re: [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro From: Joe Perches To: Alexey Dobriyan , Andreas Dilger Cc: Andrew Morton , Shyam Saini , kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, keescook@chromium.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-ext4 , devel@lists.orangefs.org, linux-mm@kvack.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org, kvm@vger.kernel.org, mayhs11saini@gmail.com Date: Sat, 29 Jun 2019 09:45:10 -0700 In-Reply-To: <20190629142510.GA10629@avx2> References: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> <20190611134831.a60c11f4b691d14d04a87e29@linux-foundation.org> <6DCAE4F8-3BEC-45F2-A733-F4D15850B7F3@dilger.ca> <20190629142510.GA10629@avx2> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2019-06-29 at 17:25 +0300, Alexey Dobriyan wrote: > On Tue, Jun 11, 2019 at 03:00:10PM -0600, Andreas Dilger wrote: > > On Jun 11, 2019, at 2:48 PM, Andrew Morton wrote: > > > On Wed, 12 Jun 2019 01:08:36 +0530 Shyam Saini wrote: > > I did a check, and FIELD_SIZEOF() is used about 350x, while sizeof_field() > > is about 30x, and SIZEOF_FIELD() is only about 5x. > > > > That said, I'm much more in favour of "sizeof_field()" or "sizeof_member()" > > than FIELD_SIZEOF(). Not only does that better match "offsetof()", with > > which it is closely related, but is also closer to the original "sizeof()". > > > > Since this is a rather trivial change, it can be split into a number of > > patches to get approval/landing via subsystem maintainers, and there is no > > huge urgency to remove the original macros until the users are gone. It > > would make sense to remove SIZEOF_FIELD() and sizeof_field() quickly so > > they don't gain more users, and the remaining FIELD_SIZEOF() users can be > > whittled away as the patches come through the maintainer trees. > > The signature should be > > sizeof_member(T, m) > > it is proper English, > it is lowercase, so is easier to type, > it uses standard term (member, not field), > it blends in with standard "sizeof" operator, yes please. Also, a simple script conversion applied immediately after an rc1 might be easiest rather than individual patches. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Sat, 29 Jun 2019 16:45:10 +0000 Subject: Re: [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro Message-Id: List-Id: References: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> <20190611134831.a60c11f4b691d14d04a87e29@linux-foundation.org> <6DCAE4F8-3BEC-45F2-A733-F4D15850B7F3@dilger.ca> <20190629142510.GA10629@avx2> In-Reply-To: <20190629142510.GA10629@avx2> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexey Dobriyan , Andreas Dilger Cc: Andrew Morton , Shyam Saini , kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, keescook@chromium.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-ext4 , devel@lists.orangefs.org, linux-mm@kvack.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org, kvm@vger.kernel.org, mayhs11saini@gmail.com On Sat, 2019-06-29 at 17:25 +0300, Alexey Dobriyan wrote: > On Tue, Jun 11, 2019 at 03:00:10PM -0600, Andreas Dilger wrote: > > On Jun 11, 2019, at 2:48 PM, Andrew Morton wrote: > > > On Wed, 12 Jun 2019 01:08:36 +0530 Shyam Saini wrote: > > I did a check, and FIELD_SIZEOF() is used about 350x, while sizeof_field() > > is about 30x, and SIZEOF_FIELD() is only about 5x. > > > > That said, I'm much more in favour of "sizeof_field()" or "sizeof_member()" > > than FIELD_SIZEOF(). Not only does that better match "offsetof()", with > > which it is closely related, but is also closer to the original "sizeof()". > > > > Since this is a rather trivial change, it can be split into a number of > > patches to get approval/landing via subsystem maintainers, and there is no > > huge urgency to remove the original macros until the users are gone. It > > would make sense to remove SIZEOF_FIELD() and sizeof_field() quickly so > > they don't gain more users, and the remaining FIELD_SIZEOF() users can be > > whittled away as the patches come through the maintainer trees. > > The signature should be > > sizeof_member(T, m) > > it is proper English, > it is lowercase, so is easier to type, > it uses standard term (member, not field), > it blends in with standard "sizeof" operator, yes please. Also, a simple script conversion applied immediately after an rc1 might be easiest rather than individual patches. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59BDCC4321A for ; Sat, 29 Jun 2019 16:45:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DF4B120665 for ; Sat, 29 Jun 2019 16:45:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF4B120665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4CC456B0003; Sat, 29 Jun 2019 12:45:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47D188E0003; Sat, 29 Jun 2019 12:45:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 392728E0002; Sat, 29 Jun 2019 12:45:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-qk1-f205.google.com (mail-qk1-f205.google.com [209.85.222.205]) by kanga.kvack.org (Postfix) with ESMTP id 1A55E6B0003 for ; Sat, 29 Jun 2019 12:45:34 -0400 (EDT) Received: by mail-qk1-f205.google.com with SMTP id c1so9771006qkl.7 for ; Sat, 29 Jun 2019 09:45:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:message-id :subject:from:to:cc:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=mmNnrGJ4iPn/XNLkh36mhMegpzuq5dGijH4DxmwDTek=; b=iTe6E6GayYEQsavK0Af1+K11Tcr7fw67nKwsl/JSxBVmGCkW7kIg8Nq85kBPjRgLjr Mkn+nN5DV1vqZU5IiMXX2YZLypVBLsfxJueeF2dqKmpKW4rsdkhI/R4ROSAafIKGzVFm AhxSiVcAsN6++ZcksdEkEJhLb3BwzACwDR3BGvGVvm5Md4Yes8aNSXB4pwX1wdZabdTE COBiD/as4lRy81MbkvJ6syoZZN68hSa1TmDSSro0+PKX25E85sELzUNRCL0l04NxDOu5 c/XFTpSfrBawRalKHI8OXvfWKKf2Lop2fvmcFS8h2hwgkFVvTKeyhVUoEs640ndMVAdN Q17A== X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 216.40.44.42 is neither permitted nor denied by best guess record for domain of joe@perches.com) smtp.mailfrom=joe@perches.com X-Gm-Message-State: APjAAAX7/dQnlstUIe55GhcktwGOrAt7rjG4UtvBSrR+T5cfxlAmHmMF XNZCIoyVyBcPpP0q4jq4yHo4jxFYFjAj06rOy3JKhxQkhUtlyTMVVlK/hzct894h57RXH76vnp8 MwSDhde6rBfM/FsGgL0b9zwOLbjTdaGjc9wfstfvTRmukPCvdDPRMSOK2VJqSrLI= X-Received: by 2002:a37:8604:: with SMTP id i4mr6577508qkd.255.1561826733857; Sat, 29 Jun 2019 09:45:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqy35zStseaCFplSz+bmDReEO9Q7OwSosQuMWdC5gS5TixezjWCF5XV+QYFLA48TwVsP6b4x X-Received: by 2002:a37:8604:: with SMTP id i4mr6577468qkd.255.1561826733156; Sat, 29 Jun 2019 09:45:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561826733; cv=none; d=google.com; s=arc-20160816; b=O/PXFIAmHVxG39hQ8Wb5GxDYcNLXI1T5HHa0ON/vIITyjcr1LUML3YFyCYnqqXqS1c Z9outV6KsYZbPDcYF2Jiybj8UkWlzksNAPG6x0w43DbO02mLXfSbNLGHlwF+ZfQOYXEM f77KwVvGU2NMmAN1Ol+YGmy4g0bbMhW5BPb/+VIm3l+0Dq86Zo9yKj8utMcG6QLcRtfd 6H6alSBvy4HV+ORfDpPL37sLZnreYT3zV5eBED0zeML3/+Aki8H/NQZIWXGJle542/Cq YdAMkf9KOd7JIsP1xYiqy40SPVn66QeJiGJAl1j37Ay9gvUiusC5mzv77fYAIvGsXFdv dGwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id; bh=mmNnrGJ4iPn/XNLkh36mhMegpzuq5dGijH4DxmwDTek=; b=sjEnc6xJfDuDAyWi0EeFBSBzmJTS1LYzYOONvCueLy0UiL/Qxr28EVa9S6FJU/rbXb a1gziZsF61nfWv0ZC1nfWOsqAI59MLPuaoXl8ukxs8YySmfZCs/6BOGctc2q6gRkaVNU uAr4wy6KI+qsHTyko82p28EfD47xDv47eB13U5tITPPvGP38u6ByrVM/JEHgqpC3Gvzl 0dOJlsrmv9XvHfRcjBhyOtkrxCo0Gbv26BTUvjuV66COmB/8BbUJ6rupjkCBbBEujnWx 0rR4fPqDiGdO4W26LbxliJRqZT8WLBWvXL/0Y6Ng+tT+5HwHH2Giw/sSBXQ5GYA7VB8X ZhdA== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 216.40.44.42 is neither permitted nor denied by best guess record for domain of joe@perches.com) smtp.mailfrom=joe@perches.com Received: from smtprelay.hostedemail.com (smtprelay0042.hostedemail.com. [216.40.44.42]) by mx.google.com with ESMTPS id s43si3881052qtk.69.2019.06.29.09.45.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Jun 2019 09:45:33 -0700 (PDT) Received-SPF: neutral (google.com: 216.40.44.42 is neither permitted nor denied by best guess record for domain of joe@perches.com) client-ip=216.40.44.42; Authentication-Results: mx.google.com; spf=neutral (google.com: 216.40.44.42 is neither permitted nor denied by best guess record for domain of joe@perches.com) smtp.mailfrom=joe@perches.com Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 72872182CF666; Sat, 29 Jun 2019 16:45:32 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wood26_67b7f2b025644 X-Filterd-Recvd-Size: 3038 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf01.hostedemail.com (Postfix) with ESMTPA; Sat, 29 Jun 2019 16:45:12 +0000 (UTC) Message-ID: Subject: Re: [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro From: Joe Perches To: Alexey Dobriyan , Andreas Dilger Cc: Andrew Morton , Shyam Saini , kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, keescook@chromium.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-ext4 , devel@lists.orangefs.org, linux-mm@kvack.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org, kvm@vger.kernel.org, mayhs11saini@gmail.com Date: Sat, 29 Jun 2019 09:45:10 -0700 In-Reply-To: <20190629142510.GA10629@avx2> References: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> <20190611134831.a60c11f4b691d14d04a87e29@linux-foundation.org> <6DCAE4F8-3BEC-45F2-A733-F4D15850B7F3@dilger.ca> <20190629142510.GA10629@avx2> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 2019-06-29 at 17:25 +0300, Alexey Dobriyan wrote: > On Tue, Jun 11, 2019 at 03:00:10PM -0600, Andreas Dilger wrote: > > On Jun 11, 2019, at 2:48 PM, Andrew Morton wrote: > > > On Wed, 12 Jun 2019 01:08:36 +0530 Shyam Saini wrote: > > I did a check, and FIELD_SIZEOF() is used about 350x, while sizeof_field() > > is about 30x, and SIZEOF_FIELD() is only about 5x. > > > > That said, I'm much more in favour of "sizeof_field()" or "sizeof_member()" > > than FIELD_SIZEOF(). Not only does that better match "offsetof()", with > > which it is closely related, but is also closer to the original "sizeof()". > > > > Since this is a rather trivial change, it can be split into a number of > > patches to get approval/landing via subsystem maintainers, and there is no > > huge urgency to remove the original macros until the users are gone. It > > would make sense to remove SIZEOF_FIELD() and sizeof_field() quickly so > > they don't gain more users, and the remaining FIELD_SIZEOF() users can be > > whittled away as the patches come through the maintainer trees. > > The signature should be > > sizeof_member(T, m) > > it is proper English, > it is lowercase, so is easier to type, > it uses standard term (member, not field), > it blends in with standard "sizeof" operator, yes please. Also, a simple script conversion applied immediately after an rc1 might be easiest rather than individual patches. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2DA4C4321A for ; Sat, 29 Jun 2019 16:45:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97517216FD for ; Sat, 29 Jun 2019 16:45:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ejhpH70s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97517216FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tj4h9eXZUeofRRvcFrvVz2kcRI4ZALji+NBGo+MVy5s=; b=ejhpH70sOIDfOg zM9G+1YPYiGVBR1ZLck+crGIQnmVXu16rSsbG7yiWIjnVUh9E1UP1lDDbNjV2oC35N5N2FiiT1oJK MSwug7jb+eFGknoRjjyZeMp/WuGgMi2/Tdk1SDvtcgEINXziUD2FUaJnBf9wtODetcjmjKIJLV6Sk o0sL92SoBhzh/hIAIy17Izwn1yIKpgYEoFKfmWKZyJqw39kAhej9d0myasnc+o5e71nQjWuvpa9yz FYkwx5WNhb7d4ZYES31IHVEzxV7SUZt2VVc+8d8QREnd4g+CiS+SIbPEDCHu/fQmRBpk7yIK+U1cP jdelZxffWvdKFiyn/R4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hhGTz-0001tI-8W; Sat, 29 Jun 2019 16:45:47 +0000 Received: from smtprelay0243.hostedemail.com ([216.40.44.243] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hhGTv-0001sQ-Ux for linux-arm-kernel@lists.infradead.org; Sat, 29 Jun 2019 16:45:45 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 72872182CF666; Sat, 29 Jun 2019 16:45:32 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wood26_67b7f2b025644 X-Filterd-Recvd-Size: 3038 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf01.hostedemail.com (Postfix) with ESMTPA; Sat, 29 Jun 2019 16:45:12 +0000 (UTC) Message-ID: Subject: Re: [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro From: Joe Perches To: Alexey Dobriyan , Andreas Dilger Date: Sat, 29 Jun 2019 09:45:10 -0700 In-Reply-To: <20190629142510.GA10629@avx2> References: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> <20190611134831.a60c11f4b691d14d04a87e29@linux-foundation.org> <6DCAE4F8-3BEC-45F2-A733-F4D15850B7F3@dilger.ca> <20190629142510.GA10629@avx2> User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190629_094544_139537_0B91C55C X-CRM114-Status: GOOD ( 14.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: keescook@chromium.org, kvm@vger.kernel.org, kernel-hardening@lists.openwall.com, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, devel@lists.orangefs.org, linux-kernel@vger.kernel.org, Shyam Saini , linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-sctp@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Morton , linux-ext4 , intel-gvt-dev@lists.freedesktop.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mayhs11saini@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 2019-06-29 at 17:25 +0300, Alexey Dobriyan wrote: > On Tue, Jun 11, 2019 at 03:00:10PM -0600, Andreas Dilger wrote: > > On Jun 11, 2019, at 2:48 PM, Andrew Morton wrote: > > > On Wed, 12 Jun 2019 01:08:36 +0530 Shyam Saini wrote: > > I did a check, and FIELD_SIZEOF() is used about 350x, while sizeof_field() > > is about 30x, and SIZEOF_FIELD() is only about 5x. > > > > That said, I'm much more in favour of "sizeof_field()" or "sizeof_member()" > > than FIELD_SIZEOF(). Not only does that better match "offsetof()", with > > which it is closely related, but is also closer to the original "sizeof()". > > > > Since this is a rather trivial change, it can be split into a number of > > patches to get approval/landing via subsystem maintainers, and there is no > > huge urgency to remove the original macros until the users are gone. It > > would make sense to remove SIZEOF_FIELD() and sizeof_field() quickly so > > they don't gain more users, and the remaining FIELD_SIZEOF() users can be > > whittled away as the patches come through the maintainer trees. > > The signature should be > > sizeof_member(T, m) > > it is proper English, > it is lowercase, so is easier to type, > it uses standard term (member, not field), > it blends in with standard "sizeof" operator, yes please. Also, a simple script conversion applied immediately after an rc1 might be easiest rather than individual patches. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro Date: Sat, 29 Jun 2019 09:45:10 -0700 Message-ID: References: <20190611193836.2772-1-shyam.saini@amarulasolutions.com> <20190611134831.a60c11f4b691d14d04a87e29@linux-foundation.org> <6DCAE4F8-3BEC-45F2-A733-F4D15850B7F3@dilger.ca> <20190629142510.GA10629@avx2> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190629142510.GA10629@avx2> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Alexey Dobriyan , Andreas Dilger Cc: keescook@chromium.org, kvm@vger.kernel.org, kernel-hardening@lists.openwall.com, netdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, devel@lists.orangefs.org, linux-kernel@vger.kernel.org, Shyam Saini , linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-sctp@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Morton , linux-ext4 , intel-gvt-dev@lists.freedesktop.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mayhs11saini@gmail.com List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCAyMDE5LTA2LTI5IGF0IDE3OjI1ICswMzAwLCBBbGV4ZXkgRG9icml5YW4gd3JvdGU6 Cj4gT24gVHVlLCBKdW4gMTEsIDIwMTkgYXQgMDM6MDA6MTBQTSAtMDYwMCwgQW5kcmVhcyBEaWxn ZXIgd3JvdGU6Cj4gPiBPbiBKdW4gMTEsIDIwMTksIGF0IDI6NDggUE0sIEFuZHJldyBNb3J0b24g PGFrcG1AbGludXgtZm91bmRhdGlvbi5vcmc+IHdyb3RlOgo+ID4gPiBPbiBXZWQsIDEyIEp1biAy MDE5IDAxOjA4OjM2ICswNTMwIFNoeWFtIFNhaW5pIDxzaHlhbS5zYWluaUBhbWFydWxhc29sdXRp b25zLmNvbT4gd3JvdGU6Cj4gPiBJIGRpZCBhIGNoZWNrLCBhbmQgRklFTERfU0laRU9GKCkgaXMg dXNlZCBhYm91dCAzNTB4LCB3aGlsZSBzaXplb2ZfZmllbGQoKQo+ID4gaXMgYWJvdXQgMzB4LCBh bmQgU0laRU9GX0ZJRUxEKCkgaXMgb25seSBhYm91dCA1eC4KPiA+IAo+ID4gVGhhdCBzYWlkLCBJ J20gbXVjaCBtb3JlIGluIGZhdm91ciBvZiAic2l6ZW9mX2ZpZWxkKCkiIG9yICJzaXplb2ZfbWVt YmVyKCkiCj4gPiB0aGFuIEZJRUxEX1NJWkVPRigpLiAgTm90IG9ubHkgZG9lcyB0aGF0IGJldHRl ciBtYXRjaCAib2Zmc2V0b2YoKSIsIHdpdGgKPiA+IHdoaWNoIGl0IGlzIGNsb3NlbHkgcmVsYXRl ZCwgYnV0IGlzIGFsc28gY2xvc2VyIHRvIHRoZSBvcmlnaW5hbCAic2l6ZW9mKCkiLgo+ID4gCj4g PiBTaW5jZSB0aGlzIGlzIGEgcmF0aGVyIHRyaXZpYWwgY2hhbmdlLCBpdCBjYW4gYmUgc3BsaXQg aW50byBhIG51bWJlciBvZgo+ID4gcGF0Y2hlcyB0byBnZXQgYXBwcm92YWwvbGFuZGluZyB2aWEg c3Vic3lzdGVtIG1haW50YWluZXJzLCBhbmQgdGhlcmUgaXMgbm8KPiA+IGh1Z2UgdXJnZW5jeSB0 byByZW1vdmUgdGhlIG9yaWdpbmFsIG1hY3JvcyB1bnRpbCB0aGUgdXNlcnMgYXJlIGdvbmUuICBJ dAo+ID4gd291bGQgbWFrZSBzZW5zZSB0byByZW1vdmUgU0laRU9GX0ZJRUxEKCkgYW5kIHNpemVv Zl9maWVsZCgpIHF1aWNrbHkgc28KPiA+IHRoZXkgZG9uJ3QgZ2FpbiBtb3JlIHVzZXJzLCBhbmQg dGhlIHJlbWFpbmluZyBGSUVMRF9TSVpFT0YoKSB1c2VycyBjYW4gYmUKPiA+IHdoaXR0bGVkIGF3 YXkgYXMgdGhlIHBhdGNoZXMgY29tZSB0aHJvdWdoIHRoZSBtYWludGFpbmVyIHRyZWVzLgo+IAo+ IFRoZSBzaWduYXR1cmUgc2hvdWxkIGJlCj4gCj4gCXNpemVvZl9tZW1iZXIoVCwgbSkKPiAKPiBp dCBpcyBwcm9wZXIgRW5nbGlzaCwKPiBpdCBpcyBsb3dlcmNhc2UsIHNvIGlzIGVhc2llciB0byB0 eXBlLAo+IGl0IHVzZXMgc3RhbmRhcmQgdGVybSAobWVtYmVyLCBub3QgZmllbGQpLAo+IGl0IGJs ZW5kcyBpbiB3aXRoIHN0YW5kYXJkICJzaXplb2YiIG9wZXJhdG9yLAoKeWVzIHBsZWFzZS4KCkFs c28sIGEgc2ltcGxlIHNjcmlwdCBjb252ZXJzaW9uIGFwcGxpZWQKaW1tZWRpYXRlbHkgYWZ0ZXIg YW4gcmMxIG1pZ2h0IGJlIGVhc2llc3QKcmF0aGVyIHRoYW4gaW5kaXZpZHVhbCBwYXRjaGVzLgoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==