From: John Snow <jsnow@redhat.com>
To: Max Reitz <mreitz@redhat.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, Keith Busch <kbusch@kernel.org>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH v2 0/2] block/nvme: add support for write zeros and discard
Date: Tue, 29 Oct 2019 09:33:49 -0400 [thread overview]
Message-ID: <c3c30afc-9e28-fa10-9159-8843e5375d84@redhat.com> (raw)
In-Reply-To: <24390891-6aef-f457-7648-71846360a09c@redhat.com>
On 10/28/19 6:35 AM, Max Reitz wrote:
> On 13.09.19 15:36, Maxim Levitsky wrote:
>> This is the second part of the patches I prepared
>> for this driver back when I worked on mdev-nvme.
>>
>> V2: addressed review feedback, no major changes
>>
>> Best regards,
>> Maxim Levitsky
>>
>> Maxim Levitsky (2):
>> block/nvme: add support for write zeros
>> block/nvme: add support for discard
>>
>> block/nvme.c | 155 ++++++++++++++++++++++++++++++++++++++++++-
>> block/trace-events | 3 +
>> include/block/nvme.h | 19 +++++-
>> 3 files changed, 175 insertions(+), 2 deletions(-)
> Thanks, fixed the indentation in nvme.h in patch 1, and applied to my
> block branch:
>
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
>
> For the record, I don’t think !!x has benefits over x != 0 and I
> personally prefer bool y = x over any of it. O:-)
>
Well, that's even better :) For me, it's about making booleans obvious
as booleans and that's all.
--js
next prev parent reply other threads:[~2019-10-29 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 13:36 [Qemu-devel] [PATCH v2 0/2] block/nvme: add support for write zeros and discard Maxim Levitsky
2019-09-13 13:36 ` [Qemu-devel] [PATCH v2 1/2] block/nvme: add support for write zeros Maxim Levitsky
2019-09-18 20:22 ` John Snow
2019-09-13 13:36 ` [Qemu-devel] [PATCH v2 2/2] block/nvme: add support for discard Maxim Levitsky
2019-09-18 20:24 ` John Snow
2019-10-28 10:35 ` [PATCH v2 0/2] block/nvme: add support for write zeros and discard Max Reitz
2019-10-29 13:33 ` John Snow [this message]
2019-11-04 17:54 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3c30afc-9e28-fa10-9159-8843e5375d84@redhat.com \
--to=jsnow@redhat.com \
--cc=fam@euphon.net \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.