All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniele Alessandrelli <daniele.alessandrelli@linux.intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	Ard Biesheuvel <ardb@kernel.org>
Cc: Meng Yu <yumeng18@huawei.com>,
	"David S. Miller" <davem@davemloft.net>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Zaibo Xu <xuzaibo@huawei.com>,
	wangzhou1@hisilicon.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Mark Gross <mgross@linux.intel.com>,
	"Khurana, Prabhjot" <prabhjot.khurana@intel.com>,
	"Reshetova, Elena" <elena.reshetova@intel.com>,
	Daniele Alessandrelli <daniele.alessandrelli@intel.com>
Subject: Re: [PATCH v7 4/7] crypto: add ecc curve and expose them
Date: Mon, 01 Feb 2021 17:09:41 +0000	[thread overview]
Message-ID: <c3c3d47edbfd61c338deea5a10a4fb39e2ace68a.camel@linux.intel.com> (raw)
In-Reply-To: <20210128103908.GA32495@gondor.apana.org.au>

On Thu, 2021-01-28 at 21:39 +1100, Herbert Xu wrote:
> Once they're distinct algorithms, we can then make sure that only
> the ones that are used in the kernel is added, even if some hardware
> may support more curves.

I like the idea of having different algorithms names (ecdh-nist-
pXXX) for different curves, but I'm not fully convinced by the above
statement.

What's the downside of letting device drivers enable all the curves
supported by the HW (with the exception of obsolete curves /
algorithms), even if there is (currently) no user of such curves in the
kernel? Code size and maintainability?

I think that once there is support for certain curves, it's more likely
that drivers / modules using them will appear.

Also, even if there are no in-tree users, there might be a few out-of-
tree ones.


  reply	other threads:[~2021-02-01 17:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22  7:09 [PATCH v7 0/7] add ECDH and CURVE25519 algorithms support for Kunpeng 930 Meng Yu
2021-01-22  7:09 ` [PATCH v7 1/7] crypto: hisilicon/hpre - add version adapt to new algorithms Meng Yu
2021-01-22  7:09 ` [PATCH v7 2/7] crypto: hisilicon/hpre - add some updates to adapt to Kunpeng 930 Meng Yu
2021-01-22  7:09 ` [PATCH v7 3/7] crypto: hisilicon/hpre - add algorithm type Meng Yu
2021-01-22  7:09 ` [PATCH v7 4/7] crypto: add ecc curve and expose them Meng Yu
2021-01-28  5:03   ` Herbert Xu
2021-01-28 10:30     ` Ard Biesheuvel
2021-01-28 10:39       ` Herbert Xu
2021-02-01 17:09         ` Daniele Alessandrelli [this message]
2021-02-02  5:13           ` Herbert Xu
2021-02-02  9:27             ` Alessandrelli, Daniele
2021-02-02  9:42               ` Herbert Xu
2021-02-02 12:35                 ` Alessandrelli, Daniele
2021-02-04  5:31                   ` Herbert Xu
2021-01-29  2:49       ` Stefan Berger
2021-01-29  3:00         ` Herbert Xu
2021-02-08  6:35           ` Vitaly Chikunov
2021-02-08  6:47             ` Ard Biesheuvel
2021-02-08 21:27               ` Vitaly Chikunov
2021-02-01  3:45     ` yumeng
2021-02-03 18:03     ` Saulo Alessandre
2021-02-04  5:41       ` Herbert Xu
2021-01-22  7:09 ` [PATCH v7 5/7] crypto: add curve 25519 " Meng Yu
2021-01-22  7:09 ` [PATCH v7 6/7] crypto: hisilicon/hpre - add 'ECDH' algorithm Meng Yu
2021-01-22  7:09 ` [PATCH v7 7/7] crypto: hisilicon/hpre - add 'CURVE25519' algorithm Meng Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3c3d47edbfd61c338deea5a10a4fb39e2ace68a.camel@linux.intel.com \
    --to=daniele.alessandrelli@linux.intel.com \
    --cc=ardb@kernel.org \
    --cc=daniele.alessandrelli@intel.com \
    --cc=davem@davemloft.net \
    --cc=elena.reshetova@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgross@linux.intel.com \
    --cc=prabhjot.khurana@intel.com \
    --cc=wangzhou1@hisilicon.com \
    --cc=xuzaibo@huawei.com \
    --cc=yumeng18@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.