All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Cc: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
	"aurelien@aurel32.net" <aurelien@aurel32.net>,
	"aleksandar.rikalo@rt-rk.com" <aleksandar.rikalo@rt-rk.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"amarkovic@wavecomp.com" <amarkovic@wavecomp.com>
Subject: Re: [PATCH v4 6/7] disas: mips: Add micromips R6 disassembler - infrastructure and 16-bit instructions
Date: Fri, 24 Jan 2020 11:03:59 -1000	[thread overview]
Message-ID: <c3c80f0a-e348-4c7c-e8c4-579b16ec22a4@linaro.org> (raw)
In-Reply-To: <CAL1e-=hqgWesfm9f8fsSQ8JS54LybNMMGygbCNi0O+VyfSAJvg@mail.gmail.com>

On 1/24/20 10:56 AM, Aleksandar Markovic wrote:
> 
> 
> On Friday, January 24, 2020, Richard Henderson <richard.henderson@linaro.org
> <mailto:richard.henderson@linaro.org>> wrote:
> 
>     On 1/24/20 6:38 AM, Aleksandar Markovic wrote:
>     > The basic disassembly logic was obtained by somewhat modified script
>     > decodetree.py, and such output was further manually modified to
>     > handle numerous details of micromips 32R6 instruction coding scheme.
> 
>     What modifications to the script?
>     What manual modifications to the output?
> 
>     It's been a while since I looked at micromips, but I don't recall anything so
>     odd that it couldn't be handled with the current output of decodetree.py.
> 
> 
> I don't have dev setup at hand right now, but I can look it up in few days.
> Some of the changes are purely of cosmetic nature (like outputing binary
> instead of hex codes), but some are not. I can send you the whole modified
> script, once I come back to my desk. There are some not-so-obvious micromips
> oddities, if one delves enough into the coding scheme.

The thing I'm concerned about here is any future maintenance of this file.  One
would surely prefer to edit the original decodetree input than this output.


r~


  reply	other threads:[~2020-01-24 21:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-24 16:38 [PATCH v4 0/7] target/mips: Misc MIPS fixes and improvements for 5.0 Aleksandar Markovic
2020-01-24 16:38 ` [PATCH v4 1/7] target/mips: Rectify documentation on deprecating r4k machine Aleksandar Markovic
2020-01-24 16:38 ` [PATCH v4 2/7] target/mips: Add support for MIPS<32|64>R6 CRC32 ISA Aleksandar Markovic
2020-01-24 16:38 ` [PATCH v4 3/7] target/mips: Amend CP0 WatchHi register implementation Aleksandar Markovic
2020-01-24 17:22   ` Aleksandar Rikalo
2020-01-24 16:38 ` [PATCH v4 4/7] target/mips: Add implementation of GINVT instruction Aleksandar Markovic
2020-01-24 17:23   ` Aleksandar Rikalo
2020-01-24 16:38 ` [PATCH v4 5/7] disas: Add a field for target-dependant data Aleksandar Markovic
2020-01-24 17:25   ` Aleksandar Rikalo
2020-01-24 16:38 ` [PATCH v4 6/7] disas: mips: Add micromips R6 disassembler - infrastructure and 16-bit instructions Aleksandar Markovic
2020-01-24 19:44   ` Richard Henderson
2020-01-24 20:56     ` Aleksandar Markovic
2020-01-24 21:03       ` Richard Henderson [this message]
2020-01-24 23:38         ` Aleksandar Markovic
2020-01-25  7:51           ` Richard Henderson
2020-01-25 10:22             ` Aleksandar Markovic
2020-01-25 18:06               ` Richard Henderson
2020-01-24 16:38 ` [PATCH v4 7/7] disas: mips: Add micromips R6 disassembler - 32-bit instructions Aleksandar Markovic
2020-01-24 17:04 ` [PATCH v4 0/7] target/mips: Misc MIPS fixes and improvements for 5.0 no-reply
2020-01-24 18:09 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3c80f0a-e348-4c7c-e8c4-579b16ec22a4@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=aleksandar.m.mail@gmail.com \
    --cc=aleksandar.markovic@rt-rk.com \
    --cc=aleksandar.rikalo@rt-rk.com \
    --cc=amarkovic@wavecomp.com \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.