From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [85.220.165.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69CE72C88 for ; Fri, 8 Oct 2021 11:53:50 +0000 (UTC) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYoRa-0001Fw-GR; Fri, 08 Oct 2021 13:53:42 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1mYoRZ-00063g-Kv; Fri, 08 Oct 2021 13:53:41 +0200 Message-ID: Subject: Re: [PATCH] i.MX6: Support 16-bit BT.1120 video input From: Philipp Zabel To: Krzysztof =?UTF-8?Q?Ha=C5=82asa?= Cc: Steve Longerbeam , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org Date: Fri, 08 Oct 2021 13:53:41 +0200 In-Reply-To: References: <568f79774cc148c58b9045da7b94b4e9e500810b.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-staging@lists.linux.dev Hi Krzysztof, On Wed, 2021-10-06 at 12:52 +0200, Krzysztof Ha=C5=82asa wrote: > Hi Philipp, >=20 > Philipp Zabel writes: >=20 > > > + * - BT.656 and BT.1120 (8/10-bit YUV422) data can always be process= ed > > > + * on-the-fly (converted to YUV420) > >=20 > > This comment seems misleading. The CSI converts to YUV 4:4:4 internally= . >=20 > Well... this is surprising. You mean "on the internal bus", don't you? Yes, anything apart from the bayer/generic data modes, internally everything is converted into 32-bit YUVA/RGBA pixels (according to the Reference Manual, 37.4.2.3 FCW & FCR). That is represented by the MEDIA_BUS_FMT_AYUV8_1X32 media bus format at the CSI source pads. > Please correct me if the following is wrong: >=20 > I always though that the "on-the-fly processing", in case of YUV422, > means in practice I can get YUV420 out of the IPU, without a need to do > e.g. NEON conversion. That is done in the IDMAC, which can write any supported YUV format from the internal YUV pixels (if not in bayer/generic data mode). > I know I can get the original YUV422 as well, > using the "generic data" mode, but it's incompatible with the CODA H.264 > encoder. You should also be able to store the YUV formatted pixels as NV12, NV16, YUYV, etc. > Ok, the DQRM (37.4.3.2.1) states that for parallel YUV the output from > CSI is always YUV444. Ack. > Then 37.4.3.9 says that the only YUV422 way is to use 16-bit "generic > data". This doesn't seem to be very true, however I'm not exactly sure > about the "on-the-fly" thing. I think that statement is limited to the parallel 16-bit interface in hsync/vsync mode, whereas in bt.656 / bt.1120 mode the interface operates as if the two components were clocked in as two separate 8-bit (or 10-bit) values. > The fact is the patch works. > Also, the CSIx_SENS_DATA_FORMAT field in IPUx_CSIx_SENS_CONF register > shows YUV422 YUYV and UYVY input data formats, clearly separate from > "Bayer of Generic data". >=20 > DQIEC, 4.12.10.1, isn't very clear either: > 8) YCbCr 20-bit (10-bit Y + 10-bit U/V) is supported with BT.1120 only > 7) YCbCr 16-bit is supported under the same conditions as 8) > 6) YCbCr 16-bit (=3D YUV422) is also supported as "generic-data" > (no on-the-fly processing). This seems to imply 8) and 7) are > supported WITH o-t-f-p (and obviously I have tested it, 16-bit only). > > I think I will just remove the comment :-) That sounds good to me. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AED6CC433EF for ; Fri, 8 Oct 2021 11:55:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7978660F6E for ; Fri, 8 Oct 2021 11:55:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7978660F6E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u7zflZ96EArFXpaB9z/Bci1pUOlCdkLoaMfM5KzLog4=; b=o9j2wLY03Ns3m4 h7Z+68DRUvLjraO/56PoIoae9WVUivsCQRsWgBfhsC2fUatBrwdOBP/yY5DhwAE+vRQ7s9nbx6IAA vaWdNroiY/dPtyMppPvAKvqz2MLFsKmJGqKzhxCDzhMS5x4cs3k2R4MnmXuQWNJ7W67lKQDaFnbLE f8ltRRsbjaudV4cCzi45XKsEI49u9sV9vm1bX6Bt9vy6NYFn1unb1YpVNC7mCI0p76MftmtMVf2gE eEY8hQOciKRLNKmTB9VF9QaWS18bXZJ+5bG9vC9WlEcflXqcefy29sl/5Nj0FxN8JmXyrEWLBflfF 9RHZH2oxSJhYLxMbaM6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYoRl-002d78-Ei; Fri, 08 Oct 2021 11:53:53 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYoRi-002d6e-2g for linux-arm-kernel@lists.infradead.org; Fri, 08 Oct 2021 11:53:51 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYoRa-0001Fw-GR; Fri, 08 Oct 2021 13:53:42 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1mYoRZ-00063g-Kv; Fri, 08 Oct 2021 13:53:41 +0200 Message-ID: Subject: Re: [PATCH] i.MX6: Support 16-bit BT.1120 video input From: Philipp Zabel To: Krzysztof =?UTF-8?Q?Ha=C5=82asa?= Cc: Steve Longerbeam , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org Date: Fri, 08 Oct 2021 13:53:41 +0200 In-Reply-To: References: <568f79774cc148c58b9045da7b94b4e9e500810b.camel@pengutronix.de> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_045350_129371_918D1B86 X-CRM114-Status: GOOD ( 24.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS3J6eXN6dG9mLAoKT24gV2VkLCAyMDIxLTEwLTA2IGF0IDEyOjUyICswMjAwLCBLcnp5c3p0 b2YgSGHFgmFzYSB3cm90ZToKPiBIaSBQaGlsaXBwLAo+IAo+IFBoaWxpcHAgWmFiZWwgPHAuemFi ZWxAcGVuZ3V0cm9uaXguZGU+IHdyaXRlczoKPiAKPiA+ID4gKyAqIC0gQlQuNjU2IGFuZCBCVC4x MTIwICg4LzEwLWJpdCBZVVY0MjIpIGRhdGEgY2FuIGFsd2F5cyBiZSBwcm9jZXNzZWQKPiA+ID4g KyAqICAgb24tdGhlLWZseSAoY29udmVydGVkIHRvIFlVVjQyMCkKPiA+IAo+ID4gVGhpcyBjb21t ZW50IHNlZW1zIG1pc2xlYWRpbmcuIFRoZSBDU0kgY29udmVydHMgdG8gWVVWIDQ6NDo0IGludGVy bmFsbHkuCj4gCj4gV2VsbC4uLiB0aGlzIGlzIHN1cnByaXNpbmcuIFlvdSBtZWFuICJvbiB0aGUg aW50ZXJuYWwgYnVzIiwgZG9uJ3QgeW91PwoKWWVzLCBhbnl0aGluZyBhcGFydCBmcm9tIHRoZSBi YXllci9nZW5lcmljIGRhdGEgbW9kZXMsIGludGVybmFsbHkKZXZlcnl0aGluZyBpcyBjb252ZXJ0 ZWQgaW50byAzMi1iaXQgWVVWQS9SR0JBIHBpeGVscyAoYWNjb3JkaW5nIHRvIHRoZQpSZWZlcmVu Y2UgTWFudWFsLCAzNy40LjIuMyBGQ1cgJiBGQ1IpLiBUaGF0IGlzIHJlcHJlc2VudGVkIGJ5IHRo ZQpNRURJQV9CVVNfRk1UX0FZVVY4XzFYMzIgbWVkaWEgYnVzIGZvcm1hdCBhdCB0aGUgQ1NJIHNv dXJjZSBwYWRzLgoKPiBQbGVhc2UgY29ycmVjdCBtZSBpZiB0aGUgZm9sbG93aW5nIGlzIHdyb25n Ogo+IAo+IEkgYWx3YXlzIHRob3VnaCB0aGF0IHRoZSAib24tdGhlLWZseSBwcm9jZXNzaW5nIiwg aW4gY2FzZSBvZiBZVVY0MjIsCj4gbWVhbnMgaW4gcHJhY3RpY2UgSSBjYW4gZ2V0IFlVVjQyMCBv dXQgb2YgdGhlIElQVSwgd2l0aG91dCBhIG5lZWQgdG8gZG8KPiBlLmcuIE5FT04gY29udmVyc2lv bi4KClRoYXQgaXMgZG9uZSBpbiB0aGUgSURNQUMsIHdoaWNoIGNhbiB3cml0ZSBhbnkgc3VwcG9y dGVkIFlVViBmb3JtYXQgZnJvbQp0aGUgaW50ZXJuYWwgWVVWIHBpeGVscyAoaWYgbm90IGluIGJh eWVyL2dlbmVyaWMgZGF0YSBtb2RlKS4KCj4gSSBrbm93IEkgY2FuIGdldCB0aGUgb3JpZ2luYWwg WVVWNDIyIGFzIHdlbGwsCj4gdXNpbmcgdGhlICJnZW5lcmljIGRhdGEiIG1vZGUsIGJ1dCBpdCdz IGluY29tcGF0aWJsZSB3aXRoIHRoZSBDT0RBIEguMjY0Cj4gZW5jb2Rlci4KCllvdSBzaG91bGQg YWxzbyBiZSBhYmxlIHRvIHN0b3JlIHRoZSBZVVYgZm9ybWF0dGVkIHBpeGVscyBhcyBOVjEyLCBO VjE2LApZVVlWLCBldGMuCgo+IE9rLCB0aGUgRFFSTSAoMzcuNC4zLjIuMSkgc3RhdGVzIHRoYXQg Zm9yIHBhcmFsbGVsIFlVViB0aGUgb3V0cHV0IGZyb20KPiBDU0kgaXMgYWx3YXlzIFlVVjQ0NC4K CkFjay4KCj4gVGhlbiAzNy40LjMuOSBzYXlzIHRoYXQgdGhlIG9ubHkgWVVWNDIyIHdheSBpcyB0 byB1c2UgMTYtYml0ICJnZW5lcmljCj4gZGF0YSIuIFRoaXMgZG9lc24ndCBzZWVtIHRvIGJlIHZl cnkgdHJ1ZSwgaG93ZXZlciBJJ20gbm90IGV4YWN0bHkgc3VyZQo+IGFib3V0IHRoZSAib24tdGhl LWZseSIgdGhpbmcuCgpJIHRoaW5rIHRoYXQgc3RhdGVtZW50IGlzIGxpbWl0ZWQgdG8gdGhlIHBh cmFsbGVsIDE2LWJpdCBpbnRlcmZhY2UgaW4KaHN5bmMvdnN5bmMgbW9kZSwgd2hlcmVhcyBpbiBi dC42NTYgLyBidC4xMTIwIG1vZGUgdGhlIGludGVyZmFjZQpvcGVyYXRlcyBhcyBpZiB0aGUgdHdv IGNvbXBvbmVudHMgd2VyZSBjbG9ja2VkIGluIGFzIHR3byBzZXBhcmF0ZSA4LWJpdAoob3IgMTAt Yml0KSB2YWx1ZXMuCgo+IFRoZSBmYWN0IGlzIHRoZSBwYXRjaCB3b3Jrcy4KPiBBbHNvLCB0aGUg Q1NJeF9TRU5TX0RBVEFfRk9STUFUIGZpZWxkIGluIElQVXhfQ1NJeF9TRU5TX0NPTkYgcmVnaXN0 ZXIKPiBzaG93cyBZVVY0MjIgWVVZViBhbmQgVVlWWSBpbnB1dCBkYXRhIGZvcm1hdHMsIGNsZWFy bHkgc2VwYXJhdGUgZnJvbQo+ICJCYXllciBvZiBHZW5lcmljIGRhdGEiLgo+IAo+IERRSUVDLCA0 LjEyLjEwLjEsIGlzbid0IHZlcnkgY2xlYXIgZWl0aGVyOgo+IDgpIFlDYkNyIDIwLWJpdCAoMTAt Yml0IFkgKyAxMC1iaXQgVS9WKSBpcyBzdXBwb3J0ZWQgd2l0aCBCVC4xMTIwIG9ubHkKPiA3KSBZ Q2JDciAxNi1iaXQgaXMgc3VwcG9ydGVkIHVuZGVyIHRoZSBzYW1lIGNvbmRpdGlvbnMgYXMgOCkK PiA2KSBZQ2JDciAxNi1iaXQgKD0gWVVWNDIyKSBpcyBhbHNvIHN1cHBvcnRlZCBhcyAiZ2VuZXJp Yy1kYXRhIgo+ICAgIChubyBvbi10aGUtZmx5IHByb2Nlc3NpbmcpLiBUaGlzIHNlZW1zIHRvIGlt cGx5IDgpIGFuZCA3KSBhcmUKPiAgICBzdXBwb3J0ZWQgV0lUSCBvLXQtZi1wIChhbmQgb2J2aW91 c2x5IEkgaGF2ZSB0ZXN0ZWQgaXQsIDE2LWJpdCBvbmx5KS4KPgo+IEkgdGhpbmsgSSB3aWxsIGp1 c3QgcmVtb3ZlIHRoZSBjb21tZW50IDotKQoKVGhhdCBzb3VuZHMgZ29vZCB0byBtZS4KCnJlZ2Fy ZHMKUGhpbGlwcAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=