All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	airlied@linux.ie, daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/3] drm/vboxvideo: Use generic fbdev and framebuffer
Date: Mon, 28 Oct 2019 13:06:28 +0100	[thread overview]
Message-ID: <c3e5bf4a-615b-fed1-6f11-cf5fcc3431d2@redhat.com> (raw)
In-Reply-To: <7180768c-077a-cbf5-ad16-7d53797b5d14@suse.de>

Hi,

On 28-10-2019 12:34, Thomas Zimmermann wrote:
> Hi
> 
> Am 28.10.19 um 12:26 schrieb Hans de Goede:
>> Hi Thomas,
>>
>> On 11-10-2019 15:48, Thomas Zimmermann wrote:
>>> The vboxvideo driver provides its own implementation for fbdev emulation
>>> and framebuffers. Both can be replaced by DRM's generic code.
>>>
>>> All patches have been tested on VirtualBox 6.0.12.
>>>
>>> Thomas Zimmermann (3):
>>>     drm/vboxvideo: Switch to generic fbdev emulation
>>>     drm/vboxvideo: Switch to drm_atomic_helper_dirty_fb()
>>>     drm/vboxvideo: Replace struct vram_framebuffer with generic
>>>       implemenation
>>
>> Thank you for these nice cleanups, unfortunately there is a small
>> bug in the last patch, you are setting:
>>
>>      .fb_create = drm_gem_fb_create,
>>
>> But since in the previous patch you switched to drm_atomic_helper_dirty_fb
>> that should be:
>>
>>      .fb_create = drm_gem_fb_create_with_dirty,
>>
>> The missing with_dirty is causing screenupdates under both plymouth and
>> gnome-shell (with llvmpipe) to gone missing. I'll send a patch fixing
>> this.
> 
> You're right. I did test the patchset, but I can't tell why I didn't see
> this bug.

I know you tested the patch-set, since you said so above :)  You probably
are aware of this already, but did you check what vga-card the vm is using?
New vbox VMs default to their new vmware-svga card emulation, in which case
vboxvideo is not used at all, vboxvideo is only used with the older VboxVGA
and VboxSVGA (*) virtual vga-cards.

> Anyway, thanks a lot for providing the fix.

You are welcome.

Regards,

Hans



*) Of course once I finally get their driver upstream they deprecate it, grumble.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-10-28 12:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 13:48 [PATCH 0/3] drm/vboxvideo: Use generic fbdev and framebuffer Thomas Zimmermann
2019-10-11 13:48 ` [PATCH 1/3] drm/vboxvideo: Switch to generic fbdev emulation Thomas Zimmermann
2019-10-11 13:48 ` [PATCH 2/3] drm/vboxvideo: Switch to drm_atomic_helper_dirty_fb() Thomas Zimmermann
2019-10-11 13:48 ` [PATCH 3/3] drm/vboxvideo: Replace struct vram_framebuffer with generic implemenation Thomas Zimmermann
2019-10-12 12:36 ` [PATCH 0/3] drm/vboxvideo: Use generic fbdev and framebuffer Sam Ravnborg
2019-10-14 14:35   ` Thomas Zimmermann
2019-10-28 11:26 ` Hans de Goede
2019-10-28 11:34   ` Thomas Zimmermann
2019-10-28 12:06     ` Hans de Goede [this message]
2019-10-28 12:24       ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3e5bf4a-615b-fed1-6f11-cf5fcc3431d2@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.