From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BA4CC433EF for ; Mon, 6 Dec 2021 14:28:37 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.239121.414463 (Exim 4.92) (envelope-from ) id 1muEyd-0004vf-HJ; Mon, 06 Dec 2021 14:28:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 239121.414463; Mon, 06 Dec 2021 14:28:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1muEyd-0004vV-E8; Mon, 06 Dec 2021 14:28:23 +0000 Received: by outflank-mailman (input) for mailman id 239121; Mon, 06 Dec 2021 14:28:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1muEyc-0004uv-GK for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:28:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1muEyZ-0007Fl-M8; Mon, 06 Dec 2021 14:28:19 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=[192.168.26.205]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1muEyZ-0004WD-Fw; Mon, 06 Dec 2021 14:28:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Y07Z0IucIf7KAhsvg+ocjOpbTTJeKNdY3IVrIFYq6MM=; b=ema2e6nHCMRM+BagCv1mxsYbL+ abxmG4aKREQz7HqnvePSmWWzo+p2jmS1KUOarzA68tfAc6uRqxMzCbjiuqPocBdObJT8J4Yih11RV AzB0rzp+Xk362zZ845kRoevNj1K1sBLQ0OPgbJ2JhqflZzGUpxtg6VqBhlOhhFf+g2ug=; Message-ID: Date: Mon, 6 Dec 2021 14:28:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement To: Jan Beulich , Ian Jackson Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com> <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com> <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org> <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com> <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org> <24992.55453.893877.246946@mariner.uk.xensource.com> <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com> From: Julien Grall In-Reply-To: <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 06/12/2021 13:44, Jan Beulich wrote: > On 26.11.2021 13:52, Ian Jackson wrote: >> Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch statement"): >>> On 26.11.2021 11:04, Julien Grall wrote: >>>> For this case, you provided some sort of an explanation but so far, I am >>>> still waiting for a link to confirm that the signed-off-by match the one >>>> on the ML. >>> >>> I haven't been able to easily find a mail archive holding this patch. >> >> I 100% agree with Julien on all points in this thread. >> >> Please can we keep the Linux S-o-b. >> >> Note that S-o-b is not a chain of *approval* (whose relevance to us is >> debateable) but but a chain of *custody and transmission* for >> copyright/licence/gdpr purposes. That latter chain is hightly >> relevant to us. >> >> All such S-o-b should be retained. >> >> Of course if you got the patch somewhere other than the Linux commit, >> then the chain of custody doesn't pass through the Linux commit. But >> in that case I expect you to be able to say where you got it. > > I've submitted v2 with S-o-b restored as far as necessary to meet this > requirement. I did not restore all of them, because I continue to not > see the value of retaining them. You saying "is highly relevant to us" > is a statement, but not an explanation of why tags beyond those in the > original submissions need retaining. > > Without me seeing the need / value, I'm afraid I see only two ways > forward: Either things are acceptable as they are now (and will be for > future similar imports), or it needs to be someone else to put time > into spotting and then pulling in such changes. I am a bit confused how this would require more time. They are already in the commit message from Linus's git and you have a correct commit id. So this is merely a copy/paste. I am not going to ack it but I am also not going to Nack it if another maintainer agrees with your approach. Cheers, -- Julien Grall