From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 889F2C48BDF for ; Sun, 13 Jun 2021 06:34:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4767961078 for ; Sun, 13 Jun 2021 06:34:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4767961078 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=weilnetz.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsJh1-0007D2-1i for qemu-devel@archiver.kernel.org; Sun, 13 Jun 2021 02:33:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsJgS-0006YP-UL for qemu-devel@nongnu.org; Sun, 13 Jun 2021 02:33:24 -0400 Received: from mail.weilnetz.de ([37.120.169.71]:54014 helo=mail.v2201612906741603.powersrv.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsJgQ-0007is-FH for qemu-devel@nongnu.org; Sun, 13 Jun 2021 02:33:24 -0400 Received: from edv-macbook-pro.fritz.box (p57b42637.dip0.t-ipconnect.de [87.180.38.55]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.v2201612906741603.powersrv.de (Postfix) with ESMTPSA id B28E0DA0FB1; Sun, 13 Jun 2021 08:33:18 +0200 (CEST) To: Brad Smith , qemu-devel@nongnu.org References: <20210612080358.61176-1-sw@weilnetz.de> <202eedd1-eb24-5463-c17a-64e146b95421@comstyle.com> From: Stefan Weil Subject: Re: [PATCH] meson.build: Support ncurses on MacOS Message-ID: Date: Sun, 13 Jun 2021 08:33:18 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <202eedd1-eb24-5463-c17a-64e146b95421@comstyle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=37.120.169.71; envelope-from=sw@weilnetz.de; helo=mail.v2201612906741603.powersrv.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 13.06.21 um 03:40 schrieb Brad Smith: > This same problem also applies to OpenBSD as we have the same > version of ncurses with support for wide characters. I have a similar > patch in our QEMU port. Then we should either extend the conditional statement to handle OpenBSD = as well, or simply define both macros unconditionally: =C2=A0=C2=A0=C2=A0 # Newer versions of curses use NCURSES_WIDECHAR. =C2=A0=C2=A0=C2=A0 # Older versions (e. g. on MacOS, OpenBSD) still requ= ire=20 _XOPEN_SOURCE_EXTENDED. =C2=A0=C2=A0=C2=A0 curses_compile_args =3D ['-DNCURSES_WIDECHAR=3D1',=20 '-D_XOPEN_SOURCE_EXTENDED=3D1'] Defining only _XOPEN_SOURCE_EXTENDED would also work with old and new=20 versions, so that's another option. Stefan