From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89AADC47082 for ; Mon, 7 Jun 2021 09:11:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 672D1611AB for ; Mon, 7 Jun 2021 09:11:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230306AbhFGJNa (ORCPT ); Mon, 7 Jun 2021 05:13:30 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:3085 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229966AbhFGJN2 (ORCPT ); Mon, 7 Jun 2021 05:13:28 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Fz6tv0TRLzWt1v; Mon, 7 Jun 2021 17:06:47 +0800 (CST) Received: from dggema762-chm.china.huawei.com (10.1.198.204) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 7 Jun 2021 17:11:36 +0800 Received: from [10.174.179.129] (10.174.179.129) by dggema762-chm.china.huawei.com (10.1.198.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 7 Jun 2021 17:11:36 +0800 Subject: Re: [PATCH] agp: remove set but not used variable 'current_size' From: "yukuai (C)" To: CC: , References: <20210514062210.3534108-1-yukuai3@huawei.com> Message-ID: Date: Mon, 7 Jun 2021 17:11:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.129] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggema762-chm.china.huawei.com (10.1.198.204) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping ... On 2021/05/29 17:05, yukuai (C) wrote: > ping... > > On 2021/05/14 14:22, Yu Kuai wrote: >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/char/agp/via-agp.c:131:28: warning: variable ‘current_size’ >> set but not used [-Wunused-but-set-variable] >> >> It is never used, and so can be removed. >> >> Signed-off-by: Yu Kuai >> --- >>   drivers/char/agp/via-agp.c | 3 --- >>   1 file changed, 3 deletions(-) >> >> diff --git a/drivers/char/agp/via-agp.c b/drivers/char/agp/via-agp.c >> index 87a92a044570..dc594f4eca38 100644 >> --- a/drivers/char/agp/via-agp.c >> +++ b/drivers/char/agp/via-agp.c >> @@ -128,9 +128,6 @@ static int via_fetch_size_agp3(void) >>   static int via_configure_agp3(void) >>   { >>       u32 temp; >> -    struct aper_size_info_16 *current_size; >> - >> -    current_size = A_SIZE_16(agp_bridge->current_size); >>       /* address to map to */ >>       agp_bridge->gart_bus_addr = pci_bus_address(agp_bridge->dev, >>