From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE2AC4708C for ; Fri, 28 May 2021 07:42:09 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A1756113D for ; Fri, 28 May 2021 07:42:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A1756113D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.133827.249289 (Exim 4.92) (envelope-from ) id 1lmX7y-00088N-MJ; Fri, 28 May 2021 07:41:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 133827.249289; Fri, 28 May 2021 07:41:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lmX7y-00088G-J5; Fri, 28 May 2021 07:41:54 +0000 Received: by outflank-mailman (input) for mailman id 133827; Fri, 28 May 2021 07:41:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lmX7x-000887-Ly for xen-devel@lists.xenproject.org; Fri, 28 May 2021 07:41:53 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c312cf2a-0f9d-4e48-a459-40f23c47ba95; Fri, 28 May 2021 07:41:52 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E8FF81FD2F; Fri, 28 May 2021 07:41:51 +0000 (UTC) Received: from director2.suse.de (director2.suse-dmz.suse.de [192.168.254.72]) by imap.suse.de (Postfix) with ESMTPSA id A388E11A98; Fri, 28 May 2021 07:41:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c312cf2a-0f9d-4e48-a459-40f23c47ba95 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1622187711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NPdJQ8YPDL8kMV256eAWoFl9ZI+yCo1/juFVkI6RjKM=; b=KCxZmXHSvaI64T+6b4NvxQtxZk7ULPHXvkQ4W4tEzeNQYCMq7NepEec3j6LKAN4gEIQxjT psEVNVAN3y64OgxG+ej0yocdAfokoZrUTTiOWXto8zIkM1p2w/Mzf4kZhu3mUwH5zrbUaN aN3Q2V+61HFwlLBwBU6aY2KhCpl3xDQ= Subject: Re: [PATCH v4 2/4] xen/common: Guard iommu symbols with CONFIG_HAS_PASSTHROUGH From: Jan Beulich To: Connor Davis Cc: Bobby Eshleman , Alistair Francis , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org References: <3b872d59-4330-68ee-c62b-230f5d6cb2cf@suse.com> Message-ID: Date: Fri, 28 May 2021 09:41:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <3b872d59-4330-68ee-c62b-230f5d6cb2cf@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 25.05.2021 10:44, Jan Beulich wrote: > On 24.05.2021 16:34, Connor Davis wrote: >> --- a/xen/include/xen/iommu.h >> +++ b/xen/include/xen/iommu.h >> @@ -51,9 +51,15 @@ static inline bool_t dfn_eq(dfn_t x, dfn_t y) >> return dfn_x(x) == dfn_x(y); >> } >> >> -extern bool_t iommu_enable, iommu_enabled; >> +extern bool_t iommu_enable; > > ... just "bool" used here, as I think I did say before. Can be taken > care of while committing, I think. Actually, while preparing to commit this, I realized this would better be --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -51,8 +51,12 @@ static inline bool_t dfn_eq(dfn_t x, dfn_t y) return dfn_x(x) == dfn_x(y); } +#ifdef CONFIG_HAS_PASSTHROUGH extern bool_t iommu_enable, iommu_enabled; extern bool force_iommu, iommu_quarantine, iommu_verbose; +#else +#define iommu_enabled false +#endif #ifdef CONFIG_X86 extern enum __packed iommu_intremap { Which is what I'm about to commit. Jan