All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@kernel.org>, Aloka Dixit <quic_alokad@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5 1/3] cfg80211: additional processing in NL80211_CMD_SET_BEACON
Date: Tue, 17 May 2022 12:50:24 +0200	[thread overview]
Message-ID: <c41731aea4fc043bad1ab6db724c2283df0a3d42.camel@sipsolutions.net> (raw)
In-Reply-To: <87v8u4wyw4.fsf@kernel.org>

On Tue, 2022-05-17 at 07:45 +0300, Kalle Valo wrote:
> 
> > +++ b/include/net/cfg80211.h
> > @@ -4200,7 +4200,7 @@ struct cfg80211_ops {
> >  	int	(*start_ap)(struct wiphy *wiphy, struct net_device *dev,
> >  			    struct cfg80211_ap_settings *settings);
> >  	int	(*change_beacon)(struct wiphy *wiphy, struct net_device *dev,
> > -				 struct cfg80211_beacon_data *info);
> > +				 struct cfg80211_ap_settings *info);
> 
> Shouldn't patch 3 folded into patch 1? I don't see how patch 1 as is
> would compile without warnings.
> 
Yes, and parts of patch 2 as well.

johannes

  reply	other threads:[~2022-05-17 10:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16 20:24 [PATCH v5 0/3] additional processing in NL80211_CMD_SET_BEACON Aloka Dixit
2022-05-16 20:24 ` [PATCH v5 1/3] cfg80211: " Aloka Dixit
2022-05-17  4:45   ` Kalle Valo
2022-05-17 10:50     ` Johannes Berg [this message]
2022-05-17 18:53       ` Aloka Dixit
2022-05-16 20:24 ` [PATCH v5 2/3] mac80211: process additional data during beacon change Aloka Dixit
2022-05-16 20:24 ` [PATCH v5 3/3] drivers: modify prototype for beacon change functions Aloka Dixit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c41731aea4fc043bad1ab6db724c2283df0a3d42.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_alokad@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.