From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ECE5C433F5 for ; Sun, 31 Oct 2021 22:34:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A5CE60F0F for ; Sun, 31 Oct 2021 22:34:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230303AbhJaWgy (ORCPT ); Sun, 31 Oct 2021 18:36:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:36799 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230125AbhJaWgq (ORCPT ); Sun, 31 Oct 2021 18:36:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635719653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c8n/xhA0zJkzOmAPtQLtzvCuXP3Hx32iHbMD3xWco1s=; b=AxOlOtdClkcei5Sn80mjtZM4CWZVHeJLuLtDHNmbhmzy6Ku/DTlBlfLutQtoz0RbxJ3zZB 27nRT0goSAEjZNCrZZZ5CzZ2pXRj5YOaSwsNZrSMRXnOxq6cQ4ziHYtidMCOJt6TCS1UVM 07FfSP7rsNoXnMsUYEHTiIi07Gbyrr4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-IUrqtT12PAernuCzxMBHeQ-1; Sun, 31 Oct 2021 18:34:08 -0400 X-MC-Unique: IUrqtT12PAernuCzxMBHeQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3A2080A5C0; Sun, 31 Oct 2021 22:34:04 +0000 (UTC) Received: from starship (unknown [10.40.194.243]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CB8619C59; Sun, 31 Oct 2021 22:33:42 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 43/43] KVM: VMX: Don't do full kick when handling posted interrupt wakeup From: Maxim Levitsky To: Paolo Bonzini , Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang Date: Mon, 01 Nov 2021 00:33:40 +0200 In-Reply-To: <01b5edae-aaa9-e96d-daaa-197c0c3a0431@redhat.com> References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-44-seanjc@google.com> <01b5edae-aaa9-e96d-daaa-197c0c3a0431@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-10-25 at 16:16 +0200, Paolo Bonzini wrote: > On 09/10/21 04:12, Sean Christopherson wrote: > > When waking vCPUs in the posted interrupt wakeup handling, do exactly > > that and no more. There is no need to kick the vCPU as the wakeup > > handler just need to get the vCPU task running, and if it's in the guest > > then it's definitely running. > > And more important, the transition from blocking to running will have > gone through sync_pir_to_irr, thus checking ON and manually moving the > vector from PIR to RVI. > > Paolo > I also think so, and maybe this can be added to the commit message. Anyway, last one for the series :) Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22CF9C433F5 for ; Sun, 31 Oct 2021 22:34:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB1CC60F4C for ; Sun, 31 Oct 2021 22:34:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DB1CC60F4C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UXj1PSdW9Y/iqKGFMiopS2++BSrLjUsgQbmPS1aHaeA=; b=GKVfn2s4g9tWcu HC5fgyIoHCdXx0QLhZbQ8WnR9FqWOinrhcyZiBfl3mJ2YjSJTnw5i6cTvsWqgx4JB13uGFyNbCC5q UQ9+ZiAKcfaQcOTXLJyk15X09FK/rZCC4f4XxulhLY5sslrU+kqaK9fCbxDfZdjohsBYy3STjYfb2 xM2jF0Z2uaR/PrxchjoMOQOb4uACS/RSqcyDqrdD+c0JyklnwsiwW8npvNNZRJCNiBgmug4zCo2ee 7YGlm0Iwy8kVGWcabr793Kr6VWBCx3ZMlWDY+/iVNz9qkJJQ/tFw9y7nes3qKWCwG6Uw0OG3rXaZ5 rWq+08SprBxhw8cw5mPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhJPF-00Epga-LA; Sun, 31 Oct 2021 22:34:25 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhJP2-00Epdo-J3 for linux-riscv@lists.infradead.org; Sun, 31 Oct 2021 22:34:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635719651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c8n/xhA0zJkzOmAPtQLtzvCuXP3Hx32iHbMD3xWco1s=; b=WqfH9IRmrLaRC+nsxZSc4B4pNPUm27BxD7rLZo5xR8aGomMZPQHyTLYYBni+ZBQchzfv++ j9M2kQfZdpFtsY8E8k3vvKbZ10VPtw4aodyvA3xth+lzoQZyA8+Jk3oXIVRqMnOPFzwQKX yyVamc93JclZOKdZzOPXcPjBMsqNj6Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-IUrqtT12PAernuCzxMBHeQ-1; Sun, 31 Oct 2021 18:34:08 -0400 X-MC-Unique: IUrqtT12PAernuCzxMBHeQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3A2080A5C0; Sun, 31 Oct 2021 22:34:04 +0000 (UTC) Received: from starship (unknown [10.40.194.243]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CB8619C59; Sun, 31 Oct 2021 22:33:42 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 43/43] KVM: VMX: Don't do full kick when handling posted interrupt wakeup From: Maxim Levitsky To: Paolo Bonzini , Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang Date: Mon, 01 Nov 2021 00:33:40 +0200 In-Reply-To: <01b5edae-aaa9-e96d-daaa-197c0c3a0431@redhat.com> References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-44-seanjc@google.com> <01b5edae-aaa9-e96d-daaa-197c0c3a0431@redhat.com> User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211031_153412_712356_85EFD8F2 X-CRM114-Status: GOOD ( 13.99 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, 2021-10-25 at 16:16 +0200, Paolo Bonzini wrote: > On 09/10/21 04:12, Sean Christopherson wrote: > > When waking vCPUs in the posted interrupt wakeup handling, do exactly > > that and no more. There is no need to kick the vCPU as the wakeup > > handler just need to get the vCPU task running, and if it's in the guest > > then it's definitely running. > > And more important, the transition from blocking to running will have > gone through sync_pir_to_irr, thus checking ON and manually moving the > vector from PIR to RVI. > > Paolo > I also think so, and maybe this can be added to the commit message. Anyway, last one for the series :) Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85DECC433EF for ; Sun, 31 Oct 2021 22:35:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46D2160F0F for ; Sun, 31 Oct 2021 22:35:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 46D2160F0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bgVxOD00EHzTRt9xm0X9czrw8VsdQHb4VYNgMMCAGzY=; b=BrtLLKwguv3Yx5 vaBxM1Ci10e+nJcPLO+FnPaqUD6Casih8jKGCSgM+/XRJpPkAss3hDDdRFZEx6wbg1Jl9y8kIIY44 k72TqXoQgrJky7DjcQsoGR6vws+SFL1gUXzDQ4jWgd9UxTf4XVArshLQczH3qtaOKpv6f7faIHASe 8kZfuE+dJj+NhG50WussINFTSOp9Z2zIyl5tyQrcttb0k0lsU+EEjxDv2HHfhG9C0ESWqndYk5eFA s1pBMlX3jCD2r5LdWmlRIV771Lhg4L/q/BGQGizLT3lCqSko0Yl7SAemeNKklv3bBuqzKrfdokoDx VurWgxrCjUzY1BjtYhcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhJP6-00Epf6-5i; Sun, 31 Oct 2021 22:34:16 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhJP2-00Epdp-J8 for linux-arm-kernel@lists.infradead.org; Sun, 31 Oct 2021 22:34:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635719651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c8n/xhA0zJkzOmAPtQLtzvCuXP3Hx32iHbMD3xWco1s=; b=WqfH9IRmrLaRC+nsxZSc4B4pNPUm27BxD7rLZo5xR8aGomMZPQHyTLYYBni+ZBQchzfv++ j9M2kQfZdpFtsY8E8k3vvKbZ10VPtw4aodyvA3xth+lzoQZyA8+Jk3oXIVRqMnOPFzwQKX yyVamc93JclZOKdZzOPXcPjBMsqNj6Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-IUrqtT12PAernuCzxMBHeQ-1; Sun, 31 Oct 2021 18:34:08 -0400 X-MC-Unique: IUrqtT12PAernuCzxMBHeQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3A2080A5C0; Sun, 31 Oct 2021 22:34:04 +0000 (UTC) Received: from starship (unknown [10.40.194.243]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CB8619C59; Sun, 31 Oct 2021 22:33:42 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 43/43] KVM: VMX: Don't do full kick when handling posted interrupt wakeup From: Maxim Levitsky To: Paolo Bonzini , Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang Date: Mon, 01 Nov 2021 00:33:40 +0200 In-Reply-To: <01b5edae-aaa9-e96d-daaa-197c0c3a0431@redhat.com> References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-44-seanjc@google.com> <01b5edae-aaa9-e96d-daaa-197c0c3a0431@redhat.com> User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211031_153412_729057_2FB005F8 X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2021-10-25 at 16:16 +0200, Paolo Bonzini wrote: > On 09/10/21 04:12, Sean Christopherson wrote: > > When waking vCPUs in the posted interrupt wakeup handling, do exactly > > that and no more. There is no need to kick the vCPU as the wakeup > > handler just need to get the vCPU task running, and if it's in the guest > > then it's definitely running. > > And more important, the transition from blocking to running will have > gone through sync_pir_to_irr, thus checking ON and manually moving the > vector from PIR to RVI. > > Paolo > I also think so, and maybe this can be added to the commit message. Anyway, last one for the series :) Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2698CC433F5 for ; Mon, 1 Nov 2021 21:40:24 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id C4B5560F36 for ; Mon, 1 Nov 2021 21:40:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C4B5560F36 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 764494B11C; Mon, 1 Nov 2021 17:40:23 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PCwjL8h8p0W7; Mon, 1 Nov 2021 17:40:22 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 46CC94B264; Mon, 1 Nov 2021 17:40:14 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E1E1E4B093 for ; Sun, 31 Oct 2021 18:34:12 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t3OF2QcPDUbV for ; Sun, 31 Oct 2021 18:34:11 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D64EC401A2 for ; Sun, 31 Oct 2021 18:34:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635719651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c8n/xhA0zJkzOmAPtQLtzvCuXP3Hx32iHbMD3xWco1s=; b=WqfH9IRmrLaRC+nsxZSc4B4pNPUm27BxD7rLZo5xR8aGomMZPQHyTLYYBni+ZBQchzfv++ j9M2kQfZdpFtsY8E8k3vvKbZ10VPtw4aodyvA3xth+lzoQZyA8+Jk3oXIVRqMnOPFzwQKX yyVamc93JclZOKdZzOPXcPjBMsqNj6Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-IUrqtT12PAernuCzxMBHeQ-1; Sun, 31 Oct 2021 18:34:08 -0400 X-MC-Unique: IUrqtT12PAernuCzxMBHeQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3A2080A5C0; Sun, 31 Oct 2021 22:34:04 +0000 (UTC) Received: from starship (unknown [10.40.194.243]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CB8619C59; Sun, 31 Oct 2021 22:33:42 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 43/43] KVM: VMX: Don't do full kick when handling posted interrupt wakeup From: Maxim Levitsky To: Paolo Bonzini , Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Date: Mon, 01 Nov 2021 00:33:40 +0200 In-Reply-To: <01b5edae-aaa9-e96d-daaa-197c0c3a0431@redhat.com> References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-44-seanjc@google.com> <01b5edae-aaa9-e96d-daaa-197c0c3a0431@redhat.com> User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mailman-Approved-At: Mon, 01 Nov 2021 17:40:12 -0400 Cc: Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , linux-kernel@vger.kernel.org, Atish Patra , linux-riscv@lists.infradead.org, Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, Joerg Roedel , kvm-ppc@vger.kernel.org, David Matlack , linux-arm-kernel@lists.infradead.org, Jim Mattson , Cornelia Huck , linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, Vitaly Kuznetsov X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, 2021-10-25 at 16:16 +0200, Paolo Bonzini wrote: > On 09/10/21 04:12, Sean Christopherson wrote: > > When waking vCPUs in the posted interrupt wakeup handling, do exactly > > that and no more. There is no need to kick the vCPU as the wakeup > > handler just need to get the vCPU task running, and if it's in the guest > > then it's definitely running. > > And more important, the transition from blocking to running will have > gone through sync_pir_to_irr, thus checking ON and manually moving the > vector from PIR to RVI. > > Paolo > I also think so, and maybe this can be added to the commit message. Anyway, last one for the series :) Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Levitsky Date: Sun, 31 Oct 2021 22:33:40 +0000 Subject: Re: [PATCH v2 43/43] KVM: VMX: Don't do full kick when handling posted interrupt wakeup Message-Id: List-Id: References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-44-seanjc@google.com> <01b5edae-aaa9-e96d-daaa-197c0c3a0431@redhat.com> In-Reply-To: <01b5edae-aaa9-e96d-daaa-197c0c3a0431@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paolo Bonzini , Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang On Mon, 2021-10-25 at 16:16 +0200, Paolo Bonzini wrote: > On 09/10/21 04:12, Sean Christopherson wrote: > > When waking vCPUs in the posted interrupt wakeup handling, do exactly > > that and no more. There is no need to kick the vCPU as the wakeup > > handler just need to get the vCPU task running, and if it's in the guest > > then it's definitely running. > > And more important, the transition from blocking to running will have > gone through sync_pir_to_irr, thus checking ON and manually moving the > vector from PIR to RVI. > > Paolo > I also think so, and maybe this can be added to the commit message. Anyway, last one for the series :) Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky