From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH v2 0/5] md: use bio_clone_fast() Date: Tue, 14 Feb 2017 08:31:28 -0700 Message-ID: References: <1487086143-10255-1-git-send-email-tom.leiming@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1487086143-10255-1-git-send-email-tom.leiming@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Ming Lei , Shaohua Li , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , NeilBrown List-Id: linux-raid.ids On 02/14/2017 08:28 AM, Ming Lei wrote: > Hi, > > This patches replaces bio_clone() with bio_fast_clone() in > bio_clone_mddev() because: > > 1) bio_clone_mddev() is used in raid normal I/O and isn't in > resync I/O path, and all the direct access to bvec table in > raid happens on resync I/O only except for write behind of raid1. > Write behind is treated specially, so the replacement is safe. > > 2) for write behind, bio_clone() is kept, but this patchset > introduces bio_clone_bioset_partial() to just clone one specific > bvecs range instead of whole table. Then write behind is improved > too. You can add my reviewed-by to the first patch. Shaohua, I'm fine with you carrying this in the md tree, that would be the easiest way forward. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754244AbdBNPdT (ORCPT ); Tue, 14 Feb 2017 10:33:19 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:32923 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752661AbdBNPdI (ORCPT ); Tue, 14 Feb 2017 10:33:08 -0500 Subject: Re: [PATCH v2 0/5] md: use bio_clone_fast() To: Ming Lei , Shaohua Li , , , , Christoph Hellwig , NeilBrown References: <1487086143-10255-1-git-send-email-tom.leiming@gmail.com> From: Jens Axboe Message-ID: Date: Tue, 14 Feb 2017 08:31:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1487086143-10255-1-git-send-email-tom.leiming@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: DM5PR12CA0019.namprd12.prod.outlook.com (10.172.32.157) To CY4PR15MB1191.namprd15.prod.outlook.com (10.172.177.13) X-MS-Office365-Filtering-Correlation-Id: 55e4d0a1-2466-495e-a0b5-08d454ee8dc9 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR15MB1191; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;3:N6GT4u2iEwgQ42ef0DxN7xIffxGgqCbAhG86q0vsRteDa+6Tad3b7cESRzpEXMIQtV/SgKSJT6wbNITcA7bCXPj7IpoNzT+nS96pu1lxNh1dpehoTiZQZ6qD/rNh2HWZ6bDZJ2rnrM9J/MznTX/Etkja1JZuhh+8WoAZxANRqV/K0vHLyh4gAjBL4h8HWvddjX8Mt1OH6KUBCQmzz9p+DWipOfyQc1ggHoH9WvMk/oWKDg3jlvl/3R3KEGER01QXVsVi4ry3PW5OVKZeTyRhlA==;25:PmGPZPICKFoS1XQK9DVAZbISv39W8yDaP2L4CFHNFGLXmSNV1eFzEzKzftNV/ZTlJ2l5uPtdbEtBa50aVl3purC9Bqcy8LZRwqky+HFBUQHZAL/tTlTJf+Fy7JCGzyZgkwY4HoPiBqGk6wNJNKj1xLhnQ7x2xTnD5tWMh1uNlnBlzQgrb4akAmNO/jsATXIVUXBEaltLnQapFdejmnd6pFYyr0XNHG8B1WvTYKvnndJ7g+9L+HzzFgVbp6phkxDauG2BxlBYQsQPMqAjG+TvAPL9gkzrNd0CtdNWz7aaoBDBK1qWpL8ejmJSfTYZT3Jt/pooMXLap/KjjKuDq8oyuQGt9IL9TF1YjSLY/3fhuukrRpOYySPflkqVNwC23JkF8m/gR0raBrmWGVgdQdn2fvAXN1JsqLoaLnn4EuVcu/t9aP9EVsbm3VjUMH5EEoct0p7ieiQ3r3n5kMEa3pkELg== X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;31:dcsjKBygGVVNHxS1aRmQgvHp9BTSaFkfhyzVOw7vINYMRe6YH6LZDfkr7uU5dx4ioCFOOYxyUMZC0cMbIJbyOPGy16vzJ9Fk/0JF2IG1BpGeQmEyXAd/VhGXfw4RaVJK2pOr1kjPnh1usAHaHJtR1Uspo7mnQEIWBwna5Bc1ozFmVn6RBDWguYxHPUT8a1dkN1MxqKl3exxYhTeCKJSZ2KM2df8FE2qOdrtddYA/BBbZKxZfMMZtwVV0CzT0b6w4mkjMyyrdSD9RbxbJ3zA/lGctWSgk0GDRQlmOBZiaDxA=;20:v8+KAS4liszJJL7NKUOow6rO86yb780TPPpW46s/pcnBkyVJfiTWh9UgY+cScTsoV9Tlr0FawM0QzeJ9P2PyS7qmxXK4tavOcnJRl2wn6FbkRMqJZMVVdLuKb2BeCiamdSxaa8cNBx8d447zr9MYw0hsh4aE5GMZSCfRipzOgcCHYH8vEotLVoKqWVs+YyLeNmK6GSQWNqAEwXDV4lsI7dD59F0x6RKj+rECe2BvcTQozB9gAbb0LE5JiDwr9UcfhjoDFKg9+q1ygNVEEU7BGbecrnLxNHqV1XTEO59x6FM6x5Rmj03dkIqt7/7P9jk5RcClZ3wNREOcOrfW43ZUtWpeZPpA+yGSfCdPC4yxMJOEswP6cElszvtp1aVadS3dKB09L99pk8MTlJ8s6AxGrs8AnOBYP2xa/mEDMGl+CQANSDKr4MgvbqkSeKmeIn8Rt5TZlfdGrZ5bsChYKroN6XY/gffYgv1IdpLBVY0lqr5VtkMs2RquIm8UJAe0r5NF X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123560025)(20161123558025)(20161123555025)(20161123564025)(6072148);SRVR:CY4PR15MB1191;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1191; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;4:Ao4dDlGOSYT6HKFejV2f57FeRRtoyddh8w8utUaw6h6zE/fGBQ+watIlxSMUpYfYdWIiYAIBEJKGwVqjtxJXvEdohZMcZePBFrz1Ca4v46exrx0x3U2NT9UZ12ed9zE2b4Ucli9/q9GoiocICTbXYmW7kvZjMSAh/NyqoyXSG5MJX+Wbgp5n/nckt2KooYXtpcnM0DQxPMZimBxUno3rzck6MSK3uTqty+9mdjeCIkJAzNe2Zxd9SBSsk4kZNrb14cFE2ouCK8MB0KObaDXK8//C0cu5Q6sSAylYWsNPTjgk8GjLNkqBEg1yePAoBkp7EqD54Eq4nlzNGKYg1wX8K1NrNSy6kGFZvJfbpg+tYcdYxsLg1EYPOB8FY+AH5CzAtgswE4a7+NZys0XKeeFvNUeKISL9GbGBDl9bKGn4olnuZXrSNUl1vvC6K0Z2bF96+NfewNVNvrdFEGAaUUQDyz+ZNSzC4dZRMDDpw3iqfKVSb/2uRPgOZqQ5rIrHs0IDlV1nK0F5T4fBvVU//MDJYtxrCH22Pu+3rY1spE04ATqPB0sBwCO/DVcinAak9YoLrzyhLmF7A9YTIFes2EW+110+x3lD8sgrJq9NxQ+djuU= X-Forefront-PRVS: 0218A015FA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(39410400002)(39450400003)(39830400002)(189002)(199003)(377454003)(24454002)(64126003)(77096006)(6486002)(230700001)(229853002)(101416001)(33646002)(42186005)(2950100002)(54356999)(76176999)(25786008)(50986999)(65956001)(5660300001)(65806001)(117156001)(47776003)(66066001)(65826007)(90366009)(2906002)(50466002)(305945005)(97736004)(68736007)(83506001)(6116002)(105586002)(7736002)(3846002)(189998001)(53936002)(31686004)(36756003)(8676002)(6246003)(92566002)(31696002)(81166006)(2201001)(81156014)(38730400002)(53546003)(86362001)(106356001)(23746002)(4001350100001)(81003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1191;H:[192.168.1.154];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1191;23:wzffIG8KQmSy15fehuCkfHGb9Jlt/bVpFJFbe?= =?Windows-1252?Q?XEMNmyMgxuq7ir+9+Ul513ptmOmNhQx7JuBPSN9FIXYAuEjO2CL4kJ+I?= =?Windows-1252?Q?qpNZkBdAEQBdsn+P2daq55jq3r8oAVb8Zf549dQzyvDnO3JRll54Q9as?= =?Windows-1252?Q?TDp5a/7zGtMdB4MgMYE6dsgbXQ9iM25vdlyEUhweUfw70opnmQDpq3ml?= =?Windows-1252?Q?xD5ak5ZjF2H0IrNsVzi0oml+NpVnIJzw7l5DlZPmRn5i0ffsCLv51qOH?= =?Windows-1252?Q?QbF0y+qAGIcs9eF27DD4jd7uHolso4xJo+dW6euBVWo8ykhG5DmLBb79?= =?Windows-1252?Q?Zs8qo6qn22GYI0E/3lBQqy9JuYSJfi/FJ92jF5SXw7119VeKxP9twON3?= =?Windows-1252?Q?JiFMQEUdtUtrk03eXo/nnO8IwaNW2OVPgydD9dkM2D9PWhgs5du/6GFK?= =?Windows-1252?Q?N06g5XR7x98BvCR5MNNOCgV70PkdPtKNGic1L9Wpx+nmGT0a3e/Azijt?= =?Windows-1252?Q?e9vhA7+3Wb8gWMBqazM84CT/yos+yk5UclcBchoWjTe4Fr/IsW3Ogp/v?= =?Windows-1252?Q?w11x5qKT/E7eynGsMoon5+Z72oGLp5pPRnhKjQmxooMYjWd/OTYkjYaz?= =?Windows-1252?Q?hjYi14VM5jQLlQKiIj8jVs/rQSHW8p2V/H4dh4qyyOitODs2vW76K+l0?= =?Windows-1252?Q?mmapCMT4t+8QaFZJoSY2L531XKzJ+XPyfWUQjFWyN1+nTJ7dz3NWIJ7b?= =?Windows-1252?Q?Pb7ayFWH8utGcV8Ed1EOfCy4CgSdMXt76qMiOEfIBoJ6zEA0BMimJeHH?= =?Windows-1252?Q?931uh6Yy+pKYBL/2SCuZR5OVf0y58lnjymAqMCWvgaalL5H28/M6Pu0z?= =?Windows-1252?Q?lrWx/2FHryfyTheV8p2SYHP0Sc/HRTZr6zcS4aaVcrwaclNqQBtEP7G/?= =?Windows-1252?Q?nr4P/pKvlmt1eF9cwwZGhM3hrfp6Z8hEzK396SD0jPNm1Aaz84HrCMy2?= =?Windows-1252?Q?rHChtNBUvemQvXcf9hIXIAKvChDXMWmj4+bZLyOEnpDFD2ZltfRlRLyD?= =?Windows-1252?Q?Ebouy6d6nDn0/nZwfG4Txd5Ge/7u1tAoY/htoeDCP3phP2q7E2oJFk9Q?= =?Windows-1252?Q?UMRrsmzwmDRliJBPkbCFscUUrYkogttRbgsulscC7kItp/I0RkcDVG67?= =?Windows-1252?Q?qxk5hMMVveC4o65x1bnUWJey35WixJZGAKQHoYnBwNaJvvV8jneXn6+S?= =?Windows-1252?Q?OwWiWdEVyHV7tOjitXeIr/f6yUIKfJ2GDglO/qC+Bi/ifP/Fr/C/0FeC?= =?Windows-1252?Q?uWiY2aMwNdxCpG6cP2H1j+xsZuFBMsvB4jhBMIsFkyqZX588IVY/jgfH?= =?Windows-1252?Q?T9Ou7/pFB0398sUkt9z79/atDQFTPN2OhawNOClk2n75zDJ1V4RW9sMC?= =?Windows-1252?Q?3lCGTRlSEMrMfVKp5vdu1u7tII4NCFNJRfWs4YGTSTSMsSYpbaoR532T?= =?Windows-1252?Q?d2EwEoYtkTbL+5DGkMLouMgiWApzHS6iaR3zyGyS/lUqiZsBKokCViTc?= =?Windows-1252?Q?F0jSJwR2vO7Gek=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;6:iAAEkDFjT/9vsNpD6Wvfa8bn/6sqTZcFYWr0Osq5OvjFi1oekY/8P0tCd8JpkseNaJq5KBk0syan9sDqdvfd2ouQjeEovUVSSuFZupAaXhb+lCT1yWNv3xTiilA6j1xYIhU9KGVez4qGGgJ32f2AUzdSPFOebktDzOVXAzWf3Vmrc0rdCeVgxPQ4jJd4WZui4hFw7X5WP90iTuhBPj6jxTG5c2o17MnebOzrQ586I4tkAqDQCNAbHOJtNL2I2xVlpjDj0HbKOsBw19m9Yg/IzD+lc1AtVsUkkhvJcSDgSSRePQfXg5yVAvAWFe6BTyMOxNI4m2f3zwOfxXKPFUfdtwzfVuoZ1Wj0BOZ31bkZfgmFnWldTixbxNc4C3bOM1GJMX5cPWLmFkp0nuIZtX5rYA==;5:lFmVzll65UV7adIRx15B0E/sUoMS2hwr8zUnM6OX5Mz8HDlJq4Qmykl/hBGXxm8Oq9vee9BlUIf+pQabTF2rsOw5T0bybjszGnul+dCNZFriQcnOGLmpBZFYeGILqabHpwbR9Vi7KrkukEI/btRD6g==;24:uhw5CI45v15NCg0AxXA6oGTjZMJJOqJWhvTrrKGGbGEoOvxIOz99I6w7fPvenHnuwlPcPmazN5egfduecyCfZE5o2BlhEzncyaxly/mF77s= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;7:cN8DXYHHNHTFzCFT4x+do37cmKZVf7LBHZ6y0iUpz/qC/Q8vG2jOTYuaaZU1ngm4dJh0wpeRD9QUw1giR9cJPP5Xc9y/XQ+La8ePGIyu5wITFquj0K7ZloWIvk2PAufPvLLKW6IN1ze2/hCtduCtnUWWGmFfvBkQO4vvHD+QnFn1Z85OuED+Hu/43E859NXlXvHcpzPhWDkqDnqxJaT+r34TeBIyCySxqWKrcJ9LW+vUcuMzD/nGbGVdCu30OKzAan3F+Wg7OvUEdN+L71YqRTHCGDrORWzKCeL75WlhZV5Gn00BF9DLPIKc+5funtGUvG3aeHzOcw2Lmz+lDhp5h3cml87Wiql1V8ZESwFDsczE2MCidWUlx6aJ8/qI6IKeCfPEFBBPQnZlvFnKFyxo8KIVlxFABlJsnlY+ZZ1Ikf2r/WF5mY+FoJgQzUuPlHIauhTMI0g4sZ/c35CD9mEzZYx1NzVWWy+iIVkkSLrYDXwiwwGnEmxnbv3o6OLXfKmFLnoHsd7BkaPYR+b7HaHVVQ==;20:cf2UmxWh2z93tV/F/q1vl0ZOp09A0kpMUiMi6A79ptMtQgrLsuGAJViu0OzqnDGeuIc9EFg2k/C2qH5fc1NVmhbOW5SmKlUOJEl0RiGdQJAHdr5MtsAvt8xQwZaNJj45FBLa9NOf41RkZjP/2tzu4izRNPRbUuXSqs7VTv0I0yk= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2017 15:31:30.9811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1191 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-14_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/14/2017 08:28 AM, Ming Lei wrote: > Hi, > > This patches replaces bio_clone() with bio_fast_clone() in > bio_clone_mddev() because: > > 1) bio_clone_mddev() is used in raid normal I/O and isn't in > resync I/O path, and all the direct access to bvec table in > raid happens on resync I/O only except for write behind of raid1. > Write behind is treated specially, so the replacement is safe. > > 2) for write behind, bio_clone() is kept, but this patchset > introduces bio_clone_bioset_partial() to just clone one specific > bvecs range instead of whole table. Then write behind is improved > too. You can add my reviewed-by to the first patch. Shaohua, I'm fine with you carrying this in the md tree, that would be the easiest way forward. -- Jens Axboe