All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vijay Balakrishna <vijayb@linux.microsoft.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
	Michael Chan <michael.chan@broadcom.com>
Cc: Netdev <netdev@vger.kernel.org>
Subject: Re: [bnxt] Error: Unable to read VPD
Date: Tue, 11 Jan 2022 13:12:31 -0800	[thread overview]
Message-ID: <c45dd329-9606-4103-60bd-904f9f29f01c@linux.microsoft.com> (raw)
In-Reply-To: <6d6ff22c-df69-36c2-4d42-03ed7f539761@gmail.com>



On 1/11/2022 11:41 AM, Heiner Kallweit wrote:
> On 10.01.2022 22:15, Michael Chan wrote:
>> On Mon, Jan 10, 2022 at 1:02 PM Vijay Balakrishna
>> <vijayb@linux.microsoft.com> wrote:
>>>
>>>
>>> Since moving to 5.10 from 5.4 we are seeing
>>>
>>>> Jan 01 00:00:01 localhost kernel: bnxt_en 0008:01:00.0 (unnamed net_device) (uninitialized): Unable to read VPD
>>>>
>>>> Jan 01 00:00:01 localhost kernel: bnxt_en 0008:01:00.1 (unnamed net_device) (uninitialized): Unable to read VPD
>>>
>>> these appear to be harmless and introduced by
>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a0d0fd70fed5cc4f1e2dd98b801be63b07b4d6ac
>>> Does "Unable to read VPD" need to be an error or can it be a warning
>>> (netdev_warn)?
>>>
>>
>> We can change these to warnings.  Thanks.
> 
> Since 5.15 it is a pci_warn() already. Supposedly "Unable to read VPD" here simply means
> that the device has no (valid) VPD. Does "lspci -vv" list any VPD info?
> If VPD is an optional feature, then maybe the warning should be changed to info level
> and the text should be less alarming.

See no VPD info.

> /sys/bus/pci/devices# ls
> 0000:00:00.0  0000:01:00.0  0000:01:00.1  0008:00:00.0  0008:01:00.0  0008:01:00.1
> /sys/bus/pci/devices# for i in `ls`; do cd $i;ls -lR | grep vpd;cd ..; done
> /sys/bus/pci/devices# lspci -vv | egrep -i '(vpd|vital)'
> /sys/bus/pci/devices




      reply	other threads:[~2022-01-11 21:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10 21:02 [bnxt] Error: Unable to read VPD Vijay Balakrishna
2022-01-10 21:15 ` Michael Chan
2022-01-11 19:41   ` Heiner Kallweit
2022-01-11 21:12     ` Vijay Balakrishna [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c45dd329-9606-4103-60bd-904f9f29f01c@linux.microsoft.com \
    --to=vijayb@linux.microsoft.com \
    --cc=hkallweit1@gmail.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.