From: George Dunlap <george.dunlap@citrix.com>
To: Nick Rosbrook <rosbrookn@gmail.com>
Cc: Nick Rosbrook <rosbrookn@ainfosec.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <ian.jackson@citrix.com>
Subject: Re: [Xen-devel] [PATCH v3 7/8] golang/xenlight: Notify xenlight of SIGCHLD
Date: Fri, 17 Jan 2020 18:28:45 +0000 [thread overview]
Message-ID: <c4659436-3b40-5c99-26be-6557d2a300c2@citrix.com> (raw)
In-Reply-To: <CAEBZRSdvPOLLZ3Qd=4Zr2Ns7enO4RpmFsNFznKUP6=pxqj_jrA@mail.gmail.com>
On 1/17/20 6:13 PM, Nick Rosbrook wrote:
>> // Context represents a libxl_ctx.
>> type Context struct {
>> - ctx *C.libxl_ctx
>> - logger *C.xentoollog_logger_stdiostream
>> + ctx *C.libxl_ctx
>> + logger *C.xentoollog_logger_stdiostream
>> + sigchld chan os.Signal
>> + sigchldDone chan bool
>
> It's preferred to use `chan struct{}` for this pattern; it makes it
> clear that the data sent over the channel has no meaning, and is only
> intended to be used for synchronization.
OK. I think it looks ugly, but there's certainly a signalling value to
having it really be empty.
>
>> + // ...and arrange to keep that promise.
>> + ctx.sigchld = make(chan os.Signal, 2)
>> + ctx.sigchldDone = make(chan bool, 1)
>> + signal.Notify(ctx.sigchld, syscall.SIGCHLD)
>> +
>> + go sigchldHandler(ctx)
>
> It could be useful to add a comment here that explains the lifetime of
> this goroutine, i.e. it returns when the context is Close()'d.
Ack.
>> // Close closes the Context.
>> func (ctx *Context) Close() error {
>> + // Tell our SIGCHLD notifier to shut down, and wait for it to exit
>> + // before we free the context.
>> + if ctx.sigchld == nil {
>
> Shouldn't this be `if ctx.sigchld != nil`?
Er, yes, indeed it should. This has gone through too many iterations...
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-17 18:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 15:57 [Xen-devel] [PATCH v3 1/8] golang/xenlight: Don't try to marshall zero-length arrays in fromC George Dunlap
2020-01-17 15:57 ` [Xen-devel] [PATCH v3 2/8] go/xenlight: Fix CpuidPoliclyList conversion George Dunlap
2020-01-20 23:30 ` Nick Rosbrook
2020-01-17 15:57 ` [Xen-devel] [PATCH v3 3/8] go/xenlight: More informative error messages George Dunlap
2020-01-20 23:32 ` Nick Rosbrook
2020-01-17 15:57 ` [Xen-devel] [PATCH v3 4/8] golang/xenlight: Errors are negative George Dunlap
2020-01-20 23:40 ` Nick Rosbrook
2020-01-17 15:57 ` [Xen-devel] [PATCH v3 5/8] golang/xenlight: Default loglevel to DEBUG until we get everything working George Dunlap
2020-01-20 23:41 ` Nick Rosbrook
2020-01-21 9:55 ` George Dunlap
2020-01-24 19:51 ` Nick Rosbrook
2020-01-17 15:57 ` [Xen-devel] [PATCH v3 6/8] golang/xenlight: Don't leak memory on context open failure George Dunlap
2020-01-20 23:43 ` Nick Rosbrook
2020-01-17 15:57 ` [Xen-devel] [PATCH v3 7/8] golang/xenlight: Notify xenlight of SIGCHLD George Dunlap
2020-01-17 16:52 ` Ian Jackson
2020-01-17 17:33 ` George Dunlap
2020-01-17 18:12 ` [Xen-devel] [PATCH] libxl: event: Document lifetime API for libxl_childproc_setmode Ian Jackson
2020-01-20 12:06 ` Wei Liu
2020-01-17 18:13 ` [Xen-devel] [PATCH v3 7/8] golang/xenlight: Notify xenlight of SIGCHLD Nick Rosbrook
2020-01-17 18:28 ` George Dunlap [this message]
2020-01-17 15:57 ` [Xen-devel] [PATCH v3 8/8] RFC: Sketch constructors, DomainCreateNew George Dunlap
2020-01-17 18:38 ` George Dunlap
2020-01-22 10:32 ` George Dunlap
2020-01-24 19:32 ` Nick Rosbrook
2020-01-27 18:08 ` George Dunlap
2020-01-28 20:41 ` Nick Rosbrook
2020-01-29 14:17 ` Nick Rosbrook
2020-01-29 14:46 ` George Dunlap
2020-02-04 19:26 ` Nick Rosbrook
2020-01-17 16:04 ` [Xen-devel] [PATCH v3 1/8] golang/xenlight: Don't try to marshall zero-length arrays in fromC George Dunlap
2020-01-20 23:39 ` Nick Rosbrook
2020-01-21 17:35 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4659436-3b40-5c99-26be-6557d2a300c2@citrix.com \
--to=george.dunlap@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=rosbrookn@ainfosec.com \
--cc=rosbrookn@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.