From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c Date: Fri, 6 Oct 2017 20:04:59 +0200 Message-ID: References: <20170929122025.GA29498@meghana-HP-Pavilion-Notebook> <4b32d910-f0af-e9cb-feb7-4bc4174bc9c3@tronnes.org> <20170929141324.GA30107@meghana-HP-Pavilion-Notebook> <08dd8e6a-3028-098e-e193-9f408c6a9633@tronnes.org> <20171002074718.jinjkmc76igo2lkx@phenom.ffwll.local> <87y3ou55nx.fsf@intel.com> <3b0e7a80-fe29-1732-63c7-3a84568e617e@tronnes.org> <623db97b-5b65-88d2-0ff6-69abd8602b0d@tronnes.org> <20171005035350.GB28390@meghana-HP-Pavilion-Notebook> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id DEC326E1E9 for ; Fri, 6 Oct 2017 18:05:01 +0000 (UTC) In-Reply-To: <20171005035350.GB28390@meghana-HP-Pavilion-Notebook> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Meghana Madhyastha , daniel@ffwll.ch, outreachy-kernel@googlegroups.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CkRlbiAwNS4xMC4yMDE3IDA1LjUzLCBza3JldiBNZWdoYW5hIE1hZGh5YXN0aGE6Cj4gT24gVHVl LCBPY3QgMDMsIDIwMTcgYXQgMDc6Mzg6MjlQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVzIHdyb3Rl Ogo+PiBEZW4gMDMuMTAuMjAxNyAxOC4wMiwgc2tyZXYgTm9yYWxmIFRyw7hubmVzOgo+Pj4gRGVu IDAzLjEwLjIwMTcgMTYuNTgsIHNrcmV2IE5vcmFsZiBUcsO4bm5lczoKPj4+PiBEZW4gMDIuMTAu MjAxNyAxMC4xMywgc2tyZXYgSmFuaSBOaWt1bGE6Cj4+Pj4+IE9uIE1vbiwgMDIgT2N0IDIwMTcs IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4+Pj4+PiBBbHNvIGFkZGlu ZyBKYW5pLCB3aG8gbG9va2VkIGF0IHRoZSBiYWNrbGlnaHQgS2NvbmZpZyBtZXNzIGluIHRoZQo+ Pj4+Pj4gcGFzdC4KPj4+Pj4gSSd2ZSBldmVuIHNlbnQgcGF0Y2hlcyB0byBmaXggc29tZSBvZiB0 aGUgZGVwZW5kZW5jeSBtZXNzLCBidXQgdGhlCj4+Pj4+IHByb2JsZW0gaXMgc29jaWFsIG5vdCB0 ZWNobmljYWwuIFRoZSBwcm9ibGVtIGlzIHRoYXQgcGVvcGxlIHRoaW5rCj4+Pj4+ICJzZWxlY3Qi IGlzIG1vcmUgY29udmVuaWVudCB0aGFuICJkZXBlbmRzIiBiZWNhdXNlIHRoZXkgY2FuIGp1c3Qg ZW5hYmxlCj4+Pj4+IGEgY29uZmlnIHRoYXQgd2F5LCB3aGlsZSAiZGVwZW5kcyIgd291bGQgcmVx dWlyZSBmaW5kaW5nIGFuZCBlbmFibGluZwo+Pj4+PiBhbGwgdGhlIGRlcGVuZGVuY2llcyBiZWZv cmUgdGhlIG1lbnUgb3B0aW9uIGV2ZW4gc2hvd3MgdXAuCj4+Pj4+Cj4+Pj4+IEkgZG9uJ3QgZGVu eSwgdGhhdCdzIGFubm95aW5nLiBCdXQgaXQncyBhbHNvIGFidXNlIG9mIHNlbGVjdCwgc2VlCj4+ Pj4+IERvY3VtZW50YXRpb24va2J1aWxkL2tjb25maWctbGFuZ3VhZ2UudHh0Ogo+Pj4+Pgo+Pj4+ PiAgwqDCoCBOb3RlOgo+Pj4+PiAgwqDCoMKgwqBzZWxlY3Qgc2hvdWxkIGJlIHVzZWQgd2l0aCBj YXJlLiBzZWxlY3Qgd2lsbCBmb3JjZQo+Pj4+PiAgwqDCoMKgwqBhIHN5bWJvbCB0byBhIHZhbHVl IHdpdGhvdXQgdmlzaXRpbmcgdGhlIGRlcGVuZGVuY2llcy4KPj4+Pj4gIMKgwqDCoMKgQnkgYWJ1 c2luZyBzZWxlY3QgeW91IGFyZSBhYmxlIHRvIHNlbGVjdCBhIHN5bWJvbCBGT08gZXZlbgo+Pj4+ PiAgwqDCoMKgwqBpZiBGT08gZGVwZW5kcyBvbiBCQVIgdGhhdCBpcyBub3Qgc2V0Lgo+Pj4+PiAg wqDCoMKgwqBJbiBnZW5lcmFsIHVzZSBzZWxlY3Qgb25seSBmb3Igbm9uLXZpc2libGUgc3ltYm9s cwo+Pj4+PiAgwqDCoMKgwqAobm8gcHJvbXB0cyBhbnl3aGVyZSkgYW5kIGZvciBzeW1ib2xzIHdp dGggbm8gZGVwZW5kZW5jaWVzLgo+Pj4+PiAgwqDCoMKgwqBUaGF0IHdpbGwgbGltaXQgdGhlIHVz ZWZ1bG5lc3MgYnV0IG9uIHRoZSBvdGhlciBoYW5kIGF2b2lkCj4+Pj4+ICDCoMKgwqDCoHRoZSBp bGxlZ2FsIGNvbmZpZ3VyYXRpb25zIGFsbCBvdmVyLgo+Pj4+Pgo+Pj4+PiBUaGUgcmVhbCBmaXgg d291bGQgYmUgbWFraW5nIGZpbmRpbmcgYW5kIGVuYWJsaW5nIGRlcGVuZGVuY2llcwo+Pj4+PiBy ZWN1cnNpdmVseSBtb3JlIGNvbnZlbmllbnQsIGJ1dCBJIGRvbid0IHNlZSB0aGF0IGhhcHBlbmlu ZyBhbnl0aW1lCj4+Pj4+IHNvb24uCj4+Pj4gSWYgd2UgZG9uJ3Qgc2VsZWN0IEJBQ0tMSUdIVCBp biBkcml2ZXJzLCB3ZSBjYW4gZW5kIHVwIHdpdGggQ09ORklHX0RSTT15Cj4+Pj4gYW5kIENPTkZJ R19CQUNLTElHSFRfQ0xBU1NfREVWSUNFPW0uCj4+Pj4KPj4+PiBTbyB3ZSBjYW4gZWl0aGVyIGRv Ogo+Pj4+Cj4+Pj4gbWVudWNvbmZpZyBEUk0KPj4+PiAgwqDCoMKgIGRlcGVuZHMgb24gKEJBQ0tM SUdIVF9DTEFTU19ERVZJQ0UgfHwgQkFDS0xJR0hUX0NMQVNTX0RFVklDRT1uKQo+Pj4+Cj4+PiBO bywgdGhpcyB3YXMgdGhlIHRoaW5nIHRoYXQgZGlkbid0IHdvcms6Cj4+Pgo+Pj4gZHJpdmVycy9n cHUvZHJtL0tjb25maWc6NzrCoMKgwqDCoMKgIHN5bWJvbCBEUk0gZGVwZW5kcyBvbgo+Pj4gQkFD S0xJR0hUX0NMQVNTX0RFVklDRQo+Pj4gZHJpdmVycy92aWRlby9iYWNrbGlnaHQvS2NvbmZpZzox NTg6wqDCoMKgIHN5bWJvbCBCQUNLTElHSFRfQ0xBU1NfREVWSUNFIGlzCj4+PiBzZWxlY3RlZCBi eSBEUk1fUkFERU9OCj4+PiBkcml2ZXJzL2dwdS9kcm0vS2NvbmZpZzoxNjQ6wqDCoMKgIHN5bWJv bCBEUk1fUkFERU9OIGRlcGVuZHMgb24gRFJNCj4+Pgo+PiBIb3cgYWJvdXQgcHV0dGluZyB0aGUg ZGVwZW5kZW5jeSBpbiB0aGUgZHJpdmVyIGNvbWJpbmVkIHdpdGggSVNfUkVBQ0hBQkxFLAo+PiBi dXQgbm90IGluIGJhY2tsaWdodC5oIGFzIEkgZmlyc3QgcHJvcG9zZWQsIHRoYXQgd29uJ3Qgd29y azoKPj4KPj4gIMKgbWVudWNvbmZpZyBEUk1fVElOWURSTQo+PiAtwqDCoMKgIHNlbGVjdCBCQUNL TElHSFRfTENEX1NVUFBPUlQKPj4gLcKgwqDCoCBzZWxlY3QgQkFDS0xJR0hUX0NMQVNTX0RFVklD RQo+PiArwqDCoMKgIGRlcGVuZHMgb24gKEJBQ0tMSUdIVF9DTEFTU19ERVZJQ0UgfHwgQkFDS0xJ R0hUX0NMQVNTX0RFVklDRT1uKQo+Pgo+Pgo+PiBzdHJ1Y3QgYmFja2xpZ2h0X2RldmljZSAqZHJt X29mX2ZpbmRfYmFja2xpZ2h0KHN0cnVjdCBkZXZpY2UgKmRldikKPj4gewo+PiAgwqDCoMKgIHN0 cnVjdCBiYWNrbGlnaHRfZGV2aWNlICpiYWNrbGlnaHQ7Cj4+ICDCoMKgwqAgc3RydWN0IGRldmlj ZV9ub2RlICpucDsKPj4KPj4gIMKgwqDCoCBpZiAoIUlTX1JFQUNIQUJMRShDT05GSUdfQkFDS0xJ R0hUX0NMQVNTX0RFVklDRSkpCj4+ICDCoMKgwqAgwqDCoMKgIHJldHVybiBOVUxMOwo+PiBbLi4u XQo+PiB9Cj4+Cj4+IEJ1dCB0aGUgSVNfUkVBQ0hBQkxFIGRvZXNuJ3QgZmVlbCByaWdodC4KPj4K Pj4gTWF5YmUgdGhlIHByb2JsZW0gaXMgcHV0dGluZyBhIGZ1bmN0aW9uIGluIERSTSB0aGF0IHJl YWxseSBkb2Vzbid0Cj4+IGJlbG9uZyB0aGVyZS4gSG93IGFib3V0IGNhbGxpbmcgaXQgb2ZfZmlu ZF9iYWNrbGlnaHQoKSBpbnN0ZWFkIGFuZAo+PiBwdXQgaXQgaW4gYmFja2xpZ2h0LltoY10/Cj4g V291bGRuJ3QgaXQgbWFrZSBtb3JlIHNlbnNlIHRvIHB1dCB0aGUgZnVuY3Rpb24gaW4gRFJNID8g QmVjYXVzZSBhbGwgb2YKPiB0aGUgY2FsbGVycyBhcmUgbG9jYXRlZCBpbiBEUk0gYW5kIHNvIEkn ZCB0aGluayBpdCBtYWtlcyBtb3JlIHNlbnNlIHRvCj4gcHV0IGl0IGluIERSTSBhbG9uZyB3aXRo IHRoZSBvdGhlciBfb2YgZnVuY3Rpb25zLgoKSSBkb24ndCB0aGluayBpdCBtYXR0ZXJzIHdoZXJl IHRoZSBjYWxsZXJzIGFyZSwgYnV0IHRoZSBmYWN0IHRoYXQgdGhlIApmdW5jdGlvbnMKYXJlIGFs bCBhYm91dCBiYWNrbGlnaHQgYW5kIG5vdGhpbmcgYWJvdXQgRFJNLCBleGNlcHQgdGhlIGVycm9y IG1lc3NhZ2VzLgoKSSd2ZSBtYWRlIGEgc3VnZ2VzdGlvbiBpbiB0aGUgbGFzdCB2ZXJzaW9uIHdo ZXJlIHdlIGhhdmUgYmFja2xpZ2h0IAptYWludGFpbmVyIGF0dGVudGlvbi4KCk5vcmFsZi4KCj4+ IE5vcmFsZi4KPj4KPj4+PiBPciB3ZSBjYW46Cj4+Pj4KPj4+PiAtI2lmZGVmIENPTkZJR19PRgo+ Pj4+ICsjaWYgSVNfRU5BQkxFRChDT05GSUdfT0YpICYmCj4+Pj4gSVNfUkVBQ0hBQkxFKENPTkZJ R19CQUNLTElHSFRfQ0xBU1NfREVWSUNFKQo+Pj4+ICDCoHN0cnVjdCBiYWNrbGlnaHRfZGV2aWNl ICpvZl9maW5kX2JhY2tsaWdodF9ieV9ub2RlKHN0cnVjdCBkZXZpY2Vfbm9kZQo+Pj4+ICpub2Rl KTsKPj4+PiAgwqAjZWxzZQo+Pj4+ICDCoHN0YXRpYyBpbmxpbmUgc3RydWN0IGJhY2tsaWdodF9k ZXZpY2UgKgo+IEkgaGF2ZSBvbmUgcXVlc3Rpb24uIFdoeSBpc24ndCB5b3VyIHByZXZpb3VzIHNv bHV0aW9uIGEgZ29vZCBzb2x1dGlvbj8KPiBpLmUgSVNfRU5BQkxFRChDT05GSUdfQkFDS0xJR0hU X0NMQVNTX0RFVklDRSkgd2hpY2ggd2FzIHBhcnQgb2YgdjcKPgo+Pj4+IFVzaW5nIHRoZSBzZWNv bmQgb25lIGl0IHdvbid0IGJlIG9idmlvdXMgdG8gdXNlcnMgd2h5IGJhY2tsaWdodCBkb2Vzbid0 Cj4+Pj4gd29yaywKPj4+PiB0aGV5IGhhdmUgYWZ0ZXIgYWxsIGVuYWJsZWQgYmFja2xpZ2h0IChi dXQgYXMgbW9kdWxlIGFuZCBEUk0gYnVpbHRpbikuCj4+Pj4KPj4+PiBTbyBJIHN1cHBvc2UgdGhl IGZpcnN0IG9uZSBpcyBwcmVmZXJyZWQuCj4+Pj4gV2hhdCBlZmZlY3Qgd2lsbCBzdWNoIGEgY2hh bmdlIGhhdmUgb24gYW4gZXhpc3RpbmcgY29uZmlndXJhdGlvbiB3aGVyZQo+Pj4+IERSTT15IGFu ZCBCQUNLTElHSFRfQ0xBU1NfREVWSUNFPW0/IFdpbGwgRFJNIGJlY29tZSBhIG1vZHVsZSBvciB3 aWxsIGl0Cj4+Pj4gYmUgZGlzYWJsZWQ/Cj4gV2h5IHdvdWxkIGl0IGJlIGRpc2FibGVkIGluIHRo aXMgY2FzZSA/Cj4KPiBUaGFua3MgYW5kIHJlZ2FyZHMsCj4gTWVnaGFuYQo+Cj4+Pj4gTm9yYWxm Lgo+Pj4+Cj4+Pj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPj4+PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4+Pj4gZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+Pj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCj4+Pj4KPj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4+PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4+PiBkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo+Pj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6470705412124442624 X-Received: by 10.25.67.30 with SMTP id q30mr86352lfa.40.1507313102347; Fri, 06 Oct 2017 11:05:02 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.46.86.197 with SMTP id k66ls3660521lje.2.gmail; Fri, 06 Oct 2017 11:05:01 -0700 (PDT) X-Google-Smtp-Source: AOwi7QBlUIITwHEnZNH/6plx2k3BDpLfS4xgDVSiy6gkF1Vx+D6WRNmDqbsNtp5IfroooxnKDdjh X-Received: by 10.46.82.9 with SMTP id g9mr109508ljb.42.1507313101006; Fri, 06 Oct 2017 11:05:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507313100; cv=none; d=google.com; s=arc-20160816; b=XUz7mQQhquejpfU1gBlVOT+JG0dWJidZut06d6jOBScshYByTtcLlRtm44G5o5OYgw 21Uvg4tvKevFDhzClxqcqWAGaXimIT9sld56bOqzLkGma9JaIKK/51P/XqJHMvQxkE6B joLZN+w7MQ0ErG9TEJBtXHcTQM/l3WsMrRSJ9MAjEFV/oa/JeJx2in55YzU3E5Ab9olM mQ57Zjd/dEjCQeC8JqMMWomTtSg4rdarikXvHtkurPOb/k0a/tVLUveLpY0GRRj2xOSX HJzOf7vr4z4LTjLaNFJEbjYUS+Qj7kTyHQ4hUlVprRA4VGJK6mVJw3pkGBVB7Ei1TMdk kziw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:arc-authentication-results; bh=RqNx+qq5h7R2hGWOCzaF0VZiYTZOQZrvWoOhRtQiQY4=; b=CIFjlOpfPwg4s0E+8f8TS4jEd7Q2GlAbGsiI7IKdfuH8Myx21X8W4vBVrbBEj0uBni ZLH76/kZUmQUMBXeUT0KVuLdQSoBTcHMN9uNQf/960rjJuW6+FtQH5p0Wz6I1FDOIluE rBLi+V1eG+WM62H4uikaR41BQ0y94Szxug0e6o2nW8TBo9MGtOzwylAXBqhYwHdNITt/ yVuKGTLhOiwurkd9mNdxXZ66Ix9by/rU9iqT+0FKqhFZhNJFndJWcIeAdCbmZEEgd/38 sBqFSBAPSO8A0zPvob+bGsQjRawQDZ1z4uUxyHz8vBaNP4ZDI1FF/wVP6ncgt/kUJOLZ S8ww== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of noralf@tronnes.org designates 2a01:5b40:0:3005::1 as permitted sender) smtp.mailfrom=noralf@tronnes.org Return-Path: Received: from smtp.domeneshop.no (smtp.domeneshop.no. [2a01:5b40:0:3005::1]) by gmr-mx.google.com with ESMTPS id 198si85814lfa.2.2017.10.06.11.05.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Oct 2017 11:05:00 -0700 (PDT) Received-SPF: pass (google.com: domain of noralf@tronnes.org designates 2a01:5b40:0:3005::1 as permitted sender) client-ip=2a01:5b40:0:3005::1; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of noralf@tronnes.org designates 2a01:5b40:0:3005::1 as permitted sender) smtp.mailfrom=noralf@tronnes.org Received: from 211.81-166-168.customer.lyse.net ([81.166.168.211]:53557 helo=[192.168.10.157]) by smtp.domeneshop.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1e0Wzc-0005NV-0E; Fri, 06 Oct 2017 20:05:00 +0200 Subject: Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c To: Meghana Madhyastha , daniel@ffwll.ch, outreachy-kernel@googlegroups.com, dri-devel@lists.freedesktop.org References: <20170929122025.GA29498@meghana-HP-Pavilion-Notebook> <4b32d910-f0af-e9cb-feb7-4bc4174bc9c3@tronnes.org> <20170929141324.GA30107@meghana-HP-Pavilion-Notebook> <08dd8e6a-3028-098e-e193-9f408c6a9633@tronnes.org> <20171002074718.jinjkmc76igo2lkx@phenom.ffwll.local> <87y3ou55nx.fsf@intel.com> <3b0e7a80-fe29-1732-63c7-3a84568e617e@tronnes.org> <623db97b-5b65-88d2-0ff6-69abd8602b0d@tronnes.org> <20171005035350.GB28390@meghana-HP-Pavilion-Notebook> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: Date: Fri, 6 Oct 2017 20:04:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171005035350.GB28390@meghana-HP-Pavilion-Notebook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Den 05.10.2017 05.53, skrev Meghana Madhyastha: > On Tue, Oct 03, 2017 at 07:38:29PM +0200, Noralf Trønnes wrote: >> Den 03.10.2017 18.02, skrev Noralf Trønnes: >>> Den 03.10.2017 16.58, skrev Noralf Trønnes: >>>> Den 02.10.2017 10.13, skrev Jani Nikula: >>>>> On Mon, 02 Oct 2017, Daniel Vetter wrote: >>>>>> Also adding Jani, who looked at the backlight Kconfig mess in the >>>>>> past. >>>>> I've even sent patches to fix some of the dependency mess, but the >>>>> problem is social not technical. The problem is that people think >>>>> "select" is more convenient than "depends" because they can just enable >>>>> a config that way, while "depends" would require finding and enabling >>>>> all the dependencies before the menu option even shows up. >>>>> >>>>> I don't deny, that's annoying. But it's also abuse of select, see >>>>> Documentation/kbuild/kconfig-language.txt: >>>>> >>>>>    Note: >>>>>     select should be used with care. select will force >>>>>     a symbol to a value without visiting the dependencies. >>>>>     By abusing select you are able to select a symbol FOO even >>>>>     if FOO depends on BAR that is not set. >>>>>     In general use select only for non-visible symbols >>>>>     (no prompts anywhere) and for symbols with no dependencies. >>>>>     That will limit the usefulness but on the other hand avoid >>>>>     the illegal configurations all over. >>>>> >>>>> The real fix would be making finding and enabling dependencies >>>>> recursively more convenient, but I don't see that happening anytime >>>>> soon. >>>> If we don't select BACKLIGHT in drivers, we can end up with CONFIG_DRM=y >>>> and CONFIG_BACKLIGHT_CLASS_DEVICE=m. >>>> >>>> So we can either do: >>>> >>>> menuconfig DRM >>>>     depends on (BACKLIGHT_CLASS_DEVICE || BACKLIGHT_CLASS_DEVICE=n) >>>> >>> No, this was the thing that didn't work: >>> >>> drivers/gpu/drm/Kconfig:7:      symbol DRM depends on >>> BACKLIGHT_CLASS_DEVICE >>> drivers/video/backlight/Kconfig:158:    symbol BACKLIGHT_CLASS_DEVICE is >>> selected by DRM_RADEON >>> drivers/gpu/drm/Kconfig:164:    symbol DRM_RADEON depends on DRM >>> >> How about putting the dependency in the driver combined with IS_REACHABLE, >> but not in backlight.h as I first proposed, that won't work: >> >>  menuconfig DRM_TINYDRM >> -    select BACKLIGHT_LCD_SUPPORT >> -    select BACKLIGHT_CLASS_DEVICE >> +    depends on (BACKLIGHT_CLASS_DEVICE || BACKLIGHT_CLASS_DEVICE=n) >> >> >> struct backlight_device *drm_of_find_backlight(struct device *dev) >> { >>     struct backlight_device *backlight; >>     struct device_node *np; >> >>     if (!IS_REACHABLE(CONFIG_BACKLIGHT_CLASS_DEVICE)) >>         return NULL; >> [...] >> } >> >> But the IS_REACHABLE doesn't feel right. >> >> Maybe the problem is putting a function in DRM that really doesn't >> belong there. How about calling it of_find_backlight() instead and >> put it in backlight.[hc]? > Wouldn't it make more sense to put the function in DRM ? Because all of > the callers are located in DRM and so I'd think it makes more sense to > put it in DRM along with the other _of functions. I don't think it matters where the callers are, but the fact that the functions are all about backlight and nothing about DRM, except the error messages. I've made a suggestion in the last version where we have backlight maintainer attention. Noralf. >> Noralf. >> >>>> Or we can: >>>> >>>> -#ifdef CONFIG_OF >>>> +#if IS_ENABLED(CONFIG_OF) && >>>> IS_REACHABLE(CONFIG_BACKLIGHT_CLASS_DEVICE) >>>>  struct backlight_device *of_find_backlight_by_node(struct device_node >>>> *node); >>>>  #else >>>>  static inline struct backlight_device * > I have one question. Why isn't your previous solution a good solution? > i.e IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) which was part of v7 > >>>> Using the second one it won't be obvious to users why backlight doesn't >>>> work, >>>> they have after all enabled backlight (but as module and DRM builtin). >>>> >>>> So I suppose the first one is preferred. >>>> What effect will such a change have on an existing configuration where >>>> DRM=y and BACKLIGHT_CLASS_DEVICE=m? Will DRM become a module or will it >>>> be disabled? > Why would it be disabled in this case ? > > Thanks and regards, > Meghana > >>>> Noralf. >>>> >>>> _______________________________________________ >>>> dri-devel mailing list >>>> dri-devel@lists.freedesktop.org >>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel >>>> >>> _______________________________________________ >>> dri-devel mailing list >>> dri-devel@lists.freedesktop.org >>> https://lists.freedesktop.org/mailman/listinfo/dri-devel >>>