From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CF493FCB for ; Wed, 22 Sep 2021 18:01:20 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id m21so3493715pgu.13 for ; Wed, 22 Sep 2021 11:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qzRlQTkWXIbHOVaqQQ1pimD7uO9pukpfdV8XJIfvW+8=; b=MPOSuVrlv2DkfTnLAjfqgzr0KdSi+5RAQ8AN8B6q8AYvTH29jJuPSInmkv9G5an2K+ SefUrvOF5TTgNMDY+HkWm+cj2ZOo0Jnv4E+647lObAKQocs3gbuzRVStzdsTYLnUcDmv a1tgxSjbw7G5Ta7ANeyD+yU3TdyW0LSYCo/6wNfKUivfiQ1FeEYOpy/Lg3zdzHhQElpc YZ86VNPVWdCZV9gT+rAwFgkgehTkuOLu4KS3B47POdD+9Ed02gj82FxO3x1bLNmuAla7 XHr5Ymtpx/aiNyXoz6VaN1zj9j1LcVIVFf199TfMrWxzsmL4WvXJFqOvksQxpsGDRqgg JuXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qzRlQTkWXIbHOVaqQQ1pimD7uO9pukpfdV8XJIfvW+8=; b=DdiAf7UvBxh1otNoziZsvkITodRFZN8c7KoyxsS1UkzS3iN3D2ke+VUiE61HX6Gh/T 42XdeNdSo9Zl7LqYMslz5dmiH1tQD4Jrj/YHi3uXIQgNAHK+FDxzFn/0s8KIy8XH1UPl rvKahug93rWpTW4+wRZgqcc55fBuON6HaXjuGNTSIUylWE5vWE3mY9udtLIyANWxaw/Y F5w0Cp57UvGw0R7U39IUy4S7dUKtMRIVAjGFwMzfO5c7P9zjtIqclynSSy3j4lVqaaT4 OBUVCS2HMzPzUjPzd9W7L09bZjkjsE+TfglL/3+LrzY02WeUiB+75lGeBKNGSUZvGgKc aZKg== X-Gm-Message-State: AOAM5323slVjBCXTfGMCM1mutmCe4h/bnm891yZIIewQkc8jkU5YXbC+ 9ESja5nVMipa5M/OJ0qGljj/yAocx84= X-Google-Smtp-Source: ABdhPJyhBIjK0YNDGDZm6Z7GkU9V+OhRU2RDQyz6bKkcGadr94hV+6EGlL9T3KNj0sPgo0TG5NllUw== X-Received: by 2002:a63:f62:: with SMTP id 34mr164054pgp.159.1632333680419; Wed, 22 Sep 2021 11:01:20 -0700 (PDT) Received: from [192.168.86.235] (c-73-241-150-58.hsd1.ca.comcast.net. [73.241.150.58]) by smtp.gmail.com with ESMTPSA id o20sm3113201pfd.188.2021.09.22.11.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Sep 2021 11:01:20 -0700 (PDT) Subject: Re: [PATCH net-next 4/4] tcp: remove sk_{tr}x_skb_cache To: Paolo Abeni , netdev@vger.kernel.org Cc: "David S. Miller" , Jakub Kicinski , Mat Martineau , Eric Dumazet , mptcp@lists.linux.dev References: From: Eric Dumazet Message-ID: Date: Wed, 22 Sep 2021 11:01:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/22/21 10:26 AM, Paolo Abeni wrote: > From: Eric Dumazet > > This reverts the following patches : > > - commit 2e05fcae83c4 ("tcp: fix compile error if !CONFIG_SYSCTL") > - commit 4f661542a402 ("tcp: fix zerocopy and notsent_lowat issues") > - commit 472c2e07eef0 ("tcp: add one skb cache for tx") > - commit 8b27dae5a2e8 ("tcp: add one skb cache for rx") > > Having a cache of one skb (in each direction) per TCP socket is fragile, > since it can cause a significant increase of memory needs, > and not good enough for high speed flows anyway where more than one skb > is needed. > > We want instead to add a generic infrastructure, with more flexible > per-cpu caches, for alien NUMA nodes. > > Acked-by: Paolo Abeni > Acked-by: Mat Martineau > Signed-off-by: Eric Dumazet > --- Thanks Paolo for taking care of MPTCP bits.