From: Eduard Zingerman <eddyz87@gmail.com>
To: Cupertino Miranda <cupertino.miranda@oracle.com>, bpf@vger.kernel.org
Cc: Yonghong Song <yonghong.song@linux.dev>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
David Faust <david.faust@oracle.com>,
Jose Marchesi <jose.marchesi@oracle.com>,
Elena Zannoni <elena.zannoni@oracle.com>
Subject: Re: [PATCH bpf-next v3 1/6] bpf/verifier: replace calls to mark_reg_unknown.
Date: Thu, 25 Apr 2024 09:56:36 -0700 [thread overview]
Message-ID: <c493f6d93bc7bc8162bbf01dbb4ce5d0b7a7f084.camel@gmail.com> (raw)
In-Reply-To: <20240424224053.471771-2-cupertino.miranda@oracle.com>
On Wed, 2024-04-24 at 23:40 +0100, Cupertino Miranda wrote:
> In order to further simplify the code in adjust_scalar_min_max_vals all
> the calls to mark_reg_unknown are replaced by __mark_reg_unknown.
>
> Signed-off-by: Cupertino Miranda <cupertino.miranda@oracle.com>
> Cc: Yonghong Song <yonghong.song@linux.dev>
> Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
> Cc: David Faust <david.faust@oracle.com>
> Cc: Jose Marchesi <jose.marchesi@oracle.com>
> Cc: Elena Zannoni <elena.zannoni@oracle.com>
> ---
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Nit: if there would be a v4 for this series (hopefully won't),
please extend the commit message with something like below:
static void mark_reg_unknown(struct bpf_verifier_env *env,
struct bpf_reg_state *regs, u32 regno)
{
if (WARN_ON(regno >= MAX_BPF_REG)) {
... mark all regs not init ...
return;
}
__mark_reg_unknown(env, regs + regno);
}
The 'regno >= MAX_BPF_REG' does not apply to adjust_scalar_min_max_vals(),
because it is only called from the following stack:
- check_alu_op
- adjust_reg_min_max_vals
- adjust_scalar_min_max_vals
The check_alu_op() does check_reg_arg() which verifies that both src
and dst register numbers are within bounds.
[...]
next prev parent reply other threads:[~2024-04-25 16:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 22:40 [PATCH bpf-next v3 0/6] bpf/verifier: range computation improvements Cupertino Miranda
2024-04-24 22:40 ` [PATCH bpf-next v3 1/6] bpf/verifier: replace calls to mark_reg_unknown Cupertino Miranda
2024-04-25 16:56 ` Eduard Zingerman [this message]
2024-04-24 22:40 ` [PATCH bpf-next v3 2/6] bpf/verifier: refactor checks for range computation Cupertino Miranda
2024-04-25 18:49 ` Eduard Zingerman
2024-04-25 23:05 ` Andrii Nakryiko
2024-04-26 10:20 ` Cupertino Miranda
2024-04-26 16:11 ` Andrii Nakryiko
2024-04-26 16:17 ` Alexei Starovoitov
2024-04-27 22:51 ` Cupertino Miranda
2024-04-28 3:22 ` Andrii Nakryiko
2024-04-28 10:56 ` Cupertino Miranda
2024-04-24 22:40 ` [PATCH bpf-next v3 3/6] bpf/verifier: improve XOR and OR " Cupertino Miranda
2024-04-25 18:52 ` Eduard Zingerman
2024-04-24 22:40 ` [PATCH bpf-next v3 4/6] selftests/bpf: XOR and OR range computation tests Cupertino Miranda
2024-04-25 18:59 ` Eduard Zingerman
2024-04-25 23:17 ` Andrii Nakryiko
2024-04-24 22:40 ` [PATCH bpf-next v3 5/6] bpf/verifier: relax MUL range computation check Cupertino Miranda
2024-04-25 19:00 ` Eduard Zingerman
2024-04-25 23:24 ` Andrii Nakryiko
2024-04-24 22:40 ` [PATCH bpf-next v3 6/6] selftests/bpf: MUL range computation tests Cupertino Miranda
2024-04-25 19:02 ` Eduard Zingerman
2024-04-25 23:26 ` Andrii Nakryiko
2024-04-24 22:45 ` [PATCH bpf-next v3 0/6] bpf/verifier: range computation improvements Cupertino Miranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c493f6d93bc7bc8162bbf01dbb4ce5d0b7a7f084.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cupertino.miranda@oracle.com \
--cc=david.faust@oracle.com \
--cc=elena.zannoni@oracle.com \
--cc=jose.marchesi@oracle.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.