From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163161AbdAFWjM (ORCPT ); Fri, 6 Jan 2017 17:39:12 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:42180 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757711AbdAFV5a (ORCPT ); Fri, 6 Jan 2017 16:57:30 -0500 Subject: Re: [PATCH 2/3] xen: modify xenstore watch event interface To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170106150544.10836-1-jgross@suse.com> <20170106150544.10836-3-jgross@suse.com> Cc: konrad.wilk@oracle.com, roger.pau@citrix.com, wei.liu2@citrix.com, paul.durrant@citrix.com, netdev@vger.kernel.org From: Boris Ostrovsky Message-ID: Date: Fri, 6 Jan 2017 16:57:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170106150544.10836-3-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2017 10:05 AM, Juergen Gross wrote: > Today a Xenstore watch event is delivered via a callback function > declared as: > > void (*callback)(struct xenbus_watch *, > const char **vec, unsigned int len); > > As all watch events only ever come with two parameters (path and token) > changing the prototype to: > > void (*callback)(struct xenbus_watch *, > const char *path, const char *token); > > is the natural thing to do. > > Apply this change and adapt all users. > > Cc: konrad.wilk@oracle.com > Cc: roger.pau@citrix.com > Cc: wei.liu2@citrix.com > Cc: paul.durrant@citrix.com > Cc: netdev@vger.kernel.org > > Signed-off-by: Juergen Gross > > @@ -903,24 +902,24 @@ static int process_msg(void) > body[msg->hdr.len] = '\0'; > > if (msg->hdr.type == XS_WATCH_EVENT) { > - msg->u.watch.vec = split(body, msg->hdr.len, > - &msg->u.watch.vec_size); > - if (IS_ERR(msg->u.watch.vec)) { > - err = PTR_ERR(msg->u.watch.vec); > + if (count_strings(body, msg->hdr.len) != 2) { > + err = -EINVAL; xenbus_write_watch() returns -EILSEQ when this type of error is encountered so perhaps for we should return the same error here. Either way Reviewed-by: Boris Ostrovsky From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH 2/3] xen: modify xenstore watch event interface Date: Fri, 6 Jan 2017 16:57:31 -0500 Message-ID: References: <20170106150544.10836-1-jgross@suse.com> <20170106150544.10836-3-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: netdev@vger.kernel.org, roger.pau@citrix.com, wei.liu2@citrix.com, paul.durrant@citrix.com To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Return-path: In-Reply-To: <20170106150544.10836-3-jgross@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" List-Id: netdev.vger.kernel.org T24gMDEvMDYvMjAxNyAxMDowNSBBTSwgSnVlcmdlbiBHcm9zcyB3cm90ZToKPiBUb2RheSBhIFhl bnN0b3JlIHdhdGNoIGV2ZW50IGlzIGRlbGl2ZXJlZCB2aWEgYSBjYWxsYmFjayBmdW5jdGlvbgo+ IGRlY2xhcmVkIGFzOgo+Cj4gdm9pZCAoKmNhbGxiYWNrKShzdHJ1Y3QgeGVuYnVzX3dhdGNoICos Cj4gICAgICAgICAgICAgICAgICBjb25zdCBjaGFyICoqdmVjLCB1bnNpZ25lZCBpbnQgbGVuKTsK Pgo+IEFzIGFsbCB3YXRjaCBldmVudHMgb25seSBldmVyIGNvbWUgd2l0aCB0d28gcGFyYW1ldGVy cyAocGF0aCBhbmQgdG9rZW4pCj4gY2hhbmdpbmcgdGhlIHByb3RvdHlwZSB0bzoKPgo+IHZvaWQg KCpjYWxsYmFjaykoc3RydWN0IHhlbmJ1c193YXRjaCAqLAo+ICAgICAgICAgICAgICAgICAgY29u c3QgY2hhciAqcGF0aCwgY29uc3QgY2hhciAqdG9rZW4pOwo+Cj4gaXMgdGhlIG5hdHVyYWwgdGhp bmcgdG8gZG8uCj4KPiBBcHBseSB0aGlzIGNoYW5nZSBhbmQgYWRhcHQgYWxsIHVzZXJzLgo+Cj4g Q2M6IGtvbnJhZC53aWxrQG9yYWNsZS5jb20KPiBDYzogcm9nZXIucGF1QGNpdHJpeC5jb20KPiBD Yzogd2VpLmxpdTJAY2l0cml4LmNvbQo+IENjOiBwYXVsLmR1cnJhbnRAY2l0cml4LmNvbQo+IENj OiBuZXRkZXZAdmdlci5rZXJuZWwub3JnCj4KPiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3Nz IDxqZ3Jvc3NAc3VzZS5jb20+CgoKPiAgCj4gQEAgLTkwMywyNCArOTAyLDI0IEBAIHN0YXRpYyBp bnQgcHJvY2Vzc19tc2codm9pZCkKPiAgCWJvZHlbbXNnLT5oZHIubGVuXSA9ICdcMCc7Cj4gIAo+ ICAJaWYgKG1zZy0+aGRyLnR5cGUgPT0gWFNfV0FUQ0hfRVZFTlQpIHsKPiAtCQltc2ctPnUud2F0 Y2gudmVjID0gc3BsaXQoYm9keSwgbXNnLT5oZHIubGVuLAo+IC0JCQkJCSAmbXNnLT51LndhdGNo LnZlY19zaXplKTsKPiAtCQlpZiAoSVNfRVJSKG1zZy0+dS53YXRjaC52ZWMpKSB7Cj4gLQkJCWVy ciA9IFBUUl9FUlIobXNnLT51LndhdGNoLnZlYyk7Cj4gKwkJaWYgKGNvdW50X3N0cmluZ3MoYm9k eSwgbXNnLT5oZHIubGVuKSAhPSAyKSB7Cj4gKwkJCWVyciA9IC1FSU5WQUw7Cgp4ZW5idXNfd3Jp dGVfd2F0Y2goKSByZXR1cm5zIC1FSUxTRVEgd2hlbiB0aGlzIHR5cGUgb2YgZXJyb3IgaXMKZW5j b3VudGVyZWQgc28gcGVyaGFwcyBmb3Igd2Ugc2hvdWxkIHJldHVybiB0aGUgc2FtZSBlcnJvciBo ZXJlLgoKRWl0aGVyIHdheQoKUmV2aWV3ZWQtYnk6IEJvcmlzIE9zdHJvdnNreSA8Ym9yaXMub3N0 cm92c2t5QG9yYWNsZS5jb20+CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5v cmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=