* iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device()
@ 2019-10-18 7:00 ` Markus Elfring
0 siblings, 0 replies; 5+ messages in thread
From: Markus Elfring @ 2019-10-18 7:00 UTC (permalink / raw)
To: iommu, linux-arm-kernel, linux-rockchip, Heiko Stübner,
Jörg Rödel
Cc: LKML, kernel-janitors, Rafael J. Wysocki, Aditya Pakki,
Kangjie Lu, Navid Emamdoost, Stephen McCamant
Hello,
I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “rk_iommu_add_device” contains still
an unchecked call of the function “device_link_add”.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/rockchip-iommu.c?id=3ef845da3c3b180ddd386e228ac3228d84a522d3#n1075
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/iommu/rockchip-iommu.c#L1071
How do you think about to improve it?
Which error code would you like to return for a failed
device link addition at this place?
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
* iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device()
@ 2019-10-18 7:00 ` Markus Elfring
0 siblings, 0 replies; 5+ messages in thread
From: Markus Elfring @ 2019-10-18 7:00 UTC (permalink / raw)
To: iommu, linux-arm-kernel, linux-rockchip, Heiko Stübner,
Jörg Rödel
Cc: Rafael J. Wysocki, kernel-janitors, Stephen McCamant, Kangjie Lu,
LKML, Navid Emamdoost, Aditya Pakki
Hello,
I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “rk_iommu_add_device” contains still
an unchecked call of the function “device_link_add”.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/rockchip-iommu.c?id=3ef845da3c3b180ddd386e228ac3228d84a522d3#n1075
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/iommu/rockchip-iommu.c#L1071
How do you think about to improve it?
Which error code would you like to return for a failed
device link addition at this place?
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
* iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device()
@ 2019-10-18 7:00 ` Markus Elfring
0 siblings, 0 replies; 5+ messages in thread
From: Markus Elfring @ 2019-10-18 7:00 UTC (permalink / raw)
To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Heiko Stübner, Jörg Rödel
Cc: Rafael J. Wysocki, kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
Stephen McCamant, Kangjie Lu, LKML, Navid Emamdoost,
Aditya Pakki
Hello,
I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “rk_iommu_add_device” contains still
an unchecked call of the function “device_link_add”.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/rockchip-iommu.c?id=3ef845da3c3b180ddd386e228ac3228d84a522d3#n1075
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/iommu/rockchip-iommu.c#L1071
How do you think about to improve it?
Which error code would you like to return for a failed
device link addition at this place?
Regards,
Markus
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread
* iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device()
@ 2019-10-18 7:00 ` Markus Elfring
0 siblings, 0 replies; 5+ messages in thread
From: Markus Elfring @ 2019-10-18 7:00 UTC (permalink / raw)
To: iommu, linux-arm-kernel, linux-rockchip, Heiko Stübner,
Jörg Rödel
Cc: Rafael J. Wysocki, kernel-janitors, Stephen McCamant, Kangjie Lu,
LKML, Navid Emamdoost, Aditya Pakki
Hello,
I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “rk_iommu_add_device” contains still
an unchecked call of the function “device_link_add”.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/rockchip-iommu.c?id=3ef845da3c3b180ddd386e228ac3228d84a522d3#n1075
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/iommu/rockchip-iommu.c#L1071
How do you think about to improve it?
Which error code would you like to return for a failed
device link addition at this place?
Regards,
Markus
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 5+ messages in thread
* iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device()
@ 2019-10-18 7:00 ` Markus Elfring
0 siblings, 0 replies; 5+ messages in thread
From: Markus Elfring @ 2019-10-18 7:00 UTC (permalink / raw)
To: iommu, linux-arm-kernel, linux-rockchip, Heiko Stübner,
Jörg Rödel
Cc: Rafael J. Wysocki, kernel-janitors, Stephen McCamant, Kangjie Lu,
LKML, Navid Emamdoost, Aditya Pakki
Hello,
I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “rk_iommu_add_device” contains still
an unchecked call of the function “device_link_add”.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/rockchip-iommu.c?id=3ef845da3c3b180ddd386e228ac3228d84a522d3#n1075
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/iommu/rockchip-iommu.c#L1071
How do you think about to improve it?
Which error code would you like to return for a failed
device link addition at this place?
Regards,
Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-18 7:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18 7:00 iommu/rockchip: Checking a device_link_add() call in rk_iommu_add_device() Markus Elfring
2019-10-18 7:00 ` Markus Elfring
2019-10-18 7:00 ` Markus Elfring
2019-10-18 7:00 ` Markus Elfring
2019-10-18 7:00 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.