From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9A71C47082 for ; Mon, 31 May 2021 04:50:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C7BB61057 for ; Mon, 31 May 2021 04:50:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C7BB61057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ispras.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnZsz-0000FL-LI for qemu-devel@archiver.kernel.org; Mon, 31 May 2021 00:50:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnZpj-0004K0-9n for qemu-devel@nongnu.org; Mon, 31 May 2021 00:47:23 -0400 Received: from mail.ispras.ru ([83.149.199.84]:50286) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnZph-0003vU-H7 for qemu-devel@nongnu.org; Mon, 31 May 2021 00:47:23 -0400 Received: from [192.168.0.92] (unknown [62.118.138.151]) by mail.ispras.ru (Postfix) with ESMTPSA id 3CA004076B39; Mon, 31 May 2021 04:47:19 +0000 (UTC) Subject: Re: [PATCH] virtio: disable ioeventfd for record/replay To: qemu-devel@nongnu.org References: <162125678869.1252810.4317416444097392406.stgit@pasha-ThinkPad-X280> From: Pavel Dovgalyuk Message-ID: Date: Mon, 31 May 2021 07:47:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <162125678869.1252810.4317416444097392406.stgit@pasha-ThinkPad-X280> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=83.149.199.84; envelope-from=pavel.dovgalyuk@ispras.ru; helo=mail.ispras.ru X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.618, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, alex.bennee@linaro.org, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" ping On 17.05.2021 16:06, Pavel Dovgalyuk wrote: > virtio devices support separate iothreads waiting for > events from file descriptors. These are asynchronous > events that can't be recorded and replayed, therefore > this patch disables ioeventfd for all devices when > record or replay is enabled. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/s390x/virtio-ccw.c | 6 ++++++ > hw/virtio/virtio-mmio.c | 6 ++++++ > hw/virtio/virtio-pci.c | 6 ++++++ > 3 files changed, 18 insertions(+) > > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c > index 92b950e09a..bd8b9c5755 100644 > --- a/hw/s390x/virtio-ccw.c > +++ b/hw/s390x/virtio-ccw.c > @@ -31,6 +31,7 @@ > #include "trace.h" > #include "hw/s390x/css-bridge.h" > #include "hw/s390x/s390-virtio-ccw.h" > +#include "sysemu/replay.h" > > #define NR_CLASSIC_INDICATOR_BITS 64 > > @@ -769,6 +770,11 @@ static void virtio_ccw_device_realize(VirtioCcwDevice *dev, Error **errp) > dev->flags &= ~VIRTIO_CCW_FLAG_USE_IOEVENTFD; > } > > + /* fd-based ioevents can't be synchronized in record/replay */ > + if (replay_mode != REPLAY_MODE_NONE) { > + dev->flags &= ~VIRTIO_CCW_FLAG_USE_IOEVENTFD; > + } > + > if (k->realize) { > k->realize(dev, &err); > if (err) { > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > index 5952471b38..1af48a1b04 100644 > --- a/hw/virtio/virtio-mmio.c > +++ b/hw/virtio/virtio-mmio.c > @@ -29,6 +29,7 @@ > #include "qemu/host-utils.h" > #include "qemu/module.h" > #include "sysemu/kvm.h" > +#include "sysemu/replay.h" > #include "hw/virtio/virtio-mmio.h" > #include "qemu/error-report.h" > #include "qemu/log.h" > @@ -740,6 +741,11 @@ static void virtio_mmio_realizefn(DeviceState *d, Error **errp) > proxy->flags &= ~VIRTIO_IOMMIO_FLAG_USE_IOEVENTFD; > } > > + /* fd-based ioevents can't be synchronized in record/replay */ > + if (replay_mode != REPLAY_MODE_NONE) { > + proxy->flags &= ~VIRTIO_IOMMIO_FLAG_USE_IOEVENTFD; > + } > + > if (proxy->legacy) { > memory_region_init_io(&proxy->iomem, OBJECT(d), > &virtio_legacy_mem_ops, proxy, > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index b321604d9b..f1e105fa52 100644 > --- a/hw/virtio/virtio-pci.c > +++ b/hw/virtio/virtio-pci.c > @@ -37,6 +37,7 @@ > #include "qemu/range.h" > #include "hw/virtio/virtio-bus.h" > #include "qapi/visitor.h" > +#include "sysemu/replay.h" > > #define VIRTIO_PCI_REGION_SIZE(dev) VIRTIO_PCI_CONFIG_OFF(msix_present(dev)) > > @@ -1760,6 +1761,11 @@ static void virtio_pci_realize(PCIDevice *pci_dev, Error **errp) > proxy->flags &= ~VIRTIO_PCI_FLAG_USE_IOEVENTFD; > } > > + /* fd-based ioevents can't be synchronized in record/replay */ > + if (replay_mode != REPLAY_MODE_NONE) { > + proxy->flags &= ~VIRTIO_PCI_FLAG_USE_IOEVENTFD; > + } > + > /* > * virtio pci bar layout used by default. > * subclasses can re-arrange things if needed. >