From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3 05/11] net/e1000: parse n-tuple filter Date: Fri, 9 Jun 2017 13:29:34 +0100 Message-ID: References: <1496385391-12445-1-git-send-email-wei.zhao1@intel.com> <1496977908-2149-1-git-send-email-wei.zhao1@intel.com> <1496977908-2149-6-git-send-email-wei.zhao1@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: wenzhuo.lu@intel.com To: Wei Zhao , dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D36552BB9 for ; Fri, 9 Jun 2017 14:29:36 +0200 (CEST) In-Reply-To: <1496977908-2149-6-git-send-email-wei.zhao1@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/9/2017 4:11 AM, Wei Zhao wrote: > Add rule validate function and check if the rule is a > n-tuple rule, and get the n-tuple info. > > Signed-off-by: Wei Zhao Since you will be sending new version, can you also check checkpatch warnings [1] of this patch please? [1] MACRO_ARG_PRECEDENCE, SUSPECT_CODE_INDENT, TABSTOP, MISSING_EOF_NEWLINE Thanks, ferruh