All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrice CHOTARD <patrice.chotard@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] board: stm32: Fix stm32f746-disco boot
Date: Tue, 30 Jan 2018 08:04:11 +0000	[thread overview]
Message-ID: <c4ac8da1-7f34-1bdf-4c7a-91622446aee9@st.com> (raw)
In-Reply-To: <20180129202112.GI20149@bill-the-cat>

Hi Tom

On 01/29/2018 09:21 PM, Tom Rini wrote:
> On Mon, Jan 29, 2018 at 01:44:20PM +0100, patrice.chotard at st.com wrote:
> 
>> From: Patrice Chotard <patrice.chotard@st.com>
>>
>> Since 'commit af2f44267 ("fdc spl: use different BOARD_INIT MACRO for spl and tpl")'
>> board stm32f746-disco can't boot.
>>
>> The macro CONFIG_IS_ENABLED() can't evaluate the value of
>> CONFIG_SPL_BOARD_INIT as it was defined in include/configs/stm32f746-disco.h
>> without attributed value.
>>
>> Moving CONFIG_SPL_BOARD_INIT from stm32f746-disco.h to mach-stm32/Kconfig
>> fixes this issue.
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> 
> In the future, can you please use the Fixes tag, similar to the kernel?
> I've reworded this (and the other fix).

Yes, sorry to have forgot this process.

Thanks

Patrice

> 
> Applied to u-boot/master, thanks!
> 

      reply	other threads:[~2018-01-30  8:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29 12:44 [U-Boot] [PATCH] board: stm32: Fix stm32f746-disco boot patrice.chotard at st.com
2018-01-29 20:21 ` [U-Boot] " Tom Rini
2018-01-30  8:04   ` Patrice CHOTARD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4ac8da1-7f34-1bdf-4c7a-91622446aee9@st.com \
    --to=patrice.chotard@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.