All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wang <kevwa-5C7GfCeVMHo@public.gmane.org>
To: "Quan, Evan" <Evan.Quan-5C7GfCeVMHo@public.gmane.org>,
	"Yuan, Xiaojie" <Xiaojie.Yuan-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: "Wang, Kevin(Yang)" <Kevin1.Wang-5C7GfCeVMHo@public.gmane.org>,
	"Feng, Kenneth" <Kenneth.Feng-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amd/powerplay: fix 'unusedd variable' compile warning
Date: Thu, 5 Sep 2019 10:17:08 +0000	[thread overview]
Message-ID: <c4ae8e9f-86fa-12f2-8a1e-2f47278d1433@amd.com> (raw)
In-Reply-To: <MN2PR12MB3344F3C71E62E09B8FE203BBE4BB0-rweVpJHSKToDMgCC8P//OwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>

Reviewed-by: Kevin Wang <kevin1.wang@amd.com>

On 9/5/19 5:30 PM, Quan, Evan wrote:
> Reviewed-by: Evan Quan <evan.quan@amd.com>
>
>> -----Original Message-----
>> From: Yuan, Xiaojie <Xiaojie.Yuan@amd.com>
>> Sent: 2019年9月5日 17:26
>> To: amd-gfx@lists.freedesktop.org
>> Cc: Feng, Kenneth <Kenneth.Feng@amd.com>; Quan, Evan
>> <Evan.Quan@amd.com>; Wang, Kevin(Yang) <Kevin1.Wang@amd.com>;
>> Yuan, Xiaojie <Xiaojie.Yuan@amd.com>
>> Subject: [PATCH] drm/amd/powerplay: fix 'unusedd variable' compile
>> warning
>>
>> Signed-off-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
>> ---
>>   drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 2 --
>>   drivers/gpu/drm/amd/powerplay/navi10_ppt.c   | 2 --
>>   drivers/gpu/drm/amd/powerplay/renoir_ppt.c   | 2 --
>>   drivers/gpu/drm/amd/powerplay/vega20_ppt.c   | 2 --
>>   4 files changed, 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
>> b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
>> index 6e8eb0f94c8b..1c6732847185 100644
>> --- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
>> +++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
>> @@ -1931,7 +1931,5 @@ static const struct pptable_funcs
>> arcturus_ppt_funcs = {
>>
>>   void arcturus_set_ppt_funcs(struct smu_context *smu)  {
>> -	struct smu_table_context *smu_table = &smu->smu_table;
>> -
>>   	smu->ppt_funcs = &arcturus_ppt_funcs;
>>   }
>> diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
>> b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
>> index e3add8b59291..16634e657589 100644
>> --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
>> +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
>> @@ -1630,7 +1630,5 @@ static const struct pptable_funcs navi10_ppt_funcs
>> = {
>>
>>   void navi10_set_ppt_funcs(struct smu_context *smu)  {
>> -	struct smu_table_context *smu_table = &smu->smu_table;
>> -
>>   	smu->ppt_funcs = &navi10_ppt_funcs;
>>   }
>> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
>> b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
>> index b7fa8b158ff2..a5cf846b50d4 100644
>> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
>> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
>> @@ -257,8 +257,6 @@ static const struct pptable_funcs renoir_ppt_funcs = {
>>
>>   void renoir_set_ppt_funcs(struct smu_context *smu)  {
>> -	struct smu_table_context *smu_table = &smu->smu_table;
>> -
>>   	smu->ppt_funcs = &renoir_ppt_funcs;
>>   	smu->smc_if_version = SMU12_DRIVER_IF_VERSION;  } diff --git
>> a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
>> b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
>> index 18d1b432f719..929f61891dfa 100644
>> --- a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
>> +++ b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
>> @@ -3180,7 +3180,5 @@ static const struct pptable_funcs vega20_ppt_funcs
>> = {
>>
>>   void vega20_set_ppt_funcs(struct smu_context *smu)  {
>> -	struct smu_table_context *smu_table = &smu->smu_table;
>> -
>>   	smu->ppt_funcs = &vega20_ppt_funcs;
>>   }
>> --
>> 2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      parent reply	other threads:[~2019-09-05 10:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05  9:25 [PATCH] drm/amd/powerplay: fix 'unusedd variable' compile warning Yuan, Xiaojie
     [not found] ` <20190905092526.5962-1-xiaojie.yuan-5C7GfCeVMHo@public.gmane.org>
2019-09-05  9:30   ` Quan, Evan
     [not found]     ` <MN2PR12MB3344F3C71E62E09B8FE203BBE4BB0-rweVpJHSKToDMgCC8P//OwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-09-05 10:17       ` Kevin Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4ae8e9f-86fa-12f2-8a1e-2f47278d1433@amd.com \
    --to=kevwa-5c7gfcevmho@public.gmane.org \
    --cc=Evan.Quan-5C7GfCeVMHo@public.gmane.org \
    --cc=Kenneth.Feng-5C7GfCeVMHo@public.gmane.org \
    --cc=Kevin1.Wang-5C7GfCeVMHo@public.gmane.org \
    --cc=Xiaojie.Yuan-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.