From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99A8BC2D0A3 for ; Fri, 6 Nov 2020 21:07:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FE5820B1F for ; Fri, 6 Nov 2020 21:07:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604696846; bh=JXg0lmC2R+uKjF0oGYWjltw0eJE/5o7We79L8QFFolo=; h=Subject:From:To:Date:In-Reply-To:References:List-ID:From; b=vQW1lMfY3YWAmuc5+MnZU11RUILQZSqMe6YRHg/KocVDcWEL8i1ZkTjQFOhc+TQgj i9M8UIQ4GpYyetwDgEtGypkK6WsG2Mz2R6QTOwcba1sPqxm64V5u2AMxY2leRFDhiq LVNEk8B35MFqVEbNF+No8SkWDmT81EVVIBlivrmI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728552AbgKFVHZ (ORCPT ); Fri, 6 Nov 2020 16:07:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:45576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728408AbgKFVHZ (ORCPT ); Fri, 6 Nov 2020 16:07:25 -0500 Received: from sx1.lan (c-24-6-56-119.hsd1.ca.comcast.net [24.6.56.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 387B12087E; Fri, 6 Nov 2020 21:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604696844; bh=JXg0lmC2R+uKjF0oGYWjltw0eJE/5o7We79L8QFFolo=; h=Subject:From:To:Date:In-Reply-To:References:From; b=tYIqBpLIMXsHvOwTe6Df/GmcIScUr4s63MYPmsYAc7dEhl+PNHKVJfMwXAPXqf+bV pLP0IQF6jAWaWQE/p9zPxuQJ9+UK4MHgcHs3m8Fi096pAvcEldgezBESVXzHfQ1pd1 YOOjvJxGJ4llx5Vuui/btNo5Rl5ALNEJVY4f3TMg= Message-ID: Subject: Re: [PATCH v2 net-next 3/8] ionic: add lif quiesce From: Saeed Mahameed To: Shannon Nelson , netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org Date: Fri, 06 Nov 2020 13:07:23 -0800 In-Reply-To: <20201106001220.68130-4-snelson@pensando.io> References: <20201106001220.68130-1-snelson@pensando.io> <20201106001220.68130-4-snelson@pensando.io> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2020-11-05 at 16:12 -0800, Shannon Nelson wrote: > After the queues are stopped, expressly quiesce the lif. > This assures that even if the queues were in an odd state, > the firmware will close up everything cleanly. > > Signed-off-by: Shannon Nelson > --- > .../net/ethernet/pensando/ionic/ionic_lif.c | 24 > +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c > b/drivers/net/ethernet/pensando/ionic/ionic_lif.c > index 519d544821af..990bd9ce93c2 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c > @@ -1625,6 +1625,28 @@ static void ionic_lif_rss_deinit(struct > ionic_lif *lif) > ionic_lif_rss_config(lif, 0x0, NULL, NULL); > } > > +static int ionic_lif_quiesce(struct ionic_lif *lif) Sorry maybe i wasn't clear before, i mean make this function return a void static void ionic_lif_quiesce(struct ionic_lif *lif) > + (void)ionic_lif_quiesce(lif); I didn't mean to typecast the return value here :)