All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aya Levin <ayal@nvidia.com>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Saeed Mahameed <saeedm@nvidia.com>
Cc: Tariq Toukan <tariqt@nvidia.com>,
	Moshe Shemesh <moshe@nvidia.com>,
	"Maria Pasechnik" <mariap@nvidia.com>
Subject: ethtool features: tx-udp_tnl-csum-segmentation and tx-udp_tnl-segmentation
Date: Thu, 29 Apr 2021 12:16:55 +0300	[thread overview]
Message-ID: <c4cd5df8-2a16-6c31-8a13-4d36b51ba13b@nvidia.com> (raw)

Hi,

I see a strange behavior when toggling feature flags:
(1) tx-udp_tnl-csum-segmentation
(2) tx-udp_tnl-segmentation

I had a guess that tx-udp_tnl-segmentation is responsible for 
segmentation of inner packets (SKB encapsulation + GSO) while 
tx-udp_tnl-csum-segmentation is responsible for checksum of the inner 
packet (SKB encapsulation  + ip_summed == CHECKSUM_PARTIAL). But testing 
proved me wrong.
What I see is that tx-udp_tnl-csum-segmentation controls TSO on inner, 
while tx-udp_tnl-segmentation has no effect - none of them controls the 
inner csum (ip_summed == CHECKSUM_PARTIAL always).

I looked for answers in documentation 
(Documentation/networking/vxlan.rst), with no luck.

Is the above behavior expected?
What is the role of each feature flag?
More specifically: Why are there 2? What is the difference between them?

Regards,
Aya

             reply	other threads:[~2021-04-29  9:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29  9:16 Aya Levin [this message]
2021-04-29 14:49 ` ethtool features: tx-udp_tnl-csum-segmentation and tx-udp_tnl-segmentation Edward Cree
2021-05-10 15:44   ` Aya Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4cd5df8-2a16-6c31-8a13-4d36b51ba13b@nvidia.com \
    --to=ayal@nvidia.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=mariap@nvidia.com \
    --cc=moshe@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.