From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932202AbcFTXpW (ORCPT ); Mon, 20 Jun 2016 19:45:22 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33040 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752576AbcFTXpM (ORCPT ); Mon, 20 Jun 2016 19:45:12 -0400 Reply-To: chris@lapa.com.au Subject: Re: [PATCH v3 1/7] max8903: adds documentation for device tree bindings. References: <1464849897-21527-3-git-send-email-chris@lapa.com.au> <1466139626-51434-2-git-send-email-chris@lapa.com.au> <20160620132247.GA30380@rob-hp-laptop> To: Rob Herring Cc: k.kozlowski@samsung.com, dwmw2@infradead.org, dbaryshkov@gmail.com, sre@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Chris Lapa Message-ID: Date: Tue, 21 Jun 2016 09:43:47 +1000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160620132247.GA30380@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/06/2016 11:22 PM, Rob Herring wrote: > On Fri, Jun 17, 2016 at 03:00:20PM +1000, Chris Lapa wrote: >> From: Chris Lapa >> >> Signed-off-by: Chris Lapa >> --- >> .../devicetree/bindings/power/max8903-charger.txt | 25 ++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/max8903-charger.txt >> >> diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt b/Documentation/devicetree/bindings/power/max8903-charger.txt >> new file mode 100644 >> index 0000000..aea1dd2a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/max8903-charger.txt >> @@ -0,0 +1,25 @@ >> +Maxim Semiconductor MAX8903 Battery Charger bindings >> + >> +Required properties: >> +- compatible: "maxim,max8903-charger" for MAX8903 Battery Charger > > Drop "charger" as that is implied by the chip. Just for clarification, you mean: compatible: "maxim,max8903" for MAX8903 Battery Charger Thanks, Chris > >> +- dok-gpios: Valid DC power has been detected, optional if uok-gpios is provided >> +- uok-gpios: Valid USB power has been detected, optional if dok-gpios is provided >> + >> +Optional properties: >> +- cen-gpios: Charge enable pin >> +- chg-gpios: Charger status pin >> +- flt-gpios: Fault pin >> +- dcm-gpios: Current limit mode setting (DC or USB) >> +- usus-gpios: USB suspend pin > > Need to state direction and active state for all of these. >