All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yogesh Siraswar" <yogeshs@ti.com>
To: Denys Dmytriyenko <denis@denix.org>, <meta-ti@lists.yoctoproject.org>
Subject: Re: [meta-ti] [PATCH] mpm-transport: Do not use append with += operator
Date: Mon, 15 Nov 2021 14:52:31 -0600	[thread overview]
Message-ID: <c4da11b7-79b6-e63d-e318-01908ea85432@ti.com> (raw)
In-Reply-To: <20211115202445.GV10132@denix.org>



On 11/15/2021 2:24 PM, Denys Dmytriyenko wrote:
> On Thu, Nov 04, 2021 at 01:54:16PM -0400, Denys Dmytriyenko wrote:
>> On Thu, Nov 04, 2021 at 10:29:34AM -0700, Khem Raj wrote:
>>> this is undefined behaviour, mant times devs used them together to get
>>> the missing space at the beginning of string which append/prepend needs
>>> but thats not intended behaviour
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>
>> Acked-by: Denys Dmytriyenko <denys@konsulko.com>
> 
> Yogesh,
> 
> I don't believe this patch has made it into master...

Yes, I have not sync master. Is this applicable for dunfell?

> 
> 
>>> ---
>>>   recipes-ti/mpm-transport/mpm-transport_git.bb | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/recipes-ti/mpm-transport/mpm-transport_git.bb b/recipes-ti/mpm-transport/mpm-transport_git.bb
>>> index 38aefc24..3b80af34 100644
>>> --- a/recipes-ti/mpm-transport/mpm-transport_git.bb
>>> +++ b/recipes-ti/mpm-transport/mpm-transport_git.bb
>>> @@ -21,8 +21,8 @@ PR = "r0"
>>>   
>>>   CC += "-fcommon"
>>>   EXTRA_OEMAKE = "PDK_INSTALL_PATH=${STAGING_INCDIR}"
>>> -EXTRA_OEMAKE:append:k2hk += "HYPLNK_TRANSPORT=true SRIO_TRANSPORT=true"
>>> -EXTRA_OEMAKE:append:k2e += "HYPLNK_TRANSPORT=true"
>>> +EXTRA_OEMAKE:append:k2hk = " HYPLNK_TRANSPORT=true SRIO_TRANSPORT=true"
>>> +EXTRA_OEMAKE:append:k2e = " HYPLNK_TRANSPORT=true"
>>>   INSANE_SKIP:${PN} += "ldflags"
>>>   
>>>   S = "${WORKDIR}/git"
>>> -- 
>>> 2.33.1
>>>
> 
> 
> 
> 
> 

  reply	other threads:[~2021-11-15 20:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 17:29 [PATCH] mpm-transport: Do not use append with += operator Khem Raj
2021-11-04 17:54 ` [meta-ti] " Denys Dmytriyenko
     [not found] ` <16B46967FE386BDB.15444@lists.yoctoproject.org>
2021-11-15 20:24   ` Denys Dmytriyenko
2021-11-15 20:52     ` Yogesh Siraswar [this message]
2021-11-15 23:09       ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4da11b7-79b6-e63d-e318-01908ea85432@ti.com \
    --to=yogeshs@ti.com \
    --cc=denis@denix.org \
    --cc=meta-ti@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.