All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <a.hajda@samsung.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 00/11] drm/fb-helper: Deferred setup support
Date: Thu, 30 Mar 2017 12:21:26 +0200	[thread overview]
Message-ID: <c4e64a13-032c-8e50-72fd-5e1f1a71251d@samsung.com> (raw)
In-Reply-To: <20170329144401.1804-1-thierry.reding@gmail.com>

Hi Thierry,

On 29.03.2017 16:43, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This set of patches adds support for deferring FB helper setup, which is
> useful to obtain a sane configuration even when no outputs are available
> during probe.
>
> One example is HDMI, where fbdev will currently fallback to a 1024x786
> resolution if no monitor is connected, and will then forever stay that
> way. With these patches, the FB helpers will take note that it doesn't
> make sense to setup fbdev yet and will defer until a monitor is
> connected, at which point the preferred mode will be selected.

I have tested it on Exynos (TM2), generally it works but I have observed
two things:
1. Now fbdev appears on only one connected device (in my case, only on
DSI/Panel, not on HDMI/MHL/TV), I do not know if this change is intended
but I have not seen it in commit message.
2. "echo off >/sys/class/drm/card0-*/status" does not work anymore, ie
it succeeds, subsequent calls to modetest shows that connector is
disabled, but panel/TV still displays the image.

Regards
Andrzej

>
> Thierry
>
> Changes in v4:
> - use fb_conn for variables of type struct drm_fb_helper_connector *
>   for consistency
> - make top-level FB helper lock more robust
> - improve kerneldoc
>
> Changes in v3:
> - fix kerneldoc for top-level FB helper lock
> - drop some patches that no longer apply
> - add Tested-by from John Stultz
> - add cleanup patches
>
> Changes in v2:
> - now with locking
>
> Thierry Reding (11):
>   drm/fb-helper: Cleanup checkpatch warnings
>   drm/fb-helper: Reshuffle code for subsequent patches
>   drm/fb-helper: Improve code readability
>   drm/fb-helper: Push down modeset lock into FB helpers
>   drm/fb-helper: Add top-level lock
>   drm/fb-helper: Make top-level lock more robust
>   drm/fb-helper: Support deferred setup
>   drm/exynos: Remove custom FB helper deferred setup
>   drm/hisilicon: Remove custom FB helper deferred setup
>   drm/atmel-hlcdc: Remove unnecessary NULL check
>   drm/rockchip: Remove unnecessary NULL check
>
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c    |   3 +-
>  drivers/gpu/drm/drm_fb_helper.c                 | 376 +++++++++++++++++-------
>  drivers/gpu/drm/exynos/exynos_drm_drv.c         |   6 +-
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c       |  23 --
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c |  21 +-
>  drivers/gpu/drm/i915/intel_dp_mst.c             |   3 -
>  drivers/gpu/drm/radeon/radeon_dp_mst.c          |   7 -
>  drivers/gpu/drm/rockchip/rockchip_drm_fb.c      |   4 +-
>  include/drm/drm_fb_helper.h                     |  35 +++
>  9 files changed, 316 insertions(+), 162 deletions(-)
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2017-03-30 10:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170329144416epcas3p471b0fac16a5bb6b51a3abf012c9e9e92@epcas3p4.samsung.com>
2017-03-29 14:43 ` [PATCH v4 00/11] drm/fb-helper: Deferred setup support Thierry Reding
2017-03-29 14:43   ` [PATCH v4 01/11] drm/fb-helper: Cleanup checkpatch warnings Thierry Reding
2017-03-29 14:43   ` [PATCH v4 02/11] drm/fb-helper: Reshuffle code for subsequent patches Thierry Reding
2017-03-29 14:43   ` [PATCH v4 03/11] drm/fb-helper: Improve code readability Thierry Reding
2017-03-29 14:43   ` [PATCH v4 04/11] drm/fb-helper: Push down modeset lock into FB helpers Thierry Reding
2017-03-31 18:28     ` Daniel Vetter
2017-03-29 14:43   ` [PATCH v4 05/11] drm/fb-helper: Add top-level lock Thierry Reding
2017-03-29 14:43   ` [PATCH v4 06/11] drm/fb-helper: Make top-level lock more robust Thierry Reding
2017-03-29 14:51     ` Thierry Reding
2017-04-03  8:40     ` [Intel-gfx] " Daniel Vetter
2017-03-29 14:43   ` [PATCH v4 07/11] drm/fb-helper: Support deferred setup Thierry Reding
2017-03-29 14:43   ` [PATCH v4 08/11] drm/exynos: Remove custom FB helper " Thierry Reding
2017-03-29 17:50     ` Daniel Vetter
2017-03-29 14:43   ` [PATCH v4 09/11] drm/hisilicon: " Thierry Reding
2017-03-29 14:44   ` [PATCH v4 10/11] drm/atmel-hlcdc: Remove unnecessary NULL check Thierry Reding
2017-03-29 14:44   ` [PATCH v4 11/11] drm/rockchip: " Thierry Reding
2017-06-21 13:39     ` Daniel Vetter
2017-03-29 15:04   ` ✗ Fi.CI.BAT: warning for drm/fb-helper: Deferred setup support (rev3) Patchwork
2017-03-30 10:21   ` Andrzej Hajda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4e64a13-032c-8e50-72fd-5e1f1a71251d@samsung.com \
    --to=a.hajda@samsung.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.