From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0B17C432BE for ; Tue, 31 Aug 2021 15:27:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B9C061051 for ; Tue, 31 Aug 2021 15:27:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239144AbhHaP2m (ORCPT ); Tue, 31 Aug 2021 11:28:42 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:29636 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239108AbhHaP2m (ORCPT ); Tue, 31 Aug 2021 11:28:42 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1630423667; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=scuK1ehy5HtupVmZPQITLXq3WGLemHWuLYY7u5ziWo0=; b=bPRwaN5DWcvFLRfA4h5DqxUzoz9iidxqVESRwcWsksmnJCi8gB2DxPmvGQ01hl0sCFCrbaCK eTWwWzXpqSfAyQEpHxbkk6RMIMB4gRvCnsfctW0tDDB8Hj0Phl8hiBFptL21wWVzfWBTATj/ sdBaCe0/VzXuGkqDHw+jcv6tilU= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 612e4a5de0fcecca190b561e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 31 Aug 2021 15:27:25 GMT Sender: rajpat=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D3E1DC43460; Tue, 31 Aug 2021 15:27:24 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rajpat) by smtp.codeaurora.org (Postfix) with ESMTPSA id C044FC4338F; Tue, 31 Aug 2021 15:27:22 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 31 Aug 2021 20:57:22 +0530 From: rajpat@codeaurora.org To: Matthias Kaehlcke Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, rnayak@codeaurora.org, saiprakash.ranjan@codeaurora.org, msavaliy@qti.qualcomm.com, skakit@codeaurora.org, sboyd@kernel.org Subject: Re: [PATCH V6 4/7] arm64: dts: sc7280: Update QUPv3 UART5 DT node In-Reply-To: References: <1629983731-10595-1-git-send-email-rajpat@codeaurora.org> <1629983731-10595-5-git-send-email-rajpat@codeaurora.org> Message-ID: X-Sender: rajpat@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-08-27 02:31, Matthias Kaehlcke wrote: > On Thu, Aug 26, 2021 at 06:45:28PM +0530, Rajesh Patil wrote: >> From: Roja Rani Yarubandi >> >> Update the compatible string as "qcom,geni-uart". >> Add interconnects and power-domains. Split the pinctrl >> functions and correct the gpio pins. > > You could say that uart5 was formerly treated as special > (dedicated debug uart) and that the change removes this > specialness and makes it look like any other UART. > Okay >> split the pinctrl functions to match with SoC dt > > The message should say that this is about the 7280-idp > >> Signed-off-by: Roja Rani Yarubandi >> Signed-off-by: Rajesh Patil > > The change itself looks good to me, the above are only nits to improve > the commit message, so: > > Reviewed-by: Matthias Kaehlcke