From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fY9Rb-0002WL-Rf for qemu-devel@nongnu.org; Wed, 27 Jun 2018 08:21:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fY9RY-00061Z-Hz for qemu-devel@nongnu.org; Wed, 27 Jun 2018 08:21:07 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:33624 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fY9RY-00060R-CO for qemu-devel@nongnu.org; Wed, 27 Jun 2018 08:21:04 -0400 References: <20180625131253.11218-1-kraxel@redhat.com> <20180625131253.11218-2-kraxel@redhat.com> <6ad67e44-b002-1cd7-cfd1-2d98ebde1a7e@redhat.com> <20180627065126.mwzdxshr3njzok7n@sirius.home.kraxel.org> From: Eric Blake Message-ID: Date: Wed, 27 Jun 2018 07:21:00 -0500 MIME-Version: 1.0 In-Reply-To: <20180627065126.mwzdxshr3njzok7n@sirius.home.kraxel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , Max Reitz Cc: Martin Schrodt , qemu-devel@nongnu.org, Paolo Bonzini On 06/27/2018 01:51 AM, Gerd Hoffmann wrote: >>> Signed-off-by: Martin Schrodt >>> Signed-off-by: Gerd Hoffmann >>> Message-id: 20180622111200.30561-2-kraxel@redhat.com >>> Message-id: 20171015184033.2951-3-martin@schrodt.org >>> >>> [ kraxel: keep old code for compatibility with older qemu versions, >>> add property to switch code paths at runtime ] >>> [ kraxel: new code is disabled by default, use-timer=on enables it ] >>> >>> Signed-off-by: Gerd Hoffmann >>> --- >>> hw/audio/hda-codec.c | 263 ++++++++++++++++++++++++++++++++++++++++++++++----- >>> hw/audio/intel-hda.c | 7 -- >>> 2 files changed, 237 insertions(+), 33 deletions(-) >> >> This patch breaks compilation on clang with -m32 for me, because I >> apparently I don't have 64 bit atomics there. Should there be >> CONFIG_ATOMIC64 guards and handling for when that isn't defined? > > Given the code runs under big qemu lock anyway the atomics are not > needed, so we could drop just them. I left them in nevertheless because > > (a) we might want try run the code in a thread instead of using a timer, and > (b) I was too lazy to rewrite the code to drop the atomics. > > I'd prefer to keep option (a) ... what about option (c): figure out how to use util/stats64.c which is a way of getting 64-bit atomic math even on 32-bit hosts? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org