From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF5C5C11D34 for ; Mon, 24 Feb 2020 17:22:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1709218AC for ; Mon, 24 Feb 2020 17:22:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728048AbgBXRWJ (ORCPT ); Mon, 24 Feb 2020 12:22:09 -0500 Received: from skedge03.snt-world.com ([91.208.41.68]:43130 "EHLO skedge03.snt-world.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727673AbgBXRWI (ORCPT ); Mon, 24 Feb 2020 12:22:08 -0500 Received: from sntmail11s.snt-is.com (unknown [10.203.32.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by skedge03.snt-world.com (Postfix) with ESMTPS id 4DC0E67A7D5; Mon, 24 Feb 2020 18:22:05 +0100 (CET) Received: from sntmail12r.snt-is.com (10.203.32.182) by sntmail11s.snt-is.com (10.203.32.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 24 Feb 2020 18:22:04 +0100 Received: from sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305]) by sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305%3]) with mapi id 15.01.1913.005; Mon, 24 Feb 2020 18:22:04 +0100 From: Schrempf Frieder To: Dan Williams , Fabio Estevam , Linus Walleij , "NXP Linux Team" , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , "Vinod Koul" CC: "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] dma: imx-sdma: Fix the event id check to include RX event for UART6 Thread-Topic: [PATCH] dma: imx-sdma: Fix the event id check to include RX event for UART6 Thread-Index: AQHV6zYWVmd7WYLi20CvYMo8u04O/6gqhq0A Date: Mon, 24 Feb 2020 17:22:04 +0000 Message-ID: References: <20200224171531.22204-1-frieder.schrempf@kontron.de> In-Reply-To: <20200224171531.22204-1-frieder.schrempf@kontron.de> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.9.193] x-c2processedorg: 51b406b7-48a2-4d03-b652-521f56ac89f3 Content-Type: text/plain; charset="utf-8" Content-ID: <26B40BE5F01BA54ABC9C4ADADFF6A1D6@snt-world.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-SnT-MailScanner-Information: Please contact the ISP for more information X-SnT-MailScanner-ID: 4DC0E67A7D5.AFBD6 X-SnT-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details X-SnT-MailScanner-SpamCheck: X-SnT-MailScanner-From: frieder.schrempf@kontron.de X-SnT-MailScanner-To: dan.j.williams@intel.com, dmaengine@vger.kernel.org, festevam@gmail.com, kernel@pengutronix.de, linus.ml.walleij@gmail.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org, vkoul@kernel.org Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org T24gMjQuMDIuMjAgMTg6MTYsIFNjaHJlbXBmIEZyaWVkZXIgd3JvdGU6DQo+IEZyb206IEZyaWVk ZXIgU2NocmVtcGYgPGZyaWVkZXIuc2NocmVtcGZAa29udHJvbi5kZT4NCj4gDQo+IE9uIGkuTVg2 IHRoZSBETUEgZXZlbnQgZm9yIHRoZSBSWCBjaGFubmVsIG9mIFVBUlQ2IGlzICcwJy4gVG8gZml4 DQo+IHRoZSBicm9rZW4gRE1BIHN1cHBvcnQgZm9yIFVBUlQ2LCB3ZSBjaGFuZ2UgdGhlIGNoZWNr IGZvciBldmVudF9pZDANCj4gdG8gaW5jbHVkZSAnMCcgYXMgYSB2YWxpZCBpZC4NCj4gDQo+IEZp eGVzOiAxZWMxZTgyZjI1MTAgKCJkbWFlbmdpbmU6IEFkZCBGcmVlc2NhbGUgaS5NWCBTRE1BIHN1 cHBvcnQiKQ0KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsDQoNClNvcnJ5LCBJIG1lc3NlZCB1cCB0 aGUgc3RhYmxlIHRhZy4gV2lsbCBzZW5kIGFnYWluLg0KDQo+IFNpZ25lZC1vZmYtYnk6IEZyaWVk ZXIgU2NocmVtcGYgPGZyaWVkZXIuc2NocmVtcGZAa29udHJvbi5kZT4NCj4gLS0tDQo+ICAgZHJp dmVycy9kbWEvaW14LXNkbWEuYyB8IDQgKystLQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEv aW14LXNkbWEuYyBiL2RyaXZlcnMvZG1hL2lteC1zZG1hLmMNCj4gaW5kZXggMDY2YjIxYTMyMjMy Li4zZDRhYWM5N2IxZmMgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZG1hL2lteC1zZG1hLmMNCj4g KysrIGIvZHJpdmVycy9kbWEvaW14LXNkbWEuYw0KPiBAQCAtMTMzMSw3ICsxMzMxLDcgQEAgc3Rh dGljIHZvaWQgc2RtYV9mcmVlX2NoYW5fcmVzb3VyY2VzKHN0cnVjdCBkbWFfY2hhbiAqY2hhbikN Cj4gICANCj4gICAJc2RtYV9jaGFubmVsX3N5bmNocm9uaXplKGNoYW4pOw0KPiAgIA0KPiAtCWlm IChzZG1hYy0+ZXZlbnRfaWQwKQ0KPiArCWlmIChzZG1hYy0+ZXZlbnRfaWQwID49IDApDQo+ICAg CQlzZG1hX2V2ZW50X2Rpc2FibGUoc2RtYWMsIHNkbWFjLT5ldmVudF9pZDApOw0KPiAgIAlpZiAo c2RtYWMtPmV2ZW50X2lkMSkNCj4gICAJCXNkbWFfZXZlbnRfZGlzYWJsZShzZG1hYywgc2RtYWMt PmV2ZW50X2lkMSk7DQo+IEBAIC0xNjMxLDcgKzE2MzEsNyBAQCBzdGF0aWMgaW50IHNkbWFfY29u ZmlnKHN0cnVjdCBkbWFfY2hhbiAqY2hhbiwNCj4gICAJbWVtY3B5KCZzZG1hYy0+c2xhdmVfY29u ZmlnLCBkbWFlbmdpbmVfY2ZnLCBzaXplb2YoKmRtYWVuZ2luZV9jZmcpKTsNCj4gICANCj4gICAJ LyogU2V0IEVOQkxuIGVhcmxpZXIgdG8gbWFrZSBzdXJlIGRtYSByZXF1ZXN0IHRyaWdnZXJlZCBh ZnRlciB0aGF0ICovDQo+IC0JaWYgKHNkbWFjLT5ldmVudF9pZDApIHsNCj4gKwlpZiAoc2RtYWMt PmV2ZW50X2lkMCA+PSAwKSB7DQo+ICAgCQlpZiAoc2RtYWMtPmV2ZW50X2lkMCA+PSBzZG1hYy0+ c2RtYS0+ZHJ2ZGF0YS0+bnVtX2V2ZW50cykNCj4gICAJCQlyZXR1cm4gLUVJTlZBTDsNCj4gICAJ CXNkbWFfZXZlbnRfZW5hYmxlKHNkbWFjLCBzZG1hYy0+ZXZlbnRfaWQwKTsNCj4g From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8444C11D32 for ; Mon, 24 Feb 2020 17:22:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC76B20836 for ; Mon, 24 Feb 2020 17:22:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gPhGRwN3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC76B20836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iQP20ry6IEmztadOcZBUK0FbfyN+UozlWRblWGbQ3D4=; b=gPhGRwN3kwkm5W wQETpIFe55owus1tcnubH1bUD1uG9Ln2C8aKXccTYwXSPPOrIVVQCOH599fzCTosW2xxiACCVPGVS gDNafQqtoq7HBYDMumKmDH+pGytx0LL54ACb/2Yz/lF03xmOhBn7C5C314tp9bIMe8zGH+sE5NLAb pzyA4j9rpF1RCmmkEm/wW9Zf3S5Rf9OGVzNAclyFfmrW7LYPgEDxfHXiOBxkHQ9Al4cYhnZTQjaj9 jbEdPh0S402Ws9+PkB98H7eRxTkD3ySmgRalFS5ZJDOlaYtd0Cx3dINgmRBMD4auoK/nUUHKlA8Eb Ph3DsWaXidIGTM1vMCtQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6HQo-00077O-Cj; Mon, 24 Feb 2020 17:22:10 +0000 Received: from skedge03.snt-world.com ([91.208.41.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6HQl-00076f-Hz for linux-arm-kernel@lists.infradead.org; Mon, 24 Feb 2020 17:22:09 +0000 Received: from sntmail11s.snt-is.com (unknown [10.203.32.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by skedge03.snt-world.com (Postfix) with ESMTPS id 4DC0E67A7D5; Mon, 24 Feb 2020 18:22:05 +0100 (CET) Received: from sntmail12r.snt-is.com (10.203.32.182) by sntmail11s.snt-is.com (10.203.32.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 24 Feb 2020 18:22:04 +0100 Received: from sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305]) by sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305%3]) with mapi id 15.01.1913.005; Mon, 24 Feb 2020 18:22:04 +0100 From: Schrempf Frieder To: Dan Williams , Fabio Estevam , Linus Walleij , "NXP Linux Team" , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , "Vinod Koul" Subject: Re: [PATCH] dma: imx-sdma: Fix the event id check to include RX event for UART6 Thread-Topic: [PATCH] dma: imx-sdma: Fix the event id check to include RX event for UART6 Thread-Index: AQHV6zYWVmd7WYLi20CvYMo8u04O/6gqhq0A Date: Mon, 24 Feb 2020 17:22:04 +0000 Message-ID: References: <20200224171531.22204-1-frieder.schrempf@kontron.de> In-Reply-To: <20200224171531.22204-1-frieder.schrempf@kontron.de> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.9.193] x-c2processedorg: 51b406b7-48a2-4d03-b652-521f56ac89f3 Content-ID: <26B40BE5F01BA54ABC9C4ADADFF6A1D6@snt-world.com> MIME-Version: 1.0 X-SnT-MailScanner-Information: Please contact the ISP for more information X-SnT-MailScanner-ID: 4DC0E67A7D5.AFBD6 X-SnT-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details X-SnT-MailScanner-SpamCheck: X-SnT-MailScanner-From: frieder.schrempf@kontron.de X-SnT-MailScanner-To: dan.j.williams@intel.com, dmaengine@vger.kernel.org, festevam@gmail.com, kernel@pengutronix.de, linus.ml.walleij@gmail.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org, vkoul@kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200224_092207_929862_C0410437 X-CRM114-Status: GOOD ( 16.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24.02.20 18:16, Schrempf Frieder wrote: > From: Frieder Schrempf > > On i.MX6 the DMA event for the RX channel of UART6 is '0'. To fix > the broken DMA support for UART6, we change the check for event_id0 > to include '0' as a valid id. > > Fixes: 1ec1e82f2510 ("dmaengine: Add Freescale i.MX SDMA support") > Cc: stable@vger.kernel Sorry, I messed up the stable tag. Will send again. > Signed-off-by: Frieder Schrempf > --- > drivers/dma/imx-sdma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index 066b21a32232..3d4aac97b1fc 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1331,7 +1331,7 @@ static void sdma_free_chan_resources(struct dma_chan *chan) > > sdma_channel_synchronize(chan); > > - if (sdmac->event_id0) > + if (sdmac->event_id0 >= 0) > sdma_event_disable(sdmac, sdmac->event_id0); > if (sdmac->event_id1) > sdma_event_disable(sdmac, sdmac->event_id1); > @@ -1631,7 +1631,7 @@ static int sdma_config(struct dma_chan *chan, > memcpy(&sdmac->slave_config, dmaengine_cfg, sizeof(*dmaengine_cfg)); > > /* Set ENBLn earlier to make sure dma request triggered after that */ > - if (sdmac->event_id0) { > + if (sdmac->event_id0 >= 0) { > if (sdmac->event_id0 >= sdmac->sdma->drvdata->num_events) > return -EINVAL; > sdma_event_enable(sdmac, sdmac->event_id0); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel