All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <niklas.cassel@axis.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Joao Pinto <Joao.Pinto@synopsys.com>, <linux-pci@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Cc: <hch@infradead.org>, <nsekhar@ti.com>
Subject: Re: [GIT PULL] PCI: Support for configurable PCI endpoint
Date: Wed, 29 Mar 2017 15:13:36 +0200	[thread overview]
Message-ID: <c506cc2c-b877-5a12-33a9-4fafa307ff89@axis.com> (raw)
In-Reply-To: <6868a887-a270-96d6-0600-af2a1af383a8@ti.com>

On 03/29/2017 02:36 PM, Kishon Vijay Abraham I wrote:
(snip)
>>>
>>> FWIW:
>>> I've tested Kishon's tag pci-endpoint-for-4.12
>>> and PCIe on artpec6 SoC is still working fine.
>>
>> Thanks for testing it.
>>>
>>> I also included the DRA7xx PCIe driver in my
>>> kernel so that pcie-designware-ep.c gets built.
>>>
>>> My only worry is that the code in pcie-designware-ep.c
>>> is not compile tested if DRA7xx is not selected
>>> (as it is the only driver using PCIE_DW_EP at
>>> the moment).
>>
>> yeah, we should plan to include COMPILE_TEST in all pci drivers but I guess
>> there is some problem with non-ARM builds [1]. As Bjorn mentioned in the
>> thread, we could add #ifdef ARM and then include COMPILE_TEST.
> 
> I think I misunderstood your concern. yeah, there is no direct way to compile
> pcie-designware-ep.c without selecting DRA7xx.

There is no way to compile pcie-designware-host.c + pcie-designware.c
without selecting a driver that selects PCIE_DW_HOST,
so I guess the same "problem" applies there.

As long as kbuild builds PCI_DRA7XX_EP (and any driver that selects
PCIE_DW_HOST), we should be fine.

WARNING: multiple messages have this Message-ID (diff)
From: Niklas Cassel <niklas.cassel@axis.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Joao Pinto <Joao.Pinto@synopsys.com>,
	linux-pci@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: hch@infradead.org, nsekhar@ti.com
Subject: Re: [GIT PULL] PCI: Support for configurable PCI endpoint
Date: Wed, 29 Mar 2017 15:13:36 +0200	[thread overview]
Message-ID: <c506cc2c-b877-5a12-33a9-4fafa307ff89@axis.com> (raw)
In-Reply-To: <6868a887-a270-96d6-0600-af2a1af383a8@ti.com>

On 03/29/2017 02:36 PM, Kishon Vijay Abraham I wrote:
(snip)
>>>
>>> FWIW:
>>> I've tested Kishon's tag pci-endpoint-for-4.12
>>> and PCIe on artpec6 SoC is still working fine.
>>
>> Thanks for testing it.
>>>
>>> I also included the DRA7xx PCIe driver in my
>>> kernel so that pcie-designware-ep.c gets built.
>>>
>>> My only worry is that the code in pcie-designware-ep.c
>>> is not compile tested if DRA7xx is not selected
>>> (as it is the only driver using PCIE_DW_EP at
>>> the moment).
>>
>> yeah, we should plan to include COMPILE_TEST in all pci drivers but I guess
>> there is some problem with non-ARM builds [1]. As Bjorn mentioned in the
>> thread, we could add #ifdef ARM and then include COMPILE_TEST.
> 
> I think I misunderstood your concern. yeah, there is no direct way to compile
> pcie-designware-ep.c without selecting DRA7xx.

There is no way to compile pcie-designware-host.c + pcie-designware.c
without selecting a driver that selects PCIE_DW_HOST,
so I guess the same "problem" applies there.

As long as kbuild builds PCI_DRA7XX_EP (and any driver that selects
PCIE_DW_HOST), we should be fine.

WARNING: multiple messages have this Message-ID (diff)
From: Niklas Cassel <niklas.cassel@axis.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Joao Pinto <Joao.Pinto@synopsys.com>, <linux-pci@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Cc: hch@infradead.org, nsekhar@ti.com
Subject: Re: [GIT PULL] PCI: Support for configurable PCI endpoint
Date: Wed, 29 Mar 2017 15:13:36 +0200	[thread overview]
Message-ID: <c506cc2c-b877-5a12-33a9-4fafa307ff89@axis.com> (raw)
In-Reply-To: <6868a887-a270-96d6-0600-af2a1af383a8@ti.com>

On 03/29/2017 02:36 PM, Kishon Vijay Abraham I wrote:
(snip)
>>>
>>> FWIW:
>>> I've tested Kishon's tag pci-endpoint-for-4.12
>>> and PCIe on artpec6 SoC is still working fine.
>>
>> Thanks for testing it.
>>>
>>> I also included the DRA7xx PCIe driver in my
>>> kernel so that pcie-designware-ep.c gets built.
>>>
>>> My only worry is that the code in pcie-designware-ep.c
>>> is not compile tested if DRA7xx is not selected
>>> (as it is the only driver using PCIE_DW_EP at
>>> the moment).
>>
>> yeah, we should plan to include COMPILE_TEST in all pci drivers but I guess
>> there is some problem with non-ARM builds [1]. As Bjorn mentioned in the
>> thread, we could add #ifdef ARM and then include COMPILE_TEST.
> 
> I think I misunderstood your concern. yeah, there is no direct way to compile
> pcie-designware-ep.c without selecting DRA7xx.

There is no way to compile pcie-designware-host.c + pcie-designware.c
without selecting a driver that selects PCIE_DW_HOST,
so I guess the same "problem" applies there.

As long as kbuild builds PCI_DRA7XX_EP (and any driver that selects
PCIE_DW_HOST), we should be fine.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: niklas.cassel@axis.com (Niklas Cassel)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] PCI: Support for configurable PCI endpoint
Date: Wed, 29 Mar 2017 15:13:36 +0200	[thread overview]
Message-ID: <c506cc2c-b877-5a12-33a9-4fafa307ff89@axis.com> (raw)
In-Reply-To: <6868a887-a270-96d6-0600-af2a1af383a8@ti.com>

On 03/29/2017 02:36 PM, Kishon Vijay Abraham I wrote:
(snip)
>>>
>>> FWIW:
>>> I've tested Kishon's tag pci-endpoint-for-4.12
>>> and PCIe on artpec6 SoC is still working fine.
>>
>> Thanks for testing it.
>>>
>>> I also included the DRA7xx PCIe driver in my
>>> kernel so that pcie-designware-ep.c gets built.
>>>
>>> My only worry is that the code in pcie-designware-ep.c
>>> is not compile tested if DRA7xx is not selected
>>> (as it is the only driver using PCIE_DW_EP at
>>> the moment).
>>
>> yeah, we should plan to include COMPILE_TEST in all pci drivers but I guess
>> there is some problem with non-ARM builds [1]. As Bjorn mentioned in the
>> thread, we could add #ifdef ARM and then include COMPILE_TEST.
> 
> I think I misunderstood your concern. yeah, there is no direct way to compile
> pcie-designware-ep.c without selecting DRA7xx.

There is no way to compile pcie-designware-host.c + pcie-designware.c
without selecting a driver that selects PCIE_DW_HOST,
so I guess the same "problem" applies there.

As long as kbuild builds PCI_DRA7XX_EP (and any driver that selects
PCIE_DW_HOST), we should be fine.

  reply	other threads:[~2017-03-29 13:13 UTC|newest]

Thread overview: 135+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27  9:44 [GIT PULL] PCI: Support for configurable PCI endpoint Kishon Vijay Abraham I
2017-03-27  9:44 ` Kishon Vijay Abraham I
2017-03-27  9:44 ` Kishon Vijay Abraham I
2017-03-27  9:44 ` Kishon Vijay Abraham I
2017-03-27  9:44 ` [PATCH v5 01/24] PCI: endpoint: Add EP core layer to enable EP controller and EP functions Kishon Vijay Abraham I
2017-03-27  9:44   ` Kishon Vijay Abraham I
2017-03-27  9:44   ` Kishon Vijay Abraham I
2017-03-27  9:44 ` [PATCH v5 02/24] Documentation: PCI: Guide to use PCI Endpoint Core Layer Kishon Vijay Abraham I
2017-03-27  9:44   ` Kishon Vijay Abraham I
2017-03-27  9:44   ` Kishon Vijay Abraham I
2017-03-27  9:44   ` Kishon Vijay Abraham I
2017-03-27  9:44 ` [PATCH v5 03/24] PCI: endpoint: Introduce configfs entry for configuring EP functions Kishon Vijay Abraham I
2017-03-27  9:44   ` Kishon Vijay Abraham I
2017-03-27  9:44   ` Kishon Vijay Abraham I
2017-03-27  9:44   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 04/24] Documentation: PCI: Guide to use pci endpoint configfs Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 05/24] PCI: endpoint: Create configfs entry for EPC device and EPF driver Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 06/24] Documentation: PCI: Add specification for the *pci test* function device Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 07/24] PCI: endpoint: functions: Add an EP function to test PCI Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 08/24] Documentation: PCI: Add binding documentation for pci-test endpoint function Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 09/24] PCI: dwc: designware: Add EP mode support Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 10/24] dt-bindings: PCI: Add dt bindings for pci designware EP mode Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 11/24] PCI: dwc: dra7xx: Facilitate wrapper and msi interrupts to be enabled independently Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 12/24] PCI: dwc: dra7xx: Add EP mode support Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 13/24] dt-bindings: PCI: dra7xx: Add dt bindings for pci dra7xx EP mode Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 14/24] dt-bindings: mfd: syscon: Add documentation for #syscon-cells property Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-31 18:58   ` Rob Herring
2017-03-31 18:58     ` Rob Herring
2017-03-31 18:58     ` Rob Herring
2017-03-31 19:06     ` Rob Herring
2017-03-31 19:06       ` Rob Herring
2017-03-31 19:06       ` Rob Herring
2017-04-05  8:25       ` Kishon Vijay Abraham I
2017-04-05  8:25         ` Kishon Vijay Abraham I
2017-04-05  8:25         ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 15/24] PCI: dwc: dra7xx: Workaround for errata id i870 Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 16/24] dt-bindings: PCI: dra7xx: Add dt bindings to enable unaligned access Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-31 19:07   ` Rob Herring
2017-03-31 19:07     ` Rob Herring
2017-03-31 19:07     ` Rob Herring
2017-03-27  9:45 ` [PATCH v5 17/24] PCI: Add device IDs for DRA74x and DRA72x Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 18/24] misc: Add host side pci driver for pci test function device Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 19/24] Documentation: misc-devices: Add Documentation for pci-endpoint-test driver Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 20/24] tools: PCI: Add a userspace tool to test PCI endpoint Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 21/24] tools: PCI: Add sample test script to invoke pcitest Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 22/24] Documentation: PCI: Add userguide for PCI endpoint test function Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 23/24] MAINTAINERS: add PCI EP maintainer Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45 ` [PATCH v5 24/24] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-27  9:45   ` Kishon Vijay Abraham I
2017-03-29 11:42 ` [GIT PULL] PCI: Support for configurable PCI endpoint Niklas Cassel
2017-03-29 11:42   ` Niklas Cassel
2017-03-29 11:42   ` Niklas Cassel
2017-03-29 11:42   ` Niklas Cassel
2017-03-29 12:10   ` Kishon Vijay Abraham I
2017-03-29 12:10     ` Kishon Vijay Abraham I
2017-03-29 12:10     ` Kishon Vijay Abraham I
2017-03-29 12:10     ` Kishon Vijay Abraham I
2017-03-29 12:36     ` Kishon Vijay Abraham I
2017-03-29 12:36       ` Kishon Vijay Abraham I
2017-03-29 12:36       ` Kishon Vijay Abraham I
2017-03-29 13:13       ` Niklas Cassel [this message]
2017-03-29 13:13         ` Niklas Cassel
2017-03-29 13:13         ` Niklas Cassel
2017-03-29 13:13         ` Niklas Cassel
2017-04-04 20:36 ` Bjorn Helgaas
2017-04-04 20:36   ` Bjorn Helgaas
2017-04-04 20:36   ` Bjorn Helgaas
2017-04-05  8:47   ` Kishon Vijay Abraham I
2017-04-05  8:47     ` Kishon Vijay Abraham I
2017-04-05  8:47     ` Kishon Vijay Abraham I
2017-04-05  8:52 Kishon Vijay Abraham I
2017-04-05  8:52 ` Kishon Vijay Abraham I
2017-04-05  8:52 ` Kishon Vijay Abraham I
2017-04-05  8:52 ` Kishon Vijay Abraham I
2017-04-10 15:43 ` Bjorn Helgaas
2017-04-10 15:43   ` Bjorn Helgaas
2017-04-10 15:43   ` Bjorn Helgaas
2017-04-10 15:43   ` Bjorn Helgaas
2017-04-11 19:34   ` Bjorn Helgaas
2017-04-11 19:34     ` Bjorn Helgaas
2017-04-11 19:34     ` Bjorn Helgaas
2017-04-12  5:43     ` Kishon Vijay Abraham I
2017-04-12  5:43       ` Kishon Vijay Abraham I
2017-04-12  5:43       ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c506cc2c-b877-5a12-33a9-4fafa307ff89@axis.com \
    --to=niklas.cassel@axis.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.